Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Jun 2023 11:12:06 +0300
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Neil Armstrong <neil.armstrong@linaro.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/3] usb: typec: ucsi: call typec_set_mode on non-altmode
 partner change
Message-ID: <ZJlIViwb9sfNrgjH@kuha.fi.intel.com>
References: <20230614-topic-sm8550-upstream-type-c-audio-v1-0-15a92565146b@linaro.org>
 <20230614-topic-sm8550-upstream-type-c-audio-v1-1-15a92565146b@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230614-topic-sm8550-upstream-type-c-audio-v1-1-15a92565146b@linaro.org>
Precedence: bulk

Hi Neil,

Sorry to keep you waiting.

On Wed, Jun 14, 2023 at 03:10:39PM +0200, Neil Armstrong wrote:
> Add support for calling typec_set_mode() for the DEBUG, AUDIO
> accessory modes.
> 
> Let's also call typec_set_mode() for USB as default and SAFE
> when partner is disconnected.
> 
> The USB state is only called when ALT mode is specifically
> not specified by the partner status flags in order
> to leave the altmode handlers setup the proper mode to
> switches, muxes and retimers.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  drivers/usb/typec/ucsi/ucsi.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index 2b472ec01dc4..44f43cdea5c1 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -809,6 +809,23 @@ static void ucsi_partner_change(struct ucsi_connector *con)
>  		break;
>  	}
>  
> +	if (con->status.flags & UCSI_CONSTAT_CONNECTED) {
> +		switch (UCSI_CONSTAT_PARTNER_TYPE(con->status.flags)) {
> +		case UCSI_CONSTAT_PARTNER_TYPE_DEBUG:
> +			typec_set_mode(con->port, TYPEC_MODE_DEBUG);
> +			break;
> +		case UCSI_CONSTAT_PARTNER_TYPE_AUDIO:
> +			typec_set_mode(con->port, TYPEC_MODE_AUDIO);
> +			break;
> +		default:
> +			if (UCSI_CONSTAT_PARTNER_FLAGS(con->status.flags) ==
> +					UCSI_CONSTAT_PARTNER_FLAG_USB)
> +				typec_set_mode(con->port, TYPEC_STATE_USB);
> +		}
> +	} else {
> +		typec_set_mode(con->port, TYPEC_STATE_SAFE);
> +	}

Can you do that (set safe mode) in ucsi_unregister_partner() instead?

thanks,

-- 
heikki