Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Jun 2023 10:00:38 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Nipun Gupta <nipun.gupta@amd.com>
Cc:     maz@kernel.org, tglx@linutronix.de, jgg@ziepe.ca,
        linux-kernel@vger.kernel.org, git@amd.com, harpreet.anand@amd.com,
        pieter.jansen-van-vuuren@amd.com, nikhil.agarwal@amd.com,
        michal.simek@amd.com, abhijit.gangurde@amd.com
Subject: Re: [PATCH v2] cdx: add MSI support for CDX bus
Message-ID: <2023062612-navigate-hyphen-6fc7@gregkh>
References: <20230518114418.18025-1-nipun.gupta@amd.com>
 <ffb49486-4e29-a44d-97f6-18fea5386ba1@amd.com>
 <d866dba9-3b0f-3573-9baf-0d02f4049fcb@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d866dba9-3b0f-3573-9baf-0d02f4049fcb@amd.com>
Precedence: bulk

On Mon, Jun 26, 2023 at 01:23:27PM +0530, Nipun Gupta wrote:
> 
> 
> On 6/6/2023 4:32 PM, Nipun Gupta wrote:
> > 
> > 
> > On 5/18/2023 5:14 PM, Nipun Gupta wrote:
> > > Add CDX-MSI domain per CDX controller with gic-its domain as
> > > a parent, to support MSI for CDX devices. CDX devices allocate
> > > MSIs from the CDX domain. Also, introduce APIs to alloc and free
> > > IRQs for CDX domain.
> > > 
> > > In CDX subsystem firmware is a controller for all devices and
> > > their configuration. CDX bus controller sends all the write_msi_msg
> > > commands to firmware running on RPU and the firmware interfaces with
> > > actual devices to pass this information to devices
> > > 
> > > Since, CDX controller is the only way to communicate with the Firmware
> > > for MSI write info, CDX domain per controller required in contrast to
> > > having a CDX domain per device.
> > > 
> > > Co-developed-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
> > > Signed-off-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
> > > Co-developed-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
> > > Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
> > > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
> > > Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
> > > Tested-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
> > > ---
> > > 
> > > Changes v1->v2:
> > > - fixed scenario where msi write was called asyncronously in
> > > ?? an atomic context, by using irq_chip_(un)lock, and using sync
> > > ?? MCDI API for write MSI message.
> > > - fixed broken Signed-off-by chain.
> > 
> > Hi Thomas,
> > 
> > Did you had a chance to look at patch v2. Please let me know in case
> > anything else is required to be updated.
> 
> Hi Thomas,
> 
> A gentle reminder, could you please have a look into this updated version of
> the patch?

It's the middle of the merge window, nothing we can do now with new
stuff.  Perhaps resend it after 6.5-rc1 is out and you have rebased it
against that release?

thanks,

greg k-h