Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0050f8d2-a4cd-2b84-77ad-6fa93bb14b16@arm.com>
Date:   Mon, 26 Jun 2023 09:09:23 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.9.0
Subject: Re: [PATCH] perf tests: Fix test_arm_callgraph_fp variable expansion
To:     Markus Elfring <Markus.Elfring@web.de>
Cc:     LKML <linux-kernel@vger.kernel.org>, cocci@inria.fr,
        linux-perf-users@vger.kernel.org, spoorts2@in.ibm.com,
        kernel-janitors@vger.kernel.org,
        Adrian Hunter <adrian.hunter@intel.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Athira Rajeev <atrajeev@linux.vnet.ibm.com>,
        Ian Rogers <irogers@google.com>,
        Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@kernel.org>,
        Kajol Jain <kjain@linux.ibm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>
References: <20230622101809.2431897-1-james.clark@arm.com>
 <2b1cec46-52a9-21f1-bfcd-fbb4298f072a@web.de>
Content-Language: en-US
From:   James Clark <james.clark@arm.com>
In-Reply-To: <2b1cec46-52a9-21f1-bfcd-fbb4298f072a@web.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 23/06/2023 17:56, Markus Elfring wrote:
> …
>> At the same time silence the shellcheck warning for that line and fix
>> two more shellcheck errors at the end of the script.
> 
> Does such a wording really fit to the known requirement “Solve only one problem per patch.”?
> 
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4-rc7#n81
> 
> 
> Regards,
> Markus

I think so, it fixes all the shellcheck errors that were claimed to be
fixed and introduced by the referenced fix.

To be honest I would have rather just reverted the original change
completely because it was obviously never tested.