Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Naohiro Aota <Naohiro.Aota@wdc.com>
To:     Julia Lawall <Julia.Lawall@inria.fr>
CC:     Chris Mason <clm@fb.com>,
        "keescook@chromium.org" <keescook@chromium.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>,
        "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 12/26] btrfs: zoned: use array_size
Thread-Topic: [PATCH 12/26] btrfs: zoned: use array_size
Thread-Index: AQHZphizIhRB2GmehkeoJCxF7dG1za+cvAMA
Date:   Mon, 26 Jun 2023 07:59:16 +0000
Message-ID: <7aufdhkqug3bvwlgl727k3ga2mnu3lcgyj3enkl3kjub235q75@rjfmkktmpsi2>
References: <20230623211457.102544-1-Julia.Lawall@inria.fr>
 <20230623211457.102544-13-Julia.Lawall@inria.fr>
In-Reply-To: <20230623211457.102544-13-Julia.Lawall@inria.fr>
Accept-Language: ja-JP, en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BDe7/ibnyW+UG8ejJIrriPAgZBfR16iv+z9vqhQ4DTvt64lFq76JBW2+YSVw?=
 =?us-ascii?Q?LA3G37QI6Q4VTEi/WNvaDUzf61leJs8mefs8x0k7hF9OfO3+YkISlKhUlk9k?=
 =?us-ascii?Q?HHeX5u/hLBBkQb5qym22K7DoNHeGQXurjs7xNq2kqZGelw2ITr3MmIxWnCd+?=
 =?us-ascii?Q?A7sBkB+IDxqpNU+uFH772NqMvUcoo2FVUg7nTgdQM9hWLknWfv4sng/GMhSs?=
 =?us-ascii?Q?vCe9t/axzNKAid7zP7RlrEs5DXnC/zrB+oZpp68WqYGTTkjaHTDc/851phi0?=
 =?us-ascii?Q?N5tAI7wvw+aAKIGpnZbV7MR3ZSe0u83peB+xp6xhubvaS3QC4+s+y382BQqL?=
 =?us-ascii?Q?tPBbfAgqa7FdpMTQQH9Iw3PL2UDIEWt4+q81OIp4PQRyJlHyRdgTcJus/YV4?=
 =?us-ascii?Q?04GBIiEvk2HEK7bTcxiJNMBNOzS/ZDOr72rcJpdYk1xWrWYxDJ8VZR2NN4Pa?=
 =?us-ascii?Q?s2Lk5/vRQdh5bM4SarZDDoKqM/FMBe+g3TAyrU7Dw1jiwNFtZL8XIXV+iJSL?=
 =?us-ascii?Q?XLo1nJpWZDAePUYrzI1TvGdlWrzrZyIByfttEzCMtnnrySJWU6hD0MGLWp7Y?=
 =?us-ascii?Q?yhtN5UDOV7n9CQ79v851tH6n2H7Ha9Dkygr7x1yMZeRbEsK/tPhqPTk/iCTU?=
 =?us-ascii?Q?w4U116g0DQ5rUZlOE7ldg9cqkGlKT96eaMaELt61fk0bnixeSDWmVxBIO2x+?=
 =?us-ascii?Q?mDMqcdbKOnMOWJdriqlBs/huTPJ8JbSP7F5AVOqyHawVfno0ezeQlV76aace?=
 =?us-ascii?Q?VmBDRIWR44zWRlMF3Pmo2YVffraWUjJj5/oBJeJXbUJNEoMx3EJP6c0zGVE+?=
 =?us-ascii?Q?8WdLiqVv+z0bFiDiZlDC/5JsHmhLzkByPQ9BfFtB7NE72hygk9tMEzAY5/ow?=
 =?us-ascii?Q?6T1NzZprNPo53kqNMY4pVm9vE7NWOkfgv4pBu35jqpvOxQd1G7jDgoFrPrTf?=
 =?us-ascii?Q?WG96ZzZ+5Vm0Q0oETKc4rcgQegmLUoNnMJJO3m0K8vIEQC6Ph5eCWKRFIbAW?=
 =?us-ascii?Q?44HwfN1eat1iY0Ghf+XcKJpZ2Omrb690AZ/N5Id8HE1FQd3d7Lq14aFy1ftp?=
 =?us-ascii?Q?pe8bbhTbwveWaYuN/w2jXXRPIZnDPFyK0ypjByf7zgjChGqWczrVHy17y+M/?=
 =?us-ascii?Q?Zpkc/Mcood1OFwgIL09rwqFYMwDjCQ5FKae/R7UyQ/ktCHHJYUPBPywJHDvD?=
 =?us-ascii?Q?VdiBnBiOAN52rzHeOxvi2B89jd1Siza6LfEjlNiJf8J3i2jbnVYhpTC9B42y?=
 =?us-ascii?Q?ViWGCir9qqjddCt6HJaMQ3IJIfUJ6AJrblyZa2bghB60zshSIHh2iAGGtmAX?=
 =?us-ascii?Q?0lIpk9JqNl7TiapPReAzhKq1K5J4N7RQjpnQmzUqr5OGuXnn5rrdv4CMP2cE?=
 =?us-ascii?Q?VxbXzmsLAdBoixOozY9z0eN0KbJIuAJGIC6mx7/mfcusjyp/jA5HmrtxUOJ4?=
 =?us-ascii?Q?CgitJ9PGhIBsniainSZGo6N8wOT5lYBv/Gu/YLxI09ZVSgr1wf9Zo465vvwI?=
 =?us-ascii?Q?KE1PPfSYvxP3w1S0u3g837EHulmT0xdBFszHQ4u8nNWZ1Z9S5zw/KGUCrTOO?=
 =?us-ascii?Q?3KG0flRsQX8f9wrYyUFQJ0Z5ZoqiPLYre0oxitHayhD92R8vX2TNruc8IkQz?=
 =?us-ascii?Q?Lw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <422ADA48925B7544A9611B225B7B9424@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: coMbvYZKhd+OxeJfR9+ag8niNopGsclEhVCodgJgyfbwuG3QZxuqPUKZclk/tg+MUqAxcUMTUMFBSfK5CQ4Lvt0eRvHymJL9dKsYpS042i0loDMs+rTt+zbp9E5QmKPBFoqwozQnOp/kQoL3FwMbTBg+Zxfio7NQWEmiwohTO8j0Kl723mMmZ+NJjEgH7bemmxfLNklzMrLq49pMC1qEpqAHtBD3PtfYBm7c2smGD30ekRkBObws+h/4Kd9UULzIIoXRV5hzEkRc/SVDec6vTIufbOv0sYmZunEScR7eytg5eSmc3CTZu1nb9JSkQMR3lAh9JIBwK6j4gYYc/cAr5wt2wnYvpJyz//2lLfy8TSSSzm5gh5Y6srXuc9lNSAgNyE0SP5+TqO8TYu5J5Lz3f4PWqa4eSeiHXhv5eLu4V6AFxvuTTCU13AK+SSH6h+SL5P4RhMW00yG0Eq67f/8fNiz5QkHrwglJKEk6XJgkHyCsijGqKUqaB1BcUfjfu/er+DqaD3aFh4kFHGKJD3Av5XRHcL+nK/Ns+3Mgk3NtUyphOW/frONVFYF7GdxOpK/SnR4lJmdjGjitoLd6/6/3ucDS+VmqM/mV5yUtSCo7zs22s/psVgzY+W/pCgLmD7xmz8iJ2K7Hh9GfX0fYB3SEqevhxdBfKN+85Cy3Sm8e6l3DIJNk+spJxk8vXHgtlFHV3idmBEGzX9Dw46lZb7l6mB7Q0QmSDpuTTgpPM27R2cUZeIa9jg2J17U6J2xyST+chx9cd9dQ3ebYY4klxJpj2CXd+a++P5I1gORpARhobxMJQzhBhW+TF3svJH0I8Tdq1R8UQX6kt/7wmDwcRSTD766Isz4kKnkdjtQOGpfXl69ofm3iud1tlbnsjaWhvNJSOahrJq6io+vrFEWp2iIrX2D6g/QOf2mP80X/RIgIYZY=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR04MB7776.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21ac846f-0918-4e70-4a05-08db761b3d73
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2023 07:59:17.0118
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Y40bxuOdv2RhSRIuGcZ5VuxuyDY4BoRFZKmuw1GZngtKfej3E/45BV5wKrkROdfxrEDSGT7TdLCdsjoUvIeTMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR04MB8653
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 23, 2023 at 11:14:43PM +0200, Julia Lawall wrote:
> Use array_size to protect against multiplication overflows.
>=20
> The changes were done using the following Coccinelle semantic patch:
>=20
> // <smpl>
> @@
>     size_t e1,e2;
>     expression COUNT;
>     identifier alloc =3D {vmalloc,vzalloc,kvmalloc,kvzalloc};
> @@
>=20
> (
>       alloc(
> -           (e1) * (e2)
> +           array_size(e1, e2)
>       ,...)
> |
>       alloc(
> -           (e1) * (COUNT)
> +           array_size(COUNT, e1)
>       ,...)
> )
> // </smpl>
>=20
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

Looks good.

Reviewed-by: Naohiro Aota <naohiro.aota@wdc.com>=