Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b2126d18-c9d9-0e93-952f-fbedd478b587@amd.com>
Date:   Mon, 26 Jun 2023 14:07:25 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v2] cdx: add MSI support for CDX bus
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     maz@kernel.org, tglx@linutronix.de, jgg@ziepe.ca,
        linux-kernel@vger.kernel.org, git@amd.com, harpreet.anand@amd.com,
        pieter.jansen-van-vuuren@amd.com, nikhil.agarwal@amd.com,
        michal.simek@amd.com, abhijit.gangurde@amd.com
References: <20230518114418.18025-1-nipun.gupta@amd.com>
 <ffb49486-4e29-a44d-97f6-18fea5386ba1@amd.com>
 <d866dba9-3b0f-3573-9baf-0d02f4049fcb@amd.com>
 <2023062612-navigate-hyphen-6fc7@gregkh>
From:   Nipun Gupta <nipun.gupta@amd.com>
In-Reply-To: <2023062612-navigate-hyphen-6fc7@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDJBOWVVNklsTjI2akl0UlZxK2ZGY3plZm15OWFQQUZNQkU1K25rY0p2VXds?=
 =?utf-8?B?QjFUSWFuMHRnRFNLOUhsdU44Q3JzTUZlemd2dlprcUNFaVJRdllUd0x2TXpy?=
 =?utf-8?B?MXpCdGlnUG8wdmhSalN5MHoweVVGS2RpcGNuaFdsVkRySHlQU0FTSnJLb25Z?=
 =?utf-8?B?a0l2OW13RUJZQ1BMbG9XbDRWYjA3SWpwTHVQY3NiWXBrZXRtT0tjRC9CUVV4?=
 =?utf-8?B?YVV3MlRzTVpTME50NWhId0QvQllVbUxFUXJKSzdiMTZ1aTlBcDE4TmM5YUla?=
 =?utf-8?B?cG9SK3pUR2wrdXRVQ0J6YmpCREhNMmFjRGdtWUhLOHZPbzZtZkx0Mk5pdUpB?=
 =?utf-8?B?eWlOc1Y2S2lSdStiVXNqRllvamYzQUxDL3ZDK1pzZWlPb2ZsUDBQNkJDbnFj?=
 =?utf-8?B?M2JjVXJwZEFmVW50bzBtbGRoSTdScXU2ZDBWcjZsam5lbnp2R2lkcGhmSHZk?=
 =?utf-8?B?ODJrbW9kWDdsVVUyWmJpaVVkVHdKWTJMRnpna2RNM2JCSlpicHFRNzYyZGl5?=
 =?utf-8?B?VGpjWUxTajZwQkU2RDJicFlzdzRnbW9GWjFLQisxSFJPVU5jTGN5RkZLaXU1?=
 =?utf-8?B?NUc5SzM1U1ZpeEJiQ0xBYmp3ODNzYS9zdTU4VVBReWovZlVyZHlSd1lUcTJv?=
 =?utf-8?B?dDg1d1RoQ0o2SFV2R2JVQ3VQN3JKQnpOY3JOL3BpUHZ3YVNMYjh3Y2tnRXVC?=
 =?utf-8?B?SDVwYlUxVU9kazlQSzhENDY0REd3OTEyMVA1RUx1eXJTRUdoZlhRVGpRK1Ri?=
 =?utf-8?B?M0NTTnY0V0c1RmVIRERvdm1vNkxMSkNKS0JWclNUYWlvT1RhSmlmY1VqMG1I?=
 =?utf-8?B?WVByMjFUNEthZENhOEhua0d6MXBiZzhhOCtzR0JXSmJpU3pUWXFmSHd5TDNs?=
 =?utf-8?B?Qy9YVVhqRkt1TWNSbm9ueDUvRk9MSlNsaUpkMHAreitXZExUZ0RpZXFPVU16?=
 =?utf-8?B?ZHB6TEUvbVVCVTVUREVnTTlWdEdFbW54U0N4d3Y2cGRoZ3Z3Vmh6YlY4cXc0?=
 =?utf-8?B?M01OSHZUNEQ5dnh1dTNXRC92eUF3Tk5PaDdvaXB0WVVGaXRUbnpuWnczU1VV?=
 =?utf-8?B?ekQzN0xTUE9rWU9HUDZmU25VSjVyczJBdHFja2g2b0hGSnlsbWpkNlkvQVl4?=
 =?utf-8?B?dUg2SlhqODJCaXlHdWdCTkgwR1hFRjI4K3FlbFBUSkZnWGFYYlFVZlVHQnp3?=
 =?utf-8?B?b2t0U2hjMjFMaDJ6Tm1yNGNhdlZvNDdHUXk1am9XQm1yeVRyOXJ6OEhTbklj?=
 =?utf-8?B?SnhHMzZCbGVqTVAya2dEMnBaOGhKdVUwZWV6K1pRcE5JN2VWeGFMUS9xVnlM?=
 =?utf-8?B?YitMSFI0QlZqMUhyZGZ5U3J0U1RuQjJveXBEMUpJcmFkZWxDdDVDY09GV01H?=
 =?utf-8?B?QjdTK0Radlpaei84R1cvTzdqdmpZOWx4WjR3ckNMcGVBZlp6L3hPc0RGUkJ3?=
 =?utf-8?B?aVVUZzBxUDVwZUZUOVk4TzAvOVVxMjRVUEQxczFCK1czTGd1YXZady9nM21o?=
 =?utf-8?B?OG1tKzRoNlNBTlZkdWRHNUJtcGlYZVUybCtmZzl2UWJZVTdrb1E1VnAya3J1?=
 =?utf-8?B?YjFZZHpSaHFvVnNoQzZCL3lmTmdtNnlmejNaSFpLQUNWbHYyVzg4emN5Mmk1?=
 =?utf-8?B?MjFBWnhqWGhIMXBlaXN6TERRcW1HSlRRTEVWNzlWeE5Nek9saUxjbG1BN20w?=
 =?utf-8?B?YW9vQmZKbUhpaXZXRVRHUmtKYTZpNnNhcVBMZFhFNmRWZ0kxTFBwdEJoMDNr?=
 =?utf-8?B?NWwwUlR4b2NYMFZ2OS9hV3J2SFlZeUY1QWFaMURhQU9QQzBQUTRIOExjN2Z5?=
 =?utf-8?B?RjM2RWtGS2gyTkFyUHEyVjJ6TkNIaWRKTE5BcWpXK2F6MnJOM3lzbmRCanI0?=
 =?utf-8?B?UEpWdk4xMDQ0NXMxWGZUYUVGRnAyZUZuSG9rbkZ6Y25Sa3hITlhqOGIwQVVh?=
 =?utf-8?B?U1lwL0dscjFZai9wZ3NkTmU2WnFuNHExQjdXNGI4V3Q0UlU0RUNzeGY0bzM4?=
 =?utf-8?B?eERPQUdpcC9mdmdXLzNZZUxxTnY4THBZQzQ1a281NElRdjN4UUs2dVdFanQz?=
 =?utf-8?B?RllvTE1QZzFQdEw0dHVncFRKdVp5NWVmL0I5aTJYL2ROMnZSSFNpMUY2a09l?=
 =?utf-8?Q?FEARfzAQ/IbKnUq9IbyOXNwLu?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e179571-3e9a-4a3b-d292-08db7620998c
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8308.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2023 08:37:39.4042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gutEai+68xJF2zl0f8u7UPMZXZIfXOq3qT7UVkkv1OM294hCaHVh0KZrmmKbucqL
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6700
X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/26/2023 1:30 PM, Greg KH wrote:
> On Mon, Jun 26, 2023 at 01:23:27PM +0530, Nipun Gupta wrote:
>>
>>
>> On 6/6/2023 4:32 PM, Nipun Gupta wrote:
>>>
>>>
>>> On 5/18/2023 5:14 PM, Nipun Gupta wrote:
>>>> Add CDX-MSI domain per CDX controller with gic-its domain as
>>>> a parent, to support MSI for CDX devices. CDX devices allocate
>>>> MSIs from the CDX domain. Also, introduce APIs to alloc and free
>>>> IRQs for CDX domain.
>>>>
>>>> In CDX subsystem firmware is a controller for all devices and
>>>> their configuration. CDX bus controller sends all the write_msi_msg
>>>> commands to firmware running on RPU and the firmware interfaces with
>>>> actual devices to pass this information to devices
>>>>
>>>> Since, CDX controller is the only way to communicate with the Firmware
>>>> for MSI write info, CDX domain per controller required in contrast to
>>>> having a CDX domain per device.
>>>>
>>>> Co-developed-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
>>>> Signed-off-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
>>>> Co-developed-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
>>>> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
>>>> Signed-off-by: Nipun Gupta <nipun.gupta@amd.com>
>>>> Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
>>>> Tested-by: Nikhil Agarwal <nikhil.agarwal@amd.com>
>>>> ---
>>>>
>>>> Changes v1->v2:
>>>> - fixed scenario where msi write was called asyncronously in
>>>>     an atomic context, by using irq_chip_(un)lock, and using sync
>>>>     MCDI API for write MSI message.
>>>> - fixed broken Signed-off-by chain.
>>>
>>> Hi Thomas,
>>>
>>> Did you had a chance to look at patch v2. Please let me know in case
>>> anything else is required to be updated.
>>
>> Hi Thomas,
>>
>> A gentle reminder, could you please have a look into this updated version of
>> the patch?
> 
> It's the middle of the merge window, nothing we can do now with new
> stuff.  Perhaps resend it after 6.5-rc1 is out and you have rebased it
> against that release?

Sure, will rebase and resend after 6.5-rc1 is out.

Thanks,
Nipun

> 
> thanks,
> 
> greg k-h