Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230625232528.89306-1-boqun.feng@gmail.com> <a79002ec-aa2d-1eec-58be-372c3b2a0efa@gmail.com>
In-Reply-To: <a79002ec-aa2d-1eec-58be-372c3b2a0efa@gmail.com>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Mon, 26 Jun 2023 11:40:33 +0200
Message-ID: <CANiq72kVUv4djvhLxz5tRYn-U2kXZMs0N1M=CZxdznnN0jY47Q@mail.gmail.com>
Subject: Re: [PATCH v2] rust: alloc: Add realloc and alloc_zeroed to the
 GlobalAlloc impl
To:     Martin Rodriguez Reboredo <yakoyoku@gmail.com>
Cc:     Boqun Feng <boqun.feng@gmail.com>, rust-for-linux@vger.kernel.org,
        linux-kernel@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Gary Guo <gary@garyguo.net>,
        =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        Benno Lossin <benno.lossin@proton.me>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jun 26, 2023 at 5:34=E2=80=AFAM Martin Rodriguez Reboredo
<yakoyoku@gmail.com> wrote:
>
> I think that this should go above Link and Signed-off-bys, although I'm
> not sure if maintainers do it when is merged.

Both styles are used, it is fine either way. Personally, I pick one or
the other depending on the kind of comment.

Having said that, there seems to be a missing `From:`, but I can fix
that on my side if Bj=C3=B6rn is the intended author.

> Newbie question, aren't tabs in the commit message verboten?

I am not aware of such a rule, and there are commits in the kernel
with tabs, e.g. commit 9828ed3f695a ("module: error out early on
concurrent load of the same module file").

In any case, that text doesn't go into the commit message, because it
is after the `---` line.

Cheers,
Miguel