Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Lu Hongfei <luhongfei@vivo.com>
To:     Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, luhongfei@vivo.com
Subject: [PATCH] fs: btrfs: Optimize code execution process to save time
Date:   Mon, 26 Jun 2023 18:07:16 +0800
Message-Id: <20230626100716.18935-1-luhongfei@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Cdb+iNZNV/3GXx/DCchui25yVXuDi50qVyQulEO2kysAg+zSyIzAMapoCTrz?=
 =?us-ascii?Q?hWVNyp4ETy+JChUxI7/t476rHVlteEDWFHK2HjHpO0+Zr0U+LWNchB94shQF?=
 =?us-ascii?Q?e5dJwOQOJvoVbS/zwNE9Al20wvDWAQEnQ7NUIRiFUDHokwMuOQGThFODH4WN?=
 =?us-ascii?Q?Tu3SODwOBdXgKDpytS1ELcZsn2Wf/781vAU8m8fetkFjUvuXAfMIQVP6RoZ1?=
 =?us-ascii?Q?LgxFd0AU5c2q3kwR6rPQ+ZPQO9XPgHx/9KTuwM4Ay+QSwyFmXZsdonFaB84Y?=
 =?us-ascii?Q?ZTSrIw6Vd9kLUsPq1rMHdM/IDEAY1RWkh/OzIS2IldbVD/8hWLd7U/zFnYft?=
 =?us-ascii?Q?2trod6ahHp9eQF9afDOT6Ze+rkR0cZbGifZclCTVR0VQSiYZGl9tarIOOWOQ?=
 =?us-ascii?Q?s71KT41ePxOcygFr39rj+u9GIpa9RGMYu3/WwNa4Dse0G/wUt6xtIQwMiQL+?=
 =?us-ascii?Q?Dilmbn+R37ZOlhCj2SQvZF9qt3xltuP96Qzo8D5bCTC1Qv33rUTuytWxKoe5?=
 =?us-ascii?Q?lKL2f1AE6YxmJSKVeBQG1rZtFp8O29cYw/o6mxwYgf3npYYvLo3Sh+/KpOIw?=
 =?us-ascii?Q?mWtURwNV3e3+3Roy45DDgpaJDzjI12OzbmMbFlPG1v1nE54+zGetcg2gvFyj?=
 =?us-ascii?Q?OeVoiOfSL+DOxTRuJCUbZCNkwRL+RmvoOcUxEAGqQlss+GYgwWZjkDi4KN2B?=
 =?us-ascii?Q?dwM7DiGkphVReZIuqUv0z2BHNEV1iyjAt1LcJHLp03W/0V1b1vexUG1enQ4x?=
 =?us-ascii?Q?USMwh98mfd7wiLAPxf9pzjfavmpYHqwmZO0x1XOfL1awnP9vI7TU2EnVdfUE?=
 =?us-ascii?Q?vVJAsEU0Ahj4r7OA7Tob4Z52ZCfTLW8gY59lKl52D4mi31QoZOYvCODCLvV0?=
 =?us-ascii?Q?A+7pMzxt/YItIGn8iPkn0Vr/09L0BlJpiHnvTTcyXjJzqFzyuowna50n5+qH?=
 =?us-ascii?Q?Pi8JyKUMAiqfs/ZQos6DdJyX2vWH21jU51cXkUaGiNTbv0sqmIeSpatZQcEr?=
 =?us-ascii?Q?faD+f9Ep/DMdTIJN5fOXrg+2TYb+deb1gTwHv+H5pkqA+n9x5t5zyRWE/PQC?=
 =?us-ascii?Q?EtgGb4axlX/FOcECzrjlJ72EIwfeBVRip7A3ishqmWb10UFlAsUp1s45F1AR?=
 =?us-ascii?Q?ROPKooxZ8o9E96kdZMSALCX/sqFk+wgHfUueKkdeWw8iSjtDC/PMtKUGAmHU?=
 =?us-ascii?Q?54jTBVVS/7eoreEKu/RnSTtQP73GxIaGaGr5SbKnfN32Js6ZHevO3YTg9Dn6?=
 =?us-ascii?Q?tx4AITbTrFKUkHbJgdpPn9WiUVPAbVv6ApYXVWrfhW2qmN3oEctKD9YnlbDD?=
 =?us-ascii?Q?NjDxuoUmftgqPO0LTipNdLSt0mUxus7KaTBS3uuXWrCydz+QFAqZwkEVxl9w?=
 =?us-ascii?Q?J0gFe5D1+IaTowWP+vHr2cX5hZb3bP3egZH9kWoqquKFUs+kpyJPHhGw1Z7L?=
 =?us-ascii?Q?vuV5VMdE+s7KURpjGcjzTadDBkNXIfvP+frwEFRwOL4ESlCXsPYv518jWae/?=
 =?us-ascii?Q?mklPMksjuVEbRyL+00/Jk6YaSZYl9kk5UrrfVXw8tzIssFCBvfdmTMqMo2Lx?=
 =?us-ascii?Q?odmVR3AIy1kGcdl2+3BOSFJP0HmqqNtLwRqXvR+q?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1624f149-b1c4-4d59-204b-08db762d2454
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB6697.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2023 10:07:25.9905
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: beSyTg8sTd9dhFv/tMZCDIo4dkxtp8i43foGwSpkgb0dhrSCMVYsPv3tLezt/CvZfSbwwL/d6ajmGx8CwoqCNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5755
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Originally, the btrfs_check_data_free_space used round_down twice when
aligning the range, which to some extent increased the execution time of
the code.
After optimization, round_down only needs to be executed once, which can
improve code efficiency and increase code readability.

Signed-off-by: Lu Hongfei <luhongfei@vivo.com>
---
 fs/btrfs/delalloc-space.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/btrfs/delalloc-space.c b/fs/btrfs/delalloc-space.c
index 427abaf608b8..fd33b1cf1954 100644
--- a/fs/btrfs/delalloc-space.c
+++ b/fs/btrfs/delalloc-space.c
@@ -137,9 +137,8 @@ int btrfs_check_data_free_space(struct btrfs_inode *inode,
 	int ret;
 
 	/* align the range */
-	len = round_up(start + len, fs_info->sectorsize) -
-	      round_down(start, fs_info->sectorsize);
 	start = round_down(start, fs_info->sectorsize);
+	len = round_up(start + len, fs_info->sectorsize) - start;
 
 	if (noflush)
 		flush = BTRFS_RESERVE_NO_FLUSH;
-- 
2.39.0