Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Jun 2023 19:11:14 +0900
From:   Masami Hiramatsu (Google) <mhiramat@kernel.org>
To:     Zheng Yejian <zhengyejian1@huawei.com>
Cc:     <rostedt@goodmis.org>, <shuah@kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-trace-kernel@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH] selftests/ftrace: Correctly enable event in
 instance-event.tc
Message-Id: <20230626191114.8c5a66fbaa28af3c303923bd@kernel.org>
In-Reply-To: <20230626001144.2635956-1-zhengyejian1@huawei.com>
References: <20230626001144.2635956-1-zhengyejian1@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 26 Jun 2023 08:11:44 +0800
Zheng Yejian <zhengyejian1@huawei.com> wrote:

> Function instance_set() expects to enable event 'sched_switch', so we
> should set 1 to its 'enable' file.
> 
> Testcase passed after this patch:
>   # ./ftracetest test.d/instances/instance-event.tc
>   === Ftrace unit tests ===
>   [1] Test creation and deletion of trace instances while setting an event
>   [PASS]
> 
>   # of passed:  1
>   # of failed:  0
>   # of unresolved:  0
>   # of untested:  0
>   # of unsupported:  0
>   # of xfailed:  0
>   # of undefined(test bug):  0
> 

Good catch!

Fixes: 91e6f1ce8657 ("ftracetest: Add instance created, delete, read and enable event test")

It seems this tests internally broken but the result is same because this disabled
error checking ('set +e').


> Signed-off-by: Zheng Yejian <zhengyejian1@huawei.com>
> ---
>  .../testing/selftests/ftrace/test.d/instances/instance-event.tc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/ftrace/test.d/instances/instance-event.tc b/tools/testing/selftests/ftrace/test.d/instances/instance-event.tc
> index 0eb47fbb3f44..42422e425107 100644
> --- a/tools/testing/selftests/ftrace/test.d/instances/instance-event.tc
> +++ b/tools/testing/selftests/ftrace/test.d/instances/instance-event.tc
> @@ -39,7 +39,7 @@ instance_read() {
>  
>  instance_set() {
>          while :; do
> -                echo 1 > foo/events/sched/sched_switch
> +                echo 1 > foo/events/sched/sched_switch/enable
>          done 2> /dev/null
>  }
>  
> -- 
> 2.25.1
> 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>