Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <01605914-60fc-9540-389b-7dc377990f1e@amd.com>
Date:   Mon, 26 Jun 2023 16:12:50 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2] perf evsel amd: Fix IBS error message
Content-Language: en-US
To:     acme@kernel.org
Cc:     peterz@infradead.org, irogers@google.com, jolsa@kernel.org,
        namhyung@kernel.org, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com,
        santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20230626103958.834-1-ravi.bangoria@amd.com>
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <20230626103958.834-1-ravi.bangoria@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dCtjeGl6WGhZTVdkWGRLWjNVQzhhM0NqK0tMTk5JUjUxeXpnK3pGd3RQSFc1?=
 =?utf-8?B?T2hVU21QdVZzRGprNGxjSExHVFFNdGdvNmhXMmRtV3lEWVZlRFQvZktuMngw?=
 =?utf-8?B?eGlaTVZaZ1dyOWN0OGU1bGtaOHZhMDBnOU5rSHJHZVpCTmhBandlUXdmS3BO?=
 =?utf-8?B?RElmNkg1OUI5VDB1TXk0NG8yZ1Y2MzRaZzZYUFJIZmlPSU9SbVhROVNZNEps?=
 =?utf-8?B?RzRnWi9OVEdSd0tuaFpGY1FXSGxHU2F0OGtCQ2RqYlRPL2NYc2ZwRUZDem4r?=
 =?utf-8?B?cUZZYzNCMExBYXVWT3NXMldFOTJRMCtqWE9MengrU3czVXlzUWt4WjBMbzZj?=
 =?utf-8?B?dE9zL0thd0RySjc3QXBsWndQUnZ2UGVFQ1F0dFFSSFNJK0ZDaDVRWTMyQXFr?=
 =?utf-8?B?TFRNMXZPdzkyTDljWVR0Mm9aZlUyQVJjdlV5c1ErRlJiWEJHdTFtYis4T3dv?=
 =?utf-8?B?UnFkNjFoVmNGVW85NU9nTlExMjFVTVBwU1cvTUJ0ZkVKZE5EdTNMNGtRY0xr?=
 =?utf-8?B?bHAreDAxTDQzc2NBaVM1czkyYUlpK2RlMTFTS0hDeU5CZ0VNdmRDa1p2Mzlq?=
 =?utf-8?B?UlRUQ2xjaFVTZDJsbXNYL0U2YTZFUVk1UXF5Q2w4bGU0Zm5ldTdhR09VbTdS?=
 =?utf-8?B?SnRjdlRqbkRYdm54cjh0YmRaek9XaWREZkxqbHFYcDBzWXROd1VLenVCRFNM?=
 =?utf-8?B?MmVERXBiYllKM1Vmd2QweTdtRHZpQnBIMGlSTjQyUy9ybGxmTjV1UFllZDlW?=
 =?utf-8?B?TnpTNFRpSTJHRU1peVRCa2Q1UVZ1dndpdkVkRm5WQldiN2prZUh3Umg5Sy9F?=
 =?utf-8?B?QkJCeEkremlyWXRLQVRYZlJjY0Nxc09SU1VhUHNxdWQxR1g2aTY4Y3hJK1Qz?=
 =?utf-8?B?czFPS3ZvSzBrWXhuV2ZhNzdKeXlYSTNyWGlGMmJJazY3VVhUc0VvenpTT2pW?=
 =?utf-8?B?SzRjQmpaMGxBeGtscVNreDRZdjNkcFVGYU5IZU5rL2VnMlQ0eGdhc2l3WitQ?=
 =?utf-8?B?SFhuS0lwN2x0ZkR6Nnp6KzlySUV4T1V6dDI0RnZnS1Qva0tnUW9aU3JjRVl0?=
 =?utf-8?B?cTZmejZSL2Jkc1FlVUtWeWxWc2lZSXVJMDhQS1JLKzRiN2RWVDFVTkZuV2pW?=
 =?utf-8?B?UjVRcyt6Vjk1R3d1bjJLYlFFcEl5NDZnR3U1Q21JTmhIa0ZRSEpFUGpXbEpk?=
 =?utf-8?B?bWVMeXp6UXlHcDdSczRrY2RKQ05TWnhDU2xJUXFxd3dmTFlqRTNYQUdsZ1Ex?=
 =?utf-8?B?RzhOSDlnZXdDbDA0YUhuU0U2b283VkZ5a2xNS0JvbTk3OVBrMjRJdkdmSTlz?=
 =?utf-8?B?Q29SUnBuT3dGTXNEeDk3bFRYeUZ4dUZ3ZmZWUit2dkRYaVppcVBQRTUwK3Bz?=
 =?utf-8?B?TlNwMU0yazcwT3FMWElPeUs2cEU2WVNiMkFJemtHakFOdDNtK3k5d2t5c2NS?=
 =?utf-8?B?NGttMFZpVm9mOUFiVzdXelREL1A3Q0Zoc09EZkYzUkdJVWlYbTViKzQyTGsy?=
 =?utf-8?B?c2JEN0FRc0FGa2Fyb2ZmYk9ZNlFvT1lGdy85dlNPY3RHOGdWMzNHS1VFTEM3?=
 =?utf-8?B?OUMxSGU0VXlBandtQzBYQ1FHYWJ4SDZMbFIvb3QxRm9zNVBPcXYrbXlHNzln?=
 =?utf-8?B?MUlTQlQ0UXp0ZXd6UHdHemtOZnIrUE5jT0QrczcxUGJzTTNqbGZRWHdxdmM1?=
 =?utf-8?B?MDR2Wk9JTVIvbVM4MUpEM1lITk5paUdadE1IL2pwVGN4WWt3K2hiaS9ML2Fi?=
 =?utf-8?B?UFM5S1BvWU95N0FKUC9qUXpwZ0kwMnlYS01tbUVoeUVtZHd4ZjJZRWFqTEc4?=
 =?utf-8?B?YVJUTW5vSElwcGRIR0JubEd4SytnRGxtM2FReTdEZkxrZ3F5RkwzNlVWdlB1?=
 =?utf-8?B?U3I5bDhBeGJoOE9TakV1MWJqdk10bGhPSElGSUYrU2NQc1JOREkwKzFkcURx?=
 =?utf-8?B?TWNBcHpSYjVwdVdWNzM3QkZuMUp3ZzN4NlU1QkZsWHR6K0dlUUtIZGhrVVZX?=
 =?utf-8?B?WGpza29rZVlFQU9DeG94RzhnazFHckdBb1NKS2NycUswbjRXK1F6Q0dhblAz?=
 =?utf-8?B?cDJGZXdGcVlzbWg1dzJBSmloK1pmNThTU2JoaEdWMHJMRm8rU1M1cHJyWVRS?=
 =?utf-8?Q?fa4FJH3z4LgE7iE4t0Ci5NzoW?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64916260-9847-4ffb-599b-08db76321f16
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2023 10:43:04.8394
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BUu5OufjDXDZyk+xrZcPZ6NhSP/Ks/ZJNiUsLGRv/vbzTUp3lw7GKLIcUNrevZ/f7zhE+X85q3FgMrfgSRsDiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8927
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 26-Jun-23 4:09 PM, Ravi Bangoria wrote:
> AMD IBS can do per-process profiling[1] and is no longer restricted to
> per-cpu or systemwide only. Remove stale error message. Also, checking
> just exclude_kernel is not sufficient since IBS does not support any
> privilege filters. So include all exclude_* checks. And finally, move
> these checks under tools/perf/arch/x86/ from generic code.
> 
> Before:
>   $ sudo ./perf record -e ibs_op//k -C 0
>   Error:
>   AMD IBS may only be available in system-wide/per-cpu mode.  Try
>   using -a, or -C and workload affinity
> 
> After:
>   $ sudo ./perf record -e ibs_op//k -C 0
>   Error:
>   AMD IBS doesn't support privilege filtering. Try again with
>   exclude_{kernel|user|hv|idle|host|guest}=0.

[1] https://git.kernel.org/torvalds/c/30093056f7b2