Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp15989490rwd; Mon, 26 Jun 2023 04:23:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7jGkv3RdzimVjzzuiNChmAgDt1snkbPYwkUroVFFZQfX7sLTa5Fp0HFAIEkS5N87MAN/rB X-Received: by 2002:a05:6808:1904:b0:398:27d3:1fc3 with SMTP id bf4-20020a056808190400b0039827d31fc3mr27556829oib.42.1687778594856; Mon, 26 Jun 2023 04:23:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687778594; cv=none; d=google.com; s=arc-20160816; b=xh74kwn/wPCeXE/pvn0n1oTgLXwJL9RhSi6abYimCsmBkosoBIwflUTjWcHSzKMllK ybJGmICHSl5lxaVZusVncpF1d9m9tc/kqqDAlysOmE2wfLnKwRtTY2UY36WY0dl3WX8w fbVp7E+CCAOtwY14r+iCt92ckj+ooUm6p/Ks4elBcStJ3IbPVnZE6CRmXh6beeLA8hPQ h0K61nEboiRGiejGr/Fgad08KgLZW7pgW9z6+okJ938hiiyofxsTo8Z7FieGbHA1xTjF NgnAJkN3+HttgHAZX+PldV0YmI6LGkZ7z0r4qPxtlFKMfCZNWjZjRAI3sSiNEdvs+SoA m8iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=N27YD/8w0kCccXqIKZbBV8ffJRY8sh2BlBSDCY/gqbU=; fh=fFopkoyd7A+tQ3c/LRF/DuXjejA28Be2Mb/AJAW0Y8c=; b=yoksKJXXBy7jD0DXAS1PVdcuGJH12lsqorxRV1mclyotROOI7U1VfpZ1yo3TXOLn+3 lRvYkWIHDpyGo10HRx1nT5iBzeV0qoJD30M9FA8XcJe9LvUx2olUc/eBzuUWpz4CrPqo F0IlkATSFTIyW+jPkaek8GswoQqgVMERnUpym4NKTEYYg1yLrq63IcNDqg9R3WPDqLjk zLV3EydN84abWlyAGHKGNKYtI037wsbCPMbpPgFdt+hiWd9/jEpLAPyVsvsHJumQpfcw fkXyx5B9DfiRY9C1MBAW2IM1sdUf0xZJN+wpSKkTPH8ldeJ+P/hk8nC0+NspKu54JP4R IBug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i62-20020a638741000000b0053fb7968569si4746249pge.429.2023.06.26.04.23.03; Mon, 26 Jun 2023 04:23:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230385AbjFZLNz (ORCPT + 99 others); Mon, 26 Jun 2023 07:13:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230361AbjFZLNx (ORCPT ); Mon, 26 Jun 2023 07:13:53 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98876EE; Mon, 26 Jun 2023 04:13:51 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="361283944" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="361283944" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 04:13:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="716096630" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="716096630" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 26 Jun 2023 04:13:47 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qDkAD-006kCY-1H; Mon, 26 Jun 2023 14:13:45 +0300 Date: Mon, 26 Jun 2023 14:13:45 +0300 From: "andy@kernel.org" To: YE Chengfeng Cc: Kent Gibson , "linus.walleij@linaro.org" , "brgl@bgdev.pl" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] gpio: gpiolib-cdev: Fix potential &lr->wait.lock deadlock issue Message-ID: References: <3C977550-9829-4A6F-A5CA-04C938D77693@connect.ust.hk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3C977550-9829-4A6F-A5CA-04C938D77693@connect.ust.hk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 26, 2023 at 10:38:53AM +0000, YE Chengfeng wrote: > > 1) do you have any warning/oops/etc to show the real case? > > 2) shouldn't we annotate with respective lockdep asserts this code? > The bugs were detected by an experimental static code analyzer that I am > implementing. I don't have input to trigger it, so I manually review the > report and then send the ones I believe to be true to you. Perhaps next > time I should mention this while sending the patch. This you have to mention in the submission. https://docs.kernel.org/process/researcher-guidelines.html -- With Best Regards, Andy Shevchenko