Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp16005028rwd; Mon, 26 Jun 2023 04:37:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6xBqgNNUc6e3FSKiOFwNdN2TNPjHcYrX6AQ6UM7U4v2SHf5gtinRh0hGzVjrg3UFB1QiaP X-Received: by 2002:a05:6a20:3956:b0:128:86a3:f7f3 with SMTP id r22-20020a056a20395600b0012886a3f7f3mr984503pzg.48.1687779420081; Mon, 26 Jun 2023 04:37:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687779420; cv=none; d=google.com; s=arc-20160816; b=u391251FJ4gFFqBCkd8P5J6iprrj/MJtA4rEhVsBkrahGJsUFbyR2V7/YKpkOJvddm xrfHeY03RlRoYC51phhVbF/3kInF8TrOAAQwiV+k6pdT6Bp/ATk11DhDWmh++oCTlSjW 4EdYwu88RMRvC2GIb6ryqqeNK9bNJVgZx9E1fZiPMAB3QRimwd+XwYbB1AI2Vt4ovYae akgvy9LKV24XNj2psgmT0bDxzhmoudoLz52Vz3fqhwKMGkiBpCGEmuBfsv11F0+YNyeS LhVzLAwWTyREJKGT/0Zq0Z8Mk72YlCzWZ015j9OAl7U0559jmTAByVTJBpavot8mEhqs DxFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=YMk/jt0hjdP/p4lqIVOY/ns31mw5RrXoRHRHl80RMgU=; fh=nGyJOLw6TRsn9OKdoCEnbS817PixtziwNdy/iFtQOZ4=; b=Pr1fmIZBmxTnmSLLqaflL/ABo2dKPIMzFmfYSEKdnF09fT51fGLESH92uel8rSaD3l 3nwlWqQUFuJ9Il/2HHx/W7K8a9mV3VRrxocQPUEsSZ5CZlUdWUk4G7N0XFudg9hRg3ii s78iTAyEy3H3PKAKj75PGb8+WsqOkzE7owX4iOEZETPA2vCq4bgi5KfimQh8/elSwMHY O/YZIz/2UmnrlSB71hM76Tx13v1Ozfkhx+c45XIXwatCXR7APLEV4RnIcWgrn1wsOOJm bnzCVDn1eR+qzjwz+RtTN4luDeZ0U53RZXlVBsvlIolVKqHFe8NMUhFFRh/Eoa04Kfo8 Sr/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=W4srQOuk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p41-20020a056a000a2900b00661cd40bd67si3019734pfh.314.2023.06.26.04.36.48; Mon, 26 Jun 2023 04:37:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=W4srQOuk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229481AbjFZLYu (ORCPT + 99 others); Mon, 26 Jun 2023 07:24:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbjFZLYt (ORCPT ); Mon, 26 Jun 2023 07:24:49 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FF0AFD; Mon, 26 Jun 2023 04:24:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687778687; x=1719314687; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Hbsx9lDG0ObqAYBCH/anLudkyMjn7A+iSFPOx7MPsBM=; b=W4srQOuk8xXvEbRDrJOuRMuYPhg/cD6qFcVJYpdiGzY5/Ti0DoRuvUX7 18Ln+f/MFLuNilLCUBX6i632DLVSR2A+yLS0oVUpobQfmn0f3EfthAB0z KvaHLufRcYmkeBZ5uZHINY21wZwp9rrFrAV8Ilv/1MNitf0VNHUSZCrjA cJZxxl/PBSGovCjSzg93rIY1KnLMGDOxcOgqej4l5iceMli797VvRyemO 1Xp/NmxO1d0dZgJEjQQPhT4vfWBPKfW38KxUQ3muCbX2ozYm1zFvXWwfn mMnqrramPsEVrwCGgPq93uo+u+6Vk9+B4ABIbkwXuyP8qzP+HM/eMEC9/ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="363790146" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="363790146" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 04:24:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10752"; a="1046477310" X-IronPort-AV: E=Sophos;i="6.01,159,1684825200"; d="scan'208";a="1046477310" Received: from csteeb-mobl2.ger.corp.intel.com (HELO intel.com) ([10.251.217.4]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2023 04:24:41 -0700 Date: Mon, 26 Jun 2023 13:24:38 +0200 From: Andi Shyti To: Thomas =?iso-8859-15?Q?Hellstr=F6m?= Cc: intel-xe@lists.freedesktop.org, Andrey Grodzovsky , Christian =?iso-8859-15?Q?K=F6nig?= , Huang Rui , dri-devel@lists.freedesktop.org, stable@vger.kernel.org, Nirmoy Das , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Christian =?iso-8859-15?Q?K=F6nig?= , Andi Shyti Subject: Re: [PATCH v2 3/4] drm/ttm: Don't leak a resource on eviction error Message-ID: References: <20230626091450.14757-1-thomas.hellstrom@linux.intel.com> <20230626091450.14757-4-thomas.hellstrom@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230626091450.14757-4-thomas.hellstrom@linux.intel.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, On Mon, Jun 26, 2023 at 11:14:49AM +0200, Thomas Hellstr?m wrote: > On eviction errors other than -EMULTIHOP we were leaking a resource. > Fix. > > v2: > - Avoid yet another goto (Andi Shyti) > > Fixes: 403797925768 ("drm/ttm: Fix multihop assert on eviction.") > Cc: Andrey Grodzovsky > Cc: Christian K?nig > Cc: Christian Koenig > Cc: Huang Rui > Cc: dri-devel@lists.freedesktop.org > Cc: # v5.15+ > Signed-off-by: Thomas Hellstr?m > Reviewed-by: Nirmoy Das #v1 Reviewed-by: Andi Shyti Andi