Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Jun 2023 12:49:12 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: core: Always store of_node when getting DAI link
 component
Message-ID: <9fbe4924-5c02-43f7-b47f-bc290fd07e67@sirena.org.uk>
References: <20230623-asoc-fix-meson-probe-v1-1-82b2c2ec5ca4@kernel.org>
 <87jzvrksi2.wl-kuninori.morimoto.gx@renesas.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="3CDck05rY9k9by3C"
Content-Disposition: inline
In-Reply-To: <87jzvrksi2.wl-kuninori.morimoto.gx@renesas.com>
Precedence: bulk


--3CDck05rY9k9by3C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Jun 25, 2023 at 11:54:29PM +0000, Kuninori Morimoto wrote:

> > The generic snd_soc_dai_get_dlc() contains a default translation function
> > for DAI names which has factored out common code in a number of card
> > drivers, resolving the dai_name and of_node either using a driver provided

> Yes, indeed.
> But I think we want to set it under lock and if ret was no error case ?

It doesn't really matter - there's only one possible result, and nothing
should be looking at the dlc unless we return success, but yes that'd
probably be a little cleaner providing we don't ever return early.

--3CDck05rY9k9by3C
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSZezcACgkQJNaLcl1U
h9BtEQf+INsq9seLiC6VRG4jRO5+qnpMCXRjGjCNE3PIyshFO46vmTbThLBD2WJ4
82psfBGU3USI8oSeR3uDUMsi7lh7hQq9n8IxaFVbr0TZTaD2EYctvzdRcT5zMbTY
hJ9NHlvfD/Yc6ryT3g3NMYMaHn2ghSUBBN72ihz3PR0VFJ5h4KZc1V6Xw84k7Ekq
qcLCNcIowshKkOZMF2DtiHh4LaPQxkOlKLpkWCdnwYlNPtLjAISRr5kS/8McMiVM
c82esARYyN56ajMf3pcxhZ0tr6kgCKIaydBh/6DQXLuybXheb6SQqb4BXvuervF2
9Mc8GrUj2SFs9x5B/a4KtbK2QRAJUg==
=8Ks5
-----END PGP SIGNATURE-----

--3CDck05rY9k9by3C--