Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Jun 2023 15:05:08 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     souradeep chakrabarti <schakrabarti@linux.microsoft.com>
Cc:     kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
        decui@microsoft.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, longli@microsoft.com,
        sharmaajay@microsoft.com, leon@kernel.org, cai.huoqing@linux.dev,
        ssengar@linux.microsoft.com, vkuznets@redhat.com,
        tglx@linutronix.de, linux-hyperv@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-rdma@vger.kernel.org, stable@vger.kernel.org,
        schakrabarti@microsoft.com
Subject: Re: [PATCH 1/2 V3 net] net: mana: Fix MANA VF unload when host is
 unresponsive
Message-ID: <ZJmNBKA3ygDryP7i@corigine.com>
References: <1687771058-26634-1-git-send-email-schakrabarti@linux.microsoft.com>
 <1687771098-26775-1-git-send-email-schakrabarti@linux.microsoft.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1687771098-26775-1-git-send-email-schakrabarti@linux.microsoft.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?//euGGiqDg7DorI1tgRW/NliooXaP67E7gEImr5ttMKRRgAb8kMcEHTt+Vv+?=
 =?us-ascii?Q?pL2PFebqbKd0YZCN93QWOjQQV2+iLhLth3rfzjp5Q/FK8xT2llxHeVUEK3Bn?=
 =?us-ascii?Q?N06ueOJ67ajOBp1cjMj4RK8EqpsauJs3EWb97I7RSNWYtVo8X73hzpgH1Nzb?=
 =?us-ascii?Q?7FflI+uAgtPQVNl88fLroR9qg1XMOJ+wkwZ/RxVKcMj+kDu1MdkFX8mnQeMf?=
 =?us-ascii?Q?xYkljKauHZFEIsaWz+jzelYKJpeXXq+A7/YS1FBQBbvxpiDsopB9u6igTApi?=
 =?us-ascii?Q?dWdZayVh5PPbnEo0E3uIW/HrfFTgQJBYCckUzU+U+e3qWnMXQzXH94s9L+p6?=
 =?us-ascii?Q?GPmPT686kpOYyEEaF8FMBrby+S99FqaNmHs6jGNMwV2hF9rXXBnf1H7L8Fq+?=
 =?us-ascii?Q?UoT6WvoM8In7uWnlmjut5vxopBuiUGyDhAdahO4/sx+VunUq9VC54BrTA08u?=
 =?us-ascii?Q?Wt11KaBMERI738XhgxpOA8hhS3dwNdrWL1UBtNor/E7wikFe24OKgxno0qr1?=
 =?us-ascii?Q?zrvJp3YrTgsFx3JZo0xilEtGzUNPoiWZeAOhx/ia1pAY60POIqBJLMiq7Xfu?=
 =?us-ascii?Q?siQrq35oQg5ekW5vJ0BPgclpmjV74BEIARvnrGEsO6zIxksV9yykkDf/6P7G?=
 =?us-ascii?Q?Q5ni4+oxIGNEIQCkST2MoRMjzR55H6CKRoikApCU+Ou5EICIIVys2iBi0RHq?=
 =?us-ascii?Q?/fMS3L2nZoKwpuC63iynts/XEK1A54GWMJEi0nNQfCttImDP5Vi2ecGI9ioR?=
 =?us-ascii?Q?mXheJbKqoXSrAVZTEIDc0+5ZtpanLxmNbMNw4ZUhbnz8dcG/y9iz1jteOdRa?=
 =?us-ascii?Q?QTJ5s09yZqKxahK5i1WXawZhVtkDbamzZAYORQfL4SxUq6gJTZFOAyytqGd1?=
 =?us-ascii?Q?XX9gWEe1bxGWc8jlKA64kMuUquYxjuxoZaL3InZ2QGEgMnaPKFyk0NTFbB9M?=
 =?us-ascii?Q?lE3y8ahcHOF1A5gY1bbFo+v4D8R2lGdB2ZlF2eWJaJgkg8SuhLO/x3HzJ4Q7?=
 =?us-ascii?Q?rPwPJgVolv4tsk81fVp6mYtN7Sm1QbdCFkdXq1EQA5P5NIPOj1Wp9pmWp8my?=
 =?us-ascii?Q?oU0OWNtfEnSgjGT0nNJiNNZHqKoc+MFxXYA22uD8PKVji8dOMO/jqvukgM7A?=
 =?us-ascii?Q?3W8O13wr8xAe0yA8NuYSgyPen4p4B3CkQhd5VN4QkakY0YPdhcZ8xki5W35h?=
 =?us-ascii?Q?tIso7tmYPvhDY3GdQ28c6QYnrx61U1syRunsFTRMu7QJPhr9M/Xr9lsqaeIW?=
 =?us-ascii?Q?P6ANdcEbKZnqkaCPtZ6ukSIaArzk27nkOQqUx6e/L0kJzfroa3wI0VCt+dB3?=
 =?us-ascii?Q?mL9eAjF+NnlpdZeL9M51MPsw+kZu0oczC+YTW73f+s5FLvtNmlXFjQCk7erJ?=
 =?us-ascii?Q?AhNoFWXLy9PSA7oA/GEsOUARA2u5EzfIBXRR5NUqYBNf8dLeTDUkNXl5nE81?=
 =?us-ascii?Q?Pq8qvkcv6YMlkDdtk6CDSffOpivWhEl3/081JO11ujL04mZF1kV5fMl+8weN?=
 =?us-ascii?Q?fiaYgSwaTndz9jR8xeQp0HwS+Zo3HUJjAIhACnOsAISA44wm/B9K+GQiKRla?=
 =?us-ascii?Q?u4fU/WJY1bXrTmzxWSt2Uvhrrimot+oCiMu6lfN3GXWqewiOoPNyfCZBWK/P?=
 =?us-ascii?Q?U4CSvPK6lFBg9KmAetDUVnbIqHumMFWP2DugIC2PFfuwBjHTzvLOdJimlqIF?=
 =?us-ascii?Q?bofYDw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 707cde5a-43e8-43a2-9ccc-08db7645fc83
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2023 13:05:16.6830
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mXiDuXvTDzMW4Fuyx0cgUpmq9Is78jHTN1tSMAPdopNmXKAefDyBdyT+G+fa/xDtqT74VO1AXHFebvqUjicRfGqh8ICKaXTaYQMpIORf6Bo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR13MB6337
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 26, 2023 at 02:18:18AM -0700, souradeep chakrabarti wrote:
> From: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>
> 
> This patch addresses the VF unload issue, where mana_dealloc_queues()
> gets stuck in infinite while loop, because of host unresponsiveness.
> It adds a timeout in the while loop, to fix it.
> 
> Fixes: ca9c54d2d6a5ab2430c4eda364c77125d62e5e0f (net: mana: Add a driver for
> Microsoft Azure Network Adapter)

nit: A correct format of this fixes tag is:

In particular:
* All on lone line
* Description in double quotes.

Fixes: ca9c54d2d6a5 ("net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)")

> Signed-off-by: Souradeep Chakrabarti <schakrabarti@linux.microsoft.com>
> ---
> V2 -> V3:
> * Splitted the patch in two parts.
> * Removed the unnecessary braces from mana_dealloc_queues().