Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Jun 2023 10:16:44 -0400
From:   Alan Stern <stern@rowland.harvard.edu>
To:     Guiting Shen <aarongt.shen@gmail.com>
Cc:     gregkh@linuxfoundation.org, nicolas.ferre@microchip.com,
        alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com,
        linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: ohci-at91: Fix the unhandle interrupt when resume
Message-ID: <1f33966d-3bc5-4ca3-bb6c-6e1d838c57f7@rowland.harvard.edu>
References: <20230625161553.11073-1-aarongt.shen@gmail.com>
 <552b1ac6-2149-48fa-9432-49655bfbc366@rowland.harvard.edu>
 <ed353f12-7ba7-1831-2ac7-b6135b2a5abb@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ed353f12-7ba7-1831-2ac7-b6135b2a5abb@gmail.com>
Precedence: bulk

On Mon, Jun 26, 2023 at 10:28:26AM +0800, Guiting Shen wrote:
> On Mon, Jun 26, 2023 at 04:04:29AM GMT+8, Alan Stern wrote:
> > This comment doesn't say why the code uses !ohci_at91->wakeup.  It 
> > should explain that.  For example:
> > 
> > 	/*
> > 	 * According to the comment in ohci_hcd_at91_drv_suspend()
> > 	 * we need to do a reset if the 48-MHz clock was stopped,
> > 	 * that is, if ohci_at91->wakeup is clear.  Tell ohci_resume()
> > 	 * to reset in this case by setting its "hibernated" flag.
> > 	 */
> > 
> 
> Ok, Thank you!
> Do I send the v3 patch after the merge window close?

You can send the patch at any time.  It doesn't matter whether the merge 
window is open or closed.

Alan Stern