Message-ID: <471941CC.6020200@garzik.org>
Date: Fri, 19 Oct 2007 19:46:20 -0400
From: Jeff Garzik <jeff@garzik.org>
User-Agent: Thunderbird 2.0.0.5 (X11/20070727)
MIME-Version: 1.0
To: "Eric W. Biederman" <ebiederm@xmission.com>
CC: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/9] irq-remove: core
References: <20071019075443.GA6407@havoc.gtf.org>	<20071019075508.GB6407@havoc.gtf.org>	<m1ir53gev4.fsf@ebiederm.dsl.xmission.com>	<4718F5BB.5010301@garzik.org>	<m1ir52g9zg.fsf@ebiederm.dsl.xmission.com>	<47190C80.8090400@garzik.org> <m1hckmem00.fsf@ebiederm.dsl.xmission.com>
In-Reply-To: <m1hckmem00.fsf@ebiederm.dsl.xmission.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1415
Lines: 36

Eric W. Biederman wrote:
> Jeff Garzik <jeff@garzik.org> writes:
> 
>> Eric W. Biederman wrote:
>>> Jeff Garzik <jeff@garzik.org> writes:
>>>> Do you think set_irqfunc_irq() should be called at all the callsites of
>>>> set_irq_regs(), or one the fix you mention is applied, do you think current
>>>> model is sufficient?
>>> Good question.  At first glance I think the call sites are ok, that
>>> is where we have the information now.  Non-genirq architectures needs
>>> work of course.
>>>
>>> However given the weird poll case etc that either we need to take this
>>> slow and delay this change until all of the drivers are fixed up, to
>>> not need an irq parameter (as you suggested).  Or that we need to allow both
>>> forms of irq handler to coexist temporarily.
>> After diving in, in the past couple of hours, I'm pretty confident we simply do
>> not need {get,set}_irqfunc_irq()
> 
> Sounds good.  That was my impression when I was looking at this kind of stuff.
> 
> Just so long as this doesn't slow us down so much we don't actually drop the
> ball on this.

Hey I'm the one who has kept the ball rolling since the day pt_regs were 
removed...  :)

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/