Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Antoine Tenart <atenart@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: [PATCH net 1/3] net: mscc: ocelot: don't report that RX timestamping is enabled by default
Date:   Mon, 26 Jun 2023 18:40:01 +0300
Message-Id: <20230626154003.3153076-2-vladimir.oltean@nxp.com>
In-Reply-To: <20230626154003.3153076-1-vladimir.oltean@nxp.com>
References: <20230626154003.3153076-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zo9b7Cnljw2H6IUmF49DQaNjnbkx1ffbvmK8/8xBNbUvUz1EKvmcu8TmDGL7?=
 =?us-ascii?Q?OFXtk21Oe9PR5lxv6DSe8jjJPUClNeEvzd2bMyMrOoOo8SXCbsy6j8JorgI2?=
 =?us-ascii?Q?DK3XsJMdI43lk8ZURI1QEjyihpvV4L8/C29IBE9otXehgv5NVU6V02IltGAs?=
 =?us-ascii?Q?sHig6bwzGu02W33EFk9wQZCs5o6g8JANQx84QTnApFAe8PZZ4hDpgjkho5rS?=
 =?us-ascii?Q?Bv4i5VoQdxHB6TDkS+29QaE2qbJiTGfJShekqNlAy4N1y/EqdEL0n8FmObmu?=
 =?us-ascii?Q?emxREYrTGHHYzZmX7IMiIRxYZAbdxO7ADV38vfA8xACehweBDtdAIZHk2A7W?=
 =?us-ascii?Q?dyUrMx75Q/4iSJ0r8JTAKh1iO5UCj7t75Qr1Fex4Wt8tE2GqkBwgu9k69cd8?=
 =?us-ascii?Q?E7lKu+XlInGAZaDNMnnRtWDQrGRd28sPeO+LGUmK7CHpM0+cGK4Ndl/35+9G?=
 =?us-ascii?Q?nmsoaQHAnaK4hfo1UDJVTEvR32KAAwVoOglnv6yG0FtVNOT5KKaGJjAOKuoX?=
 =?us-ascii?Q?C5pViFwR1LEtuXy0pWR/aZ0sWmQMjzYQGFROb47RzwT8Ssbf8BQYH4zpLGxM?=
 =?us-ascii?Q?StjZjJt097UwtUJsgBBOhhj3BB3P+59wriOOMBwckWtIzWznQTd5h7YIOan9?=
 =?us-ascii?Q?xqBtuL0iRJr0CnhbP/PX79qeReTIcTaNM8WtPVtAKlA1AZaRbib7BG2gGofm?=
 =?us-ascii?Q?QKGlQy5QI9buLBO8ayThelzDCuqmBHJ6cg/XK9Dmt81z0HwwL84T6GOKtMXo?=
 =?us-ascii?Q?MRRhMu6hrCw5sKhx5fyo9xG+z/pHv569wVRusa9z01ejfezNBVVOq8AWb80b?=
 =?us-ascii?Q?mUHv+83loVr5VcKMrwpL75tYuqDfNnM9qN8XTcgjXK2Rt9A0oQdZLns67xYK?=
 =?us-ascii?Q?E4DAwNgpscGbFBokMh8/Rzem013jpm9J3mAO7zB6QVXtU3OAfPN2W1CVAqT9?=
 =?us-ascii?Q?ajBotxFuTt3gSjB0j6nKXgJxUpBjW8eQJkGFb284B17t6ia8iNRYFGmGoJr5?=
 =?us-ascii?Q?uZvIvrcvjkDtwqi03GlgJUg/niyr9m/Kw+wvidAdboB4mxWQuBCIpYeId+yU?=
 =?us-ascii?Q?alEOATIobMwO14aa82sX9iDu+P5IFxVrqLSHcmOiCdvT3wzS/3ekA4aNBXGZ?=
 =?us-ascii?Q?Z4mh4OC062MkRSYMyNcuKKuAYoPZAoabJHp1edNhTfE7s3JkKfJv1tnqYmDT?=
 =?us-ascii?Q?h0qobMU8f0imzkWwTqwENdEYtHcm+P7PzBqj4N+UxzGtE3EoWe2AtyLMIZfU?=
 =?us-ascii?Q?pWLKBsfV4yWTLcEJyFA96Ry/F1Gc4gFVmDL6Ly1AoYM8jUDfryiKn1n2WybA?=
 =?us-ascii?Q?7zNwtv8uTGp7iDIdbtBlGxSmEjCcUlUdrNage53iizK36y6UsBXB82KgBmyp?=
 =?us-ascii?Q?xaJ42mmwuMpv1gHOxvY/js62xQCcJvdyr1KFSYqKPosuDg0i08T25UPQjitY?=
 =?us-ascii?Q?Xlk0yXJLj/BYc7McpyVX/caScK2QORzDZds7rW2xS2KNgvXCMQHBxdAz4u0A?=
 =?us-ascii?Q?S1k++AW59vs9QqYy0UihPidQL2L7/VIGgJ6iZfSC2x/w4im/WZUNzvXMXlBA?=
 =?us-ascii?Q?0O589qzd1YoQGpva4jMFQIZ8EUmD9aMkf2BVHaC8vagMT293jNoX3gqVaaQK?=
 =?us-ascii?Q?Aw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: da21f5e2-f627-4ed8-9ec7-08db765ba63d
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2023 15:40:20.8071
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4Ov+PJz8nhHEUyUqGCUyED4+vTXQKXqQoA/mijUeXCPbnHdrRWXy2fQbw/U/uzgLkx3mgoeR3gJQ7JM8G+9Fxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8638
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

PTP RX timestamping should be enabled when the user requests it, not by
default. If it is enabled by default, it can be problematic when the
ocelot driver is a DSA master, and it sidesteps what DSA tries to avoid
through __dsa_master_hwtstamp_validate().

Additionally, after the change which made ocelot trap PTP packets only
to the CPU at ocelot_hwtstamp_set() time, it is no longer even true that
RX timestamping is enabled by default, because until ocelot_hwtstamp_set()
is called, the PTP traps are actually not set up. So the rx_filter field
of ocelot->hwtstamp_config reflects an incorrect reality.

Fixes: 96ca08c05838 ("net: mscc: ocelot: set up traps for PTP packets")
Fixes: 4e3b0468e6d7 ("net: mscc: PTP Hardware Clock (PHC) support")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/mscc/ocelot_ptp.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/ethernet/mscc/ocelot_ptp.c b/drivers/net/ethernet/mscc/ocelot_ptp.c
index 2180ae94c744..673bfd70867a 100644
--- a/drivers/net/ethernet/mscc/ocelot_ptp.c
+++ b/drivers/net/ethernet/mscc/ocelot_ptp.c
@@ -824,11 +824,6 @@ int ocelot_init_timestamp(struct ocelot *ocelot,
 
 	ocelot_write(ocelot, PTP_CFG_MISC_PTP_EN, PTP_CFG_MISC);
 
-	/* There is no device reconfiguration, PTP Rx stamping is always
-	 * enabled.
-	 */
-	ocelot->hwtstamp_config.rx_filter = HWTSTAMP_FILTER_PTP_V2_EVENT;
-
 	return 0;
 }
 EXPORT_SYMBOL(ocelot_init_timestamp);
-- 
2.34.1