Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Jun 2023 16:42:26 +0100
From:   Lee Jones <lee@kernel.org>
To:     Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc:     pavel@ucw.cz, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 5/5] leds: Add a multicolor LED driver to group
 monochromatic LEDs
Message-ID: <20230626154226.GE10378@google.com>
References: <20230616095746.872220-1-jjhiblot@traphandler.com>
 <20230616095746.872220-6-jjhiblot@traphandler.com>
 <20230621193321.GU10378@google.com>
 <e9d23080-3916-f8ff-e179-4572d02c57b0@traphandler.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e9d23080-3916-f8ff-e179-4572d02c57b0@traphandler.com>
Precedence: bulk

On Thu, 22 Jun 2023, Jean-Jacques Hiblot wrote:

> 
> 
> On 21/06/2023 21:33, Lee Jones wrote:
> > On Fri, 16 Jun 2023, Jean-Jacques Hiblot wrote:
> > 
> > >   create mode 100644 drivers/leds/rgb/leds-group-multicolor.c
> > 
> > Sorry to do this too you, but there are too many nits that I can't pass by.
> That's alright. I'll fix them in the next (hopefully last) round
> > 
> > > +		/* Restore sysfs access when the multicolor LED is released */
> > 
> 
> > Out of interest, why are we doing this?
> To prevent the user to play with the individual LEDs of the group, their
> sysfs interface is disabled (read-only). The interface must be re-enabled
> when the group is destroyed.

Please make that very clear in the code.

-- 
Lee Jones [李琼斯]