Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Jun 2023 13:23:07 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     ankita@nvidia.com, aniketa@nvidia.com, cjia@nvidia.com,
        kwankhede@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com,
        acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com,
        danw@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/1] vfio/nvgpu: Add vfio pci variant module for grace
 hopper
Message-ID: <ZJm7a1BpeLmQQ5Mj@nvidia.com>
References: <20230622030720.19652-1-ankita@nvidia.com>
 <ZJWdbbNESp1+6GVN@nvidia.com>
 <20230626100629.3c318922.alex.williamson@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230626100629.3c318922.alex.williamson@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vrHCWhM+9ZxIplgL2we/T6vnvSPwNxjRXbgcbhAtrqQEBj3KqfiWhy9VfHpW?=
 =?us-ascii?Q?zsjO6k+4jGovT6P244D8cZH+32Or3C6+8QqbTxwwexoRTfycHfj4nKgcatlp?=
 =?us-ascii?Q?XIhkVCjhKvyVz6LrSveBdwEVV6gxdTJaEsttFqey5cx3Y1BbLwcOE3JphbfO?=
 =?us-ascii?Q?hCaiBHyHjjtXhkOeqEOrQ2VaEdXViOjWn5aoiKeibLy2efgecpgDKd7MSPYd?=
 =?us-ascii?Q?8ro/+pyeJFC1AFxiuDCyZXclXKkU9cM8jN1ab6f6L2n0bETSoh9HmlhhrLi2?=
 =?us-ascii?Q?OxkL8fHEPZPcSguFTOBVh6hqRaC8maJGQ0xGFzNI4rgDS9i2cB2gUM0sGdV5?=
 =?us-ascii?Q?LJ3Gmj9+M3mNBr2smQm6BTCBm7r8+Jy3SAOHN/Gcb2QJhkrPBzl7tdmAdsgL?=
 =?us-ascii?Q?Qd76GpcZXPDZ3AyuZYREecndWtjCavuefB2QeCAP9b7+kikk/lQFcwsU3I0u?=
 =?us-ascii?Q?TbQDkCdr6Pq6uo9PwseGZj6OlTIPfd/13kgt8t2/2dtBrWtRcsAKAbezHitP?=
 =?us-ascii?Q?emFC5HJDhmfl5jkkP0RqojeF1wtq1fjvjpQ8szWKqx7rYFBJhE/Ku9O/1yyc?=
 =?us-ascii?Q?UKYfU8/jwbddo1QAN769+AmYJ1mKWP951K9DuhS6OkXd4xKfpGed1NH2/HjO?=
 =?us-ascii?Q?bKItTAe15AisT0sKe1P2O6NMqiaRGNgjk077Vf6o4RC8DegeyyyX3PEV5NrB?=
 =?us-ascii?Q?lm6+HwvlHD4hWRJKcdkyFpp0T1sXBjPy04kkAVw0/C8DDspPZCvCY5DVHQQG?=
 =?us-ascii?Q?yLlfGiFvtdOGSi3Sw6E5oXF9L64WF9lsu9mUpUr2eybe8rbCpkA3TEZ8Uann?=
 =?us-ascii?Q?YNBeBAXf82Q0kUPI59nHHoH4O9Z1e621v8y9PeA0VEw1wH749jnzOm7MZg+g?=
 =?us-ascii?Q?TZn70AIc/a6TEhLamLSbz/1hvAU3Cmz1bYhP4lrXgODWxNP0xcYrowg7/lk3?=
 =?us-ascii?Q?6Dydlza+EHGpkHv88U4RPyhRtzORu52yuDJO+ghLsshn75me8h4uT7yaic8X?=
 =?us-ascii?Q?ULvf5UJQkMfUxTgQGFDee/UztJq332fMmG6VHzyaXcq38T4+RgrRoI0Shxs6?=
 =?us-ascii?Q?b6J52o3jTvGH1bSXf4xoSecqX+a+tELBZOsQMBLPzb0z1cAQvC2TB06pRBHj?=
 =?us-ascii?Q?EFpuuE2sNNgs2aWyMtUGyZg/Uoin0Tktv0YW55kxiIcB7UtTfpdFUWGmiotZ?=
 =?us-ascii?Q?Qn8h6MEnnXgT+xLUhBAeE66h9gvlEnzhIIDp6ZpmLo4O0buyL+fE5cDe4xZO?=
 =?us-ascii?Q?LiB7OPuQvvbXgDh4xk6q1iHefyTJ7GwbRmHM2EFvSiVJEWYuhF1e7jd2cHH3?=
 =?us-ascii?Q?5GWYLJa4s1wyKtIPiVXkZMbGLogcMHXIj2hVNUbyEvrGjvIkPDhqH4mBNSaz?=
 =?us-ascii?Q?rWQyFQ0p1jOPcG9H4QWgiWW2ecwDZZ9FZDdiAjYLVga/aR/6DB8rpkGERL32?=
 =?us-ascii?Q?8iNbA/YAqEJau+f0u5zctm4Ls0Y+83eqY/F/hvI6t3capz4zo9yUrkNyRRA4?=
 =?us-ascii?Q?7Z5A+FIr6xFpLJLPZc56knkt7eTEtD3Eb9sjyw2+6xD8Q1jL4xazhsHvzxM2?=
 =?us-ascii?Q?owIDYgcr/dbOibGTiUjiUade0jxh+UGXwPV3RolD?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c60d3d96-6572-49c8-9de9-08db7661a11c
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2023 16:23:09.1590
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T7iPeZ9bh+fXdEKXIOvxHNbFv8p4qgSX2E2r1cF+TuVQbHs8Nk4lEsS7cUypeBnO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6749
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 26, 2023 at 10:06:29AM -0600, Alex Williamson wrote:
> On Fri, 23 Jun 2023 10:26:05 -0300
> Jason Gunthorpe <jgg@nvidia.com> wrote:
> 
> > On Wed, Jun 21, 2023 at 08:07:20PM -0700, ankita@nvidia.com wrote:
> > > +			if (caps.size) {
> > > +				info.flags |= VFIO_REGION_INFO_FLAG_CAPS;
> > > +				if (info.argsz < sizeof(info) + caps.size) {
> > > +					info.argsz = sizeof(info) + caps.size;
> > > +					info.cap_offset = 0;  
> > 
> > Shouldn't this be an error if we can't fit the caps into the response?
> > Silently discarding the caps seems wrong..
> 
> It's required for backwards compatibility.  If a userspace doesn't
> support the info ioctl capabilities chain, it gets the basic
> information successfully, while an enlightened userspace makes use of
> the flags to know that a capability chain is available but unreported
> due to an insufficient buffer size, with the required size being
> provided in the return structure.

Hum, maybe this part should be pushed into the cap helpers..

Jason