Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Jun 2023 17:37:44 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Matti Vaittinen <mazziesaccount@gmail.com>
Cc:     Benjamin Bara <bbara93@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        support.opensource@diasemi.com,
        DLG-Adam.Ward.opensource@dm.renesas.com,
        Martin Fuzzey <martin.fuzzey@flowbird.group>,
        linux-kernel@vger.kernel.org,
        Benjamin Bara <benjamin.bara@skidata.com>
Subject: Re: [PATCH RFC v4 02/13] regulator: add getter for active monitors
Message-ID: <c7ba005c-27ca-4787-a3ba-eda0fb91b584@sirena.org.uk>
References: <20230419-dynamic-vmon-v4-0-4d3734e62ada@skidata.com>
 <20230419-dynamic-vmon-v4-2-4d3734e62ada@skidata.com>
 <4a71b08e-0c0d-a378-7a3a-0cd12912d4d4@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="FJtQkIrtI0wk0GDO"
Content-Disposition: inline
In-Reply-To: <4a71b08e-0c0d-a378-7a3a-0cd12912d4d4@gmail.com>
Precedence: bulk


--FJtQkIrtI0wk0GDO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jun 26, 2023 at 04:43:49PM +0300, Matti Vaittinen wrote:
> On 6/20/23 23:02, Benjamin Bara wrote:

> > + * @get_active_protections: Get all enabled monitors of a regulator. OR'ed val
> > + *	of REGULATOR_MONITOR_*.

> I think it wouldn't hurt to have doc stating in which case populating this
> call-back is needed? I haven't read rest of the patches yet but I guess this
> callback is going to be used internally by the regulator core and maybe it
> is not obvious for driver author that this is needed by core to be able to
> support automatic protection handling.

I think this is true for pretty much all callbacks - broadly it's just
the case that if the hardware has a feature the best practice is that
the driver should implement all relevant operations.

--FJtQkIrtI0wk0GDO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSZvtcACgkQJNaLcl1U
h9Cm/AgAgGrZhSisrmIkumW02U2K/+3GY8d4MiLn9Vs+TBgpb86N2KdXP7bjQiSl
gCbI3644D7vHr4A2X5P9DB2YmyylAi4Abfu8rI5yc5ACoOqCopXgIxY1pHnxGf80
EypnD3YbaQjMfNuzReQ0GOH0CuOCFD+zKlpxDK2VnElqoHLPwNfiOT3Okmm5PsIv
05ocg6ncP418swTGaQ4xTYICaOqChb1HQb4hJpJjLw85xvvkepVBuuap9k6Apkew
RFo/twdelPpxEsBZRy3BAQO6oe/XEObkfm/pG1ehYpLfJFSErtrVDdiihkfaaAoY
L3rsaP8n8Vrd3tIgecP6hC6oJM64Jg==
=gRrb
-----END PGP SIGNATURE-----

--FJtQkIrtI0wk0GDO--