Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0a611696cbc63a3a9b99a7966b8fe4f7e20a014b.camel@linux.intel.com>
Subject: Re: [PATCH v2] sched/task_group: Re-layout structure to reduce
 false sharing
From:   Tim Chen <tim.c.chen@linux.intel.com>
To:     Chen Yu <yu.c.chen@intel.com>, Aaron Lu <aaron.lu@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>
Cc:     Deng Pan <pan.deng@intel.com>, tim.c.chen@intel.com,
        linux-kernel@vger.kernel.org, tianyou.li@intel.com,
        yu.ma@intel.com, lipeng.zhu@intel.com
Date:   Mon, 26 Jun 2023 10:09:10 -0700
In-Reply-To: <ZJlDsbyNmcKtweg4@chenyu5-mobl2.ccr.corp.intel.com>
References: <20230621081425.420607-1-pan.deng@intel.com>
         <20230626054756.GA435374@ziqianlu-dell>
         <ZJlDsbyNmcKtweg4@chenyu5-mobl2.ccr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-06-26 at 15:52 +0800, Chen Yu wrote:
>=20
> =20
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index ec7b3e0a2b20..067f1310bad2 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -1958,8 +1958,10 @@ static inline void set_task_rq(struct task_struct =
*p, unsigned int cpu)
>  #endif
> =20
>  #ifdef CONFIG_RT_GROUP_SCHED
> -	p->rt.rt_rq  =3D tg->rt_rq[cpu];
> -	p->rt.parent =3D tg->rt_se[cpu];
> +	if (p->sched_class =3D &rt_sched_class) {
> +		p->rt.rt_rq  =3D tg->rt_rq[cpu];
> +		p->rt.parent =3D tg->rt_se[cpu];
> +	}

If we avoid the assignment for non-rt task, do you see it further improves
c2c bounce?

Tim