Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Jun 2023 20:47:27 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Xu Yilun <yilun.xu@intel.com>
Cc:     Russ Weight <russell.h.weight@intel.com>,
        gregkh@linuxfoundation.org, rafael@kernel.org,
        linux-kernel@vger.kernel.org, matthew.gerlach@linux.intel.com,
        Jim Wylder <jwylder@google.com>
Subject: Re: [PATCH 1/1] regmap: spi-avmm: Fix regmap_bus max_raw_write
Message-ID: <c5c95368-eac3-4250-b50a-50f0a526b753@sirena.org.uk>
References: <20230620202824.380313-1-russell.h.weight@intel.com>
 <ZJfB9zXhizbqmIrm@yilunxu-OptiPlex-7050>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="P8hXnjv+/0ZjnrEV"
Content-Disposition: inline
In-Reply-To: <ZJfB9zXhizbqmIrm@yilunxu-OptiPlex-7050>
Precedence: bulk


--P8hXnjv+/0ZjnrEV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 25, 2023 at 12:26:31PM +0800, Xu Yilun wrote:

> IIUC, max_raw_write/read is the max batch *DATA* size that could be
> handled by the receiver. reg addr bytes are not counted in. I'm not 100%
> sure this is obeyed by all drivers. But see several examples:

There's clearly been some confusion in a bunch of drivers, those you've
identified below need fixing too for the new code from the looks of it. =20
I'm frankly unclear why some of the drivers you're pointing at are even
implementing raw buses.

> So I'm not sure if commit 3981514180c9 is actually necessary.

That's "regmap: Account for register length when chunking".  It's
certainly a bit unclear now I go do another survey, though it's also
clear that things like the handling of padding are intermittent at best.
We probably would be safe reverting that.

Jim, where were you seeing the issue here?

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

--P8hXnjv+/0ZjnrEV
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSZ608ACgkQJNaLcl1U
h9CabQf/dmaoHTZhgC/HEHvIbuhbEgHXv0xNgEDS2rQMVc8m2qZ1wyd9Wty+2Fvm
cBMXARYF/ZCDL16ehPBpn8qwSTV9KGNVT/y2ws7YksTo6tkK+8oeh6Lh/c7B0jfy
h9wZaE1UkgGhbgNGfDkC/O0BvicnbKuCoRYahe8qstssXFj2Tcb4COJQt0Cc13Ja
DPc3BavyZdcDFxxYVVzemqWYg2SueU75zGzxv5/YkNm8yudxwYjZLw0kYfLkeYrw
m0cyyaObCfRkS2W2qDsAcyJU62Ke3BUQ3zXlrozuzxVQVq4b+4K+HbqURDhZbPZr
zGr2J9VFdJ9ugDsNpmR5FgvXqKxKFQ==
=9YEL
-----END PGP SIGNATURE-----

--P8hXnjv+/0ZjnrEV--