Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp16654641rwd; Mon, 26 Jun 2023 13:08:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ720HlEAjZIv/EMVk4XdmxD5BLp9L0EOpZ4miHSKYVJ0ga9lgESPQYRo6sCmj4ZVdi7oHST X-Received: by 2002:a05:6a00:139f:b0:676:4c90:ca60 with SMTP id t31-20020a056a00139f00b006764c90ca60mr3561309pfg.7.1687810126260; Mon, 26 Jun 2023 13:08:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687810126; cv=none; d=google.com; s=arc-20160816; b=NBLHlbFx/i0KlqCjF+jw5rSjvHrBYQe6QeNWnPPLpbsKyxx0JgnDeRWLfU1SGSvzNy CKPgfBes5Vis9NhewF2bpv7KD+Qm2d4GqUcHAil1vCL5F9sXSN0YR3jvep4rO706YWaw SrKpZ54TAhjgFLF7/Wnv8z4ThpqKgGhAXCXWBSptd1+593svO/e7ihF10cMiqC+JJIdG 5Nxy2lpLSE7DTjjV/BAFjg5U1O/uR05a4DN8XvcGncURQQzhmwZeRJjstC3juUI6qt88 KEIgQ/tXH+aoLxYNHj6eefJhCUf88gzAsmOIl5gkmqPLd3rtZuqq9AS+gPAfpWMXmvna FZ0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=79QHg/QgavPCVxQ9hEm1/ZwwVEae27GZeh85l7f/7yM=; fh=LABZ9m6L9i2uKMPsI25WmFsfUG89iYFz8OI5E05WdgI=; b=yv10Yx34fDhebrRUIuC4uad19DkXWGOH/IA2/pKMzSoaZUjI3MUiL/SawxQZ4tXNSQ SQDHx+f0jPcc/SIIq0Val7j+D3J3jlcLuwKwyEifhfWMzzLZJqYxgjhAYKRlcAOMua+G anBchp+xNR4fKZ3SR/Yk2DAMewN+Qr9hjlLzzpOievZUiKPwfyEYUaXasKLddEicwKOa XR0dHFFyv2ydlus7U9sQlxogPmiMVY1tk5/ClkVei3DW0Qzk9ERmMfn6vsBXORsz4dw5 vh+19mAtix6mBnEh1kymtg2P4/6OjSPEtAPZvNKDAHB8SfRtEZ4KGZ377Vnsyg1f1san kHQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u697IQCt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a36-20020a056a001d2400b0066669c4e9e9si5360852pfx.143.2023.06.26.13.08.34; Mon, 26 Jun 2023 13:08:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=u697IQCt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229692AbjFZT6X (ORCPT + 99 others); Mon, 26 Jun 2023 15:58:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbjFZT6W (ORCPT ); Mon, 26 Jun 2023 15:58:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D17DFE7B; Mon, 26 Jun 2023 12:58:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6036C60F52; Mon, 26 Jun 2023 19:58:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2CE4C433C8; Mon, 26 Jun 2023 19:58:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687809500; bh=ldB+MatWlVsNCLZ0mR+Yj//TS0gmW2dKp23REUfd6MU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=u697IQCtWc7mPfP5qNsMU2uWqPdgmV1hJ9wSJ61mq7qWHcO0fSuOP1QJw+GQeHeJH yz3fVEY9D+3Y2y0raE7vu687ZMFBltGJd3Hbyz5/t59QlAG5BYc6OUe21J6p2bNMVf OFGKjOGg70AKDzOnVr+EfgC/iuPcBNc0vy+l4Bv2s2efBnkJHfTS8DYof2UJupzYOc FS4iuCYuKTQ+vdUlmXxHzPYvwMhsLdhSlxZx2f6bZWgp4nNp2LWcKxhCIuuJAQb1oC e1bDUJvq8rLTipdMQC6SN1Xtd48ku1uo9jnnBTMDyzo9BLxP76wRPO06DnbgNaGR/F w1PG4+jOG5OGw== Date: Mon, 26 Jun 2023 12:58:18 -0700 From: Jakub Kicinski To: Abel Wu Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , David Ahern , Yosry Ahmed , "Matthew Wilcox (Oracle)" , Yu Zhao , Kuniyuki Iwashima , Alexei Starovoitov , Martin KaFai Lau , Alexander Mikhalitsyn , Breno Leitao , David Howells , Jason Xing , Xin Long , Michal Hocko , linux-kernel@vger.kernel.org (open list), netdev@vger.kernel.org (open list:NETWORKING [GENERAL]), cgroups@vger.kernel.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)), linux-mm@kvack.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)) Subject: Re: [PATCH net-next 1/2] net-memcg: Scopify the indicators of sockmem pressure Message-ID: <20230626125818.74193aea@kernel.org> In-Reply-To: <20230625142820.47185-1-wuyun.abel@bytedance.com> References: <20230625142820.47185-1-wuyun.abel@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 25 Jun 2023 22:28:10 +0800 Abel Wu wrote: > Now there are two indicators of socket memory pressure sit inside > struct mem_cgroup, socket_pressure and tcpmem_pressure. > > When in legacy mode aka. cgroupv1, the socket memory is charged > into a separate counter memcg->tcpmem rather than ->memory, so > the reclaim pressure of the memcg has nothing to do with socket's > pressure at all. While for default mode, the ->tcpmem is simply > not used. > > So {socket,tcpmem}_pressure are only used in default/legacy mode > respectively. This patch fixes the pieces of code that make mixed > use of both. The merge window for 6.5 has now started, let's defer this until 6.6. Please repost in ~2 weeks. -- pw-bot: defer