Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 26 Jun 2023 13:43:13 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Sumitra Sharma <sumitraartsy@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        <bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     Ira Weiny <ira.weiny@intel.com>, Fabio <fmdefrancesco@gmail.com>,
        "Deepak R Varma" <drv@mailo.com>,
        Sumitra Sharma <sumitraartsy@gmail.com>
Subject: Re: [PATCH v4] lib/test_bpf: Call page_address() on page acquired
 with GFP_KERNEL flag
Message-ID: <6499f861360a1_7517929481@iweiny-mobl.notmuch>
References: <20230623151644.GA434468@sumitra.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230623151644.GA434468@sumitra.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WZ7Nfr7sADaAdVCM9RSBwx1awbdqPCPX2Xn0NIdiDZW7HvEKqHoQbWtolccq?=
 =?us-ascii?Q?Rrtlik3vMb/D8m76QezQzMMG83JjqZPclf12dYKZlbOxqK7b2JWZNuqVfm/O?=
 =?us-ascii?Q?qZFccDWd/WQNWcHdpsHRjzleML/VFuRipzuIM7n+WxnaFHBsJbfiHGPnAwv1?=
 =?us-ascii?Q?rBdOvvabx/xnknUBO/EPZ3fzaYYmOPWnSlH2azuh6aYZpGS5PSFee2gy3mMi?=
 =?us-ascii?Q?8iV8z3JBnjZhc8DJYlmVNBA8jSP1rMSMkbyhIHHruwI1/9D5zR+aOBWcyEfE?=
 =?us-ascii?Q?sSUhCigTHm66TlXfOdLbEV78EbJ3tITEI+PlcI6CT6PcTyzsDA9cPd7Zn+6X?=
 =?us-ascii?Q?u3ujVF4K7R+z6qFZaaL90B/zi7IpvHd0ewKJGvarSqmLz0oN3lJ+kT6K6FUA?=
 =?us-ascii?Q?Ti08a3MDEWjs6YhCDMqcchkTieKbhCCsuJG6/fSilyBcu3W3Q58M/Sj/qKZo?=
 =?us-ascii?Q?mnMWqm+oMWuBBw7UjVyFcKo+yInOoKHQcLfgcubZm7jhyREQzu7qKqUv7drz?=
 =?us-ascii?Q?IphBkHZFNRyTR6Ti4yNUGaqIqaqMRM8KHvNgKW2hxAULIQ9JVKIP+8whxwLr?=
 =?us-ascii?Q?MqQY6wgpv6DMd3dfOZMMQixaP3T7wQNZ25LM6Qo2cbe4fQsRkC3qoOiiQXp1?=
 =?us-ascii?Q?8qmEcJZELHA1CqbFbcLP7BA46/uiNlumYr5sE1JtKSJctQEkOOlZtHB72coA?=
 =?us-ascii?Q?2LEoS06sFZhwnWTcnyTsq2KYd78V5iR8NCJ1Asmg7OYXteG34uPkb3/adIhJ?=
 =?us-ascii?Q?f+MmbxtnAgvGZVNSFlaIUJx5+FLmgZ+8n0GVX5I/5RoPub2rG+A/qKl9q4OL?=
 =?us-ascii?Q?A0JtumKLGEHNxEvS2XxojJHyTDfLpqZDdA3T7WlFus/5h63jwRkz2jIXEzFQ?=
 =?us-ascii?Q?0kWJOLjPrBKGQzn7nC5nHKIgYXHL2zojZtxczUPkbZkB0qJ5djlo+vAzw7Xm?=
 =?us-ascii?Q?IuBjjNy5oTBccVBVu5MAQ9IsXTqXlly7b/HCez+4UJWSfW5Hl87PFTAwI7Hk?=
 =?us-ascii?Q?gXCGEiAvgv/EXeglCUCG/pRjCDURD10RHkSx/NiGuQ3Hrcc7iuEMXPqT1l1L?=
 =?us-ascii?Q?asJ2GbgKopAzRK8JhopfCSdO12IVfQ+oGOzfGKgWiOaGyupMvxT50ZhzsnuZ?=
 =?us-ascii?Q?IDxYxdkfOqDFTZLYZgOyRPgWOtkiuXtygT3J2mWMRcbdvZ9ntS42jVoy+ZDK?=
 =?us-ascii?Q?kqytsZqYmExH/XFirpT1b5/n92oeiU1lccot4BVpnSAd3bm8xxONLtkMHuld?=
 =?us-ascii?Q?4OdkInDkCiCdlfqodviXLmXIySPVkgls4i5S3z5AJffffCX7GlqPwq+1YG63?=
 =?us-ascii?Q?jlSoOFA5bkTIxoZ92AI7LjGUWqED2ezroPA8Qs2KZwRwtHWmQdGVcrVqKjsn?=
 =?us-ascii?Q?mf1YGgfPSmc9h493gAHgqGCIqctCsI2LIzBypGK5rPmFUpOZsviMDnZJGF0n?=
 =?us-ascii?Q?jFgRcHonKqUJDxvVwBUpVa2Ewf0fnvUD6xPBO09imS9swTLYwizMA0C7N9RI?=
 =?us-ascii?Q?dcl7ueOAOFL+D3IXMW+oBqyRDmO3nhG646ohySK5U+47PfBUYYMAedoNvwNv?=
 =?us-ascii?Q?vMvZkhW37/vlGyTDtVjdT8UwOu0bhbT5bdqTDTo9?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ed4b3a8-aba7-4a5c-d86d-08db7685fa08
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2023 20:43:20.3840
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZgXxtS9z1wa4gwAazwAxA9F3HR1o1jZxp8TVSFap1dfea6i0LO/azVq/wzzWZGSew3oigzkOWvbOqAX8/HLyTA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5016
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sumitra Sharma wrote:
> generate_test_data() acquires a page with alloc_page(GFP_KERNEL).
> The GFP_KERNEL is typical for kernel-internal allocations.
> The caller requires ZONE_NORMAL or a lower zone for direct access.
> 
> Therefore the page cannot come from ZONE_HIGHMEM. Thus there's
> no need to map it with kmap().
> 
> Also, the kmap() is being deprecated in favor of kmap_local_page() [1].
> 
> Hence, use a plain page_address() directly.
> 
> Since the page passed to the page_address() is not from the highmem
> zone, the page_address() function will always return a valid kernel
> virtual address and will not return NULL. Hence, remove the check
> 'if (!ptr)'.
> 
> Remove the unused variable 'ptr' and label 'err_free_page'.
> 
> [1]: https://lore.kernel.org/all/20220813220034.806698-1-ira.weiny@intel.com/
> 
> Suggested-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> Signed-off-by: Sumitra Sharma <sumitraartsy@gmail.com>

Just saw the report from kernel bot...

Better on this version than I saw before!  :-D

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
> 
> - Link to v1: https://lore.kernel.org/bpf/20230613073020.GA359792@sumitra.com/T/
> - Link to v2: https://lore.kernel.org/all/20230613071756.GA359746@sumitra.com/
> - Link to v3: https://lore.kernel.org/all/20230622080729.GA426913@sumitra.com/
> 
> Changes in v4:
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202306230559.hU5Aonpl-lkp@intel.com/
> 	- Remove unused label 'err_free_page'.
> 
> Changes in v3:
> Noted by: Fabio M. De Francesco<fmdefrancesco@gmail.com>
> 	- Remove the check 'if (!ptr)'.
> 	- Remove the unused variable 'ptr'.
> 	- Change the commit message.
> 
> Changes in v2:
> Noted by: Fabio M. De Francesco<fmdefrancesco@gmail.com>
> 	- Remove the kmap() call and call page_address() instead.
> 	- Change the commit subject and message.
> 
>  lib/test_bpf.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> diff --git a/lib/test_bpf.c b/lib/test_bpf.c
> index ade9ac672adb..a5cc5f9fc4e8 100644
> --- a/lib/test_bpf.c
> +++ b/lib/test_bpf.c
> @@ -14381,25 +14381,17 @@ static void *generate_test_data(struct bpf_test *test, int sub)
>  		 * single fragment to the skb, filled with
>  		 * test->frag_data.
>  		 */
> -		void *ptr;
> -
>  		page = alloc_page(GFP_KERNEL);
>  
>  		if (!page)
>  			goto err_kfree_skb;
>  
> -		ptr = kmap(page);
> -		if (!ptr)
> -			goto err_free_page;
> -		memcpy(ptr, test->frag_data, MAX_DATA);
> -		kunmap(page);
> +		memcpy(page_address(page), test->frag_data, MAX_DATA);
>  		skb_add_rx_frag(skb, 0, page, 0, MAX_DATA, MAX_DATA);
>  	}
>  
>  	return skb;
>  
> -err_free_page:
> -	__free_page(page);
>  err_kfree_skb:
>  	kfree_skb(skb);
>  	return NULL;
> -- 
> 2.25.1
>