Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp16753556rwd; Mon, 26 Jun 2023 14:50:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6N7wYk+5lvzYZ9SwZ8MDmekOUKoGdXMAk0FdtYL0BHUkD68GTFn5LBZRrBYfTawX2z6xHU X-Received: by 2002:a2e:9dc4:0:b0:2b6:9ed2:f61c with SMTP id x4-20020a2e9dc4000000b002b69ed2f61cmr2842526ljj.7.1687816228898; Mon, 26 Jun 2023 14:50:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687816228; cv=none; d=google.com; s=arc-20160816; b=ZUI0409zdR8io8N5j4ioiRuftAvREx22B1lQdWcdk+eEXDHJv2kHPtVMXeV225IUoV sJSr4D5vktpbMHUWCBvfKCQW1NfG+anTU3LNW8dOZVGGk3YyZhlYr8D1FKxPnWHvSpUO Jxe3yM6FYRagl6hgdZef8nPgMpLRpcttXxdGBoIcivqdpSIbazZQA4L+HnhRAM3Zks7N KI/4Oe2BqRSs7CvtlltYM0YeT2Z5t8hWpDh9QQz2ihDygA5G/azT3SVyRsYlIkegfnY3 FA6N7teOQh3mbSk8IO9HAUCCi3f0VGFCJx0IFnCNCeeS9jSy1akWU8DikybGT5DWgley M4+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=Su68VIu+dg/n5c1KBGJpzO46FLlcIaMW5gQxLAU91pk=; fh=LxlIizSmpLKLr6tg7ga3M/DWYZiAPKcx+OmFqSr+LKU=; b=F6iprE9T2v/AOvsU6R/lyUjl3QprBmzN57VTlHL+fbp9Pij9ke/Ja/ts0aSMNwwpRP MneMEbmm0quy8JswVipMPTwUj1tnas5pC3GHVcJnrCIwd62c8E7123v8SroDzFwwlWwi uw/Yv8V0Ib1lAWc7KOwZ7Ib5jlZZjmNzA7JVgz05ul2shG0vCJg4kbwg02n9YRVpGT1R vY6cFYGBh0cRr0JCD2NoXbOFer01qST8ISMzbjuNLGRtQYxP2/frxgAouBwWseuiihHf VmGO5AOGhtaLwvaUfeRRahJaS7Ayz7jaERiWU/LxRORDLUoxIAhhdYjKO90QntTQKQRR BdBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=WB9IkQad; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kt26-20020a170906aada00b0098d373fa9dcsi3161833ejb.488.2023.06.26.14.50.04; Mon, 26 Jun 2023 14:50:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=WB9IkQad; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230308AbjFZUxc (ORCPT + 99 others); Mon, 26 Jun 2023 16:53:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229898AbjFZUxa (ORCPT ); Mon, 26 Jun 2023 16:53:30 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67DA7AA for ; Mon, 26 Jun 2023 13:53:28 -0700 (PDT) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1687812805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Su68VIu+dg/n5c1KBGJpzO46FLlcIaMW5gQxLAU91pk=; b=WB9IkQadhnFGM9Raa6b3gcXSnt6H131s73t45t+2RpYUxxkxeLiPXkbw2WinGPk1aVqINZ c8LKvHLSzLJiu7ql1W0YXkjSVJ0+VMr7k5OqIHy/dBU6v1fILy6xsWdywz/6udi4SG2R+p 6lHLqUHmy5QkG2uno0BGKIBOi1UdXVJX7sqT9DHWhxbXrQHKVd8mEP4Qbrs9UOaRh1+Uw2 +KQfOknX5pOmFw1Ath3PEC1AKdftDpcj7SmK5HKZ0yoVAoaEpXh/lzDchUAZ0gq73BsZq7 XLF8wjscefS6so9QIg0/CJoFmrZn+9MZCOjv6ccKbfglPhIT4ieCA4wNOrOJQQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1687812805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Su68VIu+dg/n5c1KBGJpzO46FLlcIaMW5gQxLAU91pk=; b=JCf9HO+noemHUtdmNE8L+dNs4Zsu2tTQtKeWY6imVzJRfS95JsotbINXH8UBM2WS6B0JWr BNPuwBNhvhhBYpBg== To: Li zeming , jstultz@google.com, sboyd@kernel.org Cc: linux-kernel@vger.kernel.org, Li zeming Subject: Re: [PATCH] time: ntp: Remove unnecessary =?utf-8?B?4oCYLUVOT0RF?= =?utf-8?B?VuKAmQ==?= values from err In-Reply-To: <20230627182540.5243-1-zeming@nfschina.com> References: <20230627182540.5243-1-zeming@nfschina.com> Date: Mon, 26 Jun 2023 22:53:24 +0200 Message-ID: <875y7a54jf.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 28 2023 at 02:25, Li zeming wrote: > err is assigned first, so it does not need to initialize the > assignment. I don't know how you or the broken tool you rely upon came to that conclusion. There is clearly an error exit path which proves you wrong. Please look at your changes and compile them before posting. There are existing tools which do a better job than that. Thanks, tglx