Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp17133199rwd; Mon, 26 Jun 2023 21:38:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4gKQSIj1gW0luz8PmITEEC5SZOkZjjbsUVj2qemLqt9SNWUGR65rzkgDd54K7+CKx/arPK X-Received: by 2002:a17:906:dacb:b0:94e:e6b9:fef2 with SMTP id xi11-20020a170906dacb00b0094ee6b9fef2mr26033424ejb.67.1687840708056; Mon, 26 Jun 2023 21:38:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687840708; cv=none; d=google.com; s=arc-20160816; b=zVqqfDDJeQG4DCwFn3YejF3W/WLCc7rVyr2Idh2ZBJ1u1KiaHM466ymspyi4GrD64R IYqWu4eUgoN08KFc/wyjrrV1sV9bI3TfSmh7kZSdsPNAuTVlppidc+mtF3kPWavy/oB+ 45VPqcCFBYHdXjDyRFeo6MPz59TqQFN49dW/JDhbtW8lR6lOrG53YoR/v0t5d/c8riPS /10f6mQxjV7NOpzUEpU/8JTWGdAD3Md4JGCD8eDQLP4vel2IyI146uObBlIPYCmRVvZ6 ltIGyGRQ6/UjfNvi8f37HsGeGSiv24dwwwM/7lyR9MUFmUXn8KPsr/1FC0e3Aep+FRGo MOKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+r8p/v5s7wbLIPfSeJmQ/Jnc8OoL0+y1yUUWCSbGtuo=; fh=gGe1bAmqosunpnKx861aPvPnisbppe3AO8eAJI9yG5k=; b=mdujuSbWltnFA51NaG0/K7XVBXMdB6DriwCOwZ+55iS7oANTprGpXDLXALjJOOsn0f /lFRiN3ZR50i12/oDz3LhifgxmBHCCfwH84lETUB4XDnUAQNPPfP0tQQKcG07i5fyccl ui/CCB993pQuyCBEeNQQ0kLp8twCfAORK51FBjsaKTHR7cNX/ugzL9OK1XhMbWq0XORx 0zS6I+OLiygqnzoMzGdXkdhQ+qrFC5KxokiBQxU6VO+EUOS/vwB0yrxBdTY4tbFZ3a/C z650Z4wnli8EoUGvWae0qraj7GhFzCsTo6x0nv0xTNmp/w4uZqQTPa8rRggHGWAZNTxm XJXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=mC8i7Dn8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ke12-20020a17090798ec00b0098e47bbff3csi2497535ejc.297.2023.06.26.21.38.03; Mon, 26 Jun 2023 21:38:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=mC8i7Dn8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229751AbjF0EaZ (ORCPT + 99 others); Tue, 27 Jun 2023 00:30:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231180AbjF0EaL (ORCPT ); Tue, 27 Jun 2023 00:30:11 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 651EC97; Mon, 26 Jun 2023 21:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+r8p/v5s7wbLIPfSeJmQ/Jnc8OoL0+y1yUUWCSbGtuo=; b=mC8i7Dn84t1nQu2SXZOo0VXBPi 6GNIEqUOKZCP4LQWlB/pldb33gsvunRvnV6Ukm9rE4T4N7kH00nBcG53PLhHmcWdplIzyAUkSunGW Ovhky/bUBuI0LV5kB4QKOOFCWm2IYpOwskAcyfGSoCRwi/InTaYQQoi78xUahRsiX/QTLbhBkDWRD +iFriABvNMURanj7kUTHF7+7OCKBK45EgNAwvYnUW8S7X/O7huGFuwDjQHHw1X/QuSkqyX7FGRn3G CjI8LYX/W/t+F0d3qEELi/fOl9CMfnIb/32IbsqyZbxNI/KNTLFhaT/kqA+1S6EUmutxvxhHNZbLj 5FgZJSrQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qE0L9-00Bh4b-08; Tue, 27 Jun 2023 04:30:07 +0000 Date: Mon, 26 Jun 2023 21:30:07 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara , David Howells Subject: Re: [PATCH 07/12] writeback: Factor writeback_iter_init() out of write_cache_pages() Message-ID: References: <20230626173521.459345-1-willy@infradead.org> <20230626173521.459345-8-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230626173521.459345-8-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 26, 2023 at 06:35:16PM +0100, Matthew Wilcox (Oracle) wrote: > + for (folio = writeback_iter_init(mapping, wbc); > + folio; > + folio = writeback_get_next(mapping, wbc)) { Ok that's another way to structure it. Guess I should look over the whole series first..