Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp17189499rwd; Mon, 26 Jun 2023 22:41:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4zIJ49w5yBg3TGg4xNyXoGWldJhpQrQ8T0CjmpGrg929Z2fBJsUA0Xs5pbl7pbQLzS/x7H X-Received: by 2002:a17:902:cec4:b0:1b7:dfbd:4dd3 with SMTP id d4-20020a170902cec400b001b7dfbd4dd3mr11883382plg.9.1687844513555; Mon, 26 Jun 2023 22:41:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687844513; cv=none; d=google.com; s=arc-20160816; b=MW2m/n5m0l072tkGc3kHmXgjz4hZb1DYMQBNmrf7JXsitx4tKJKAPAmpMHVsPM8z65 /AfyV8jbMLGkwaxoteCvF1rps6BF3+E5wZyzxAIcVp6HJxbyT8zEwGlaGF0CmM79YftF k/O9LSb/e0D5B919B/q90cYGT9HLhfMMeIyokA4jT2ptJH+Ice4Zh4ZzdFUtl32qtBnt fr68aGfVm7jzbedxBnc1ApmQZ7hj+OIITSiUErgfkkf8+iZAE17ziU0WmrCNECWT7Wz7 NDPq50SDkoQvLfPpbyLq/eulCMYsuQ6cLvelTaCv9H0afyYytl1s981dArf4JrQfC311 5iRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=k67cBPG9srLjL54QWfw/Ocx5qlG7BW50/auF9+vzWTg=; fh=Ur7trV5DymSdTuIlkUG3BMOUm8ZthzxbQxovB9pqK5w=; b=O96vc+jlhA4SdgV+aCBU+OesDbeAGxlyw7WwIBogy0xQ6bM48/QL6APGAtfL1zg0+G MzA4KWuBNqjOJfIcJC3gitzVgNZLdDBRUWgX53+6uGhB20oU6XukB95VhaAnGQ077rmJ MG1s8hjYW31BOkpjPQJddiYILloPWR2bKK27A/prNW5ZdBhRMRVUYYvWGO/PuAKYXo1T CwvHKfpdC9CZPc9ytZYFToJtv4vx9VRyBUlz4k6xiVmXWb1MENmekRqsxr1+ZK0+ONGj +zJm3HwYT86YceVGQFBNGkbZn4zYNl9g35/vSg0Yrrz1zJibalydmuAgz4UNvBDPhJ6y qSUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s23-20020a63f057000000b00543a6ce8c33si6523486pgj.78.2023.06.26.22.41.41; Mon, 26 Jun 2023 22:41:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229800AbjF0E7b (ORCPT + 99 others); Tue, 27 Jun 2023 00:59:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229699AbjF0E7a (ORCPT ); Tue, 27 Jun 2023 00:59:30 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32F001729; Mon, 26 Jun 2023 21:59:29 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id F126A6732D; Tue, 27 Jun 2023 06:59:24 +0200 (CEST) Date: Tue, 27 Jun 2023 06:59:24 +0200 From: Christoph Hellwig To: Damien Le Moal Cc: Min Li , axboe@kernel.dk, willy@infradead.org, hch@lst.de, gregkh@linuxfoundation.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] block: add check that partition length needs to be aligned with block size Message-ID: <20230627045924.GA16913@lst.de> References: <20230627110918.7608-1-min15.li@samsung.com> <8ea3bdfb-f2d9-ee5e-f623-02b2b134490d@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ea3bdfb-f2d9-ee5e-f623-02b2b134490d@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 27, 2023 at 01:39:26PM +0900, Damien Le Moal wrote: > See Greg's comment: this likely need a "Fixes:" tag. And I think that the tag > is: fa9156ae597c ("block: refactor blkpg_ioctl"). But please double check. No, the lack of checks goes back all the way to when this code was added long before git was a thing. So I don't think a Fixes tag makes all that much sense here.