Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp17230905rwd; Mon, 26 Jun 2023 23:26:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ505QTG2gByGhrmkx4KXmctGsMRAKpPYuHELm4uhRkuO1Dt88t2BFqTH/CyyceRh6gDe73f X-Received: by 2002:a17:907:968c:b0:988:b204:66a7 with SMTP id hd12-20020a170907968c00b00988b20466a7mr21853133ejc.74.1687847210589; Mon, 26 Jun 2023 23:26:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687847210; cv=none; d=google.com; s=arc-20160816; b=cXTvVyPGx/nfXZLrk7ry/87TyIKuYspSJaAJOa/NaRmeB+4lE4wrtib466nZGAdt7W qd9n1QMWLhB5WWRKu5Hl+0I+l3kNdM4747Dlt6qS/NlGLnLVSz4aQXnxwMPfEPFIvnZA +wDE6o4ALekgnbQQ8bx9ihEWHl2S0/CjuOR9XlKXpXaiYjTqa0FQ68CCtGvI95L8gn8W 1q/MI6DfwcPr/Vzh0ZnkJTp/J0pRPXrU00FqnHQCdtzYHol7iaOAJdP68pxRY0c1dEwt o/aWfZKVB9G8SKfOHemOQ4iVGOUth3oXBOgXePUvWxsyI7s7jQr2WPfc8W/BeFDsXfp3 6CyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=bJhVkZ481o9Id6Vha8aGNwHY2s9rA/bCYQ+mhU6/6Bo=; fh=O5AGXWvtPriNqdCOex+j5rgerDaowd648+maUlPl8w0=; b=cm+TVXjhav58nXnuUnd1eGk9Hdd6yc7aQa1SmJdFHbgPwjJyxV/0fSTSc2pJeWDKAe UEWyevlcV2G1/6qGWCR+H+yw+hJjgo6gydzlYt4qdnq0Mo6gxrji8M9W8vVkUMm3bW2E H512gzqLtSlyGm2PiYwLsxGIJk4uq1rQiYVX4AfRzmRFXOFmvfjI1d6JKB/1EAHvjo8r UnJuDD4NcF4dhbAqW4jOr0ymBGs6LpGukIpyPH9dENLWNNKzNIO+HmFMptDG2nucYnWZ 2stSH0TAM/MrOfhoTe5qaq0YkXqkZYebjcahqKg6BLM6EgP8oWjlaztabsCwhHImG1GW 6DrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZvU5iKpY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u14-20020a170906780e00b00991f96678cesi1088408ejm.615.2023.06.26.23.26.25; Mon, 26 Jun 2023 23:26:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZvU5iKpY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230073AbjF0GSk (ORCPT + 99 others); Tue, 27 Jun 2023 02:18:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229495AbjF0GSh (ORCPT ); Tue, 27 Jun 2023 02:18:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8783599; Mon, 26 Jun 2023 23:18:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 11E0B61022; Tue, 27 Jun 2023 06:18:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2604C433C8; Tue, 27 Jun 2023 06:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687846715; bh=PT1TJLw/+jsSSNNLBAlk12SUbxG6D/fqh2oAjy0ah4M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZvU5iKpYqWVA3jNGsgrCoyywbuPTGdklwuTnu1DNNfnjwOvhIpNAnVnDY0xIEgRyc fI+BkyMWY7KkXc3N9iCxg7rsz8knJ5QS94K24eCYoftC6MxIBsLhyKJlpGEKPCIqeT 2a96l2U7SLr5YV2EBSoZeEgD+z+XzcFzSImtezjk= Date: Tue, 27 Jun 2023 08:18:32 +0200 From: Greg KH To: Christoph Hellwig Cc: Damien Le Moal , Min Li , axboe@kernel.dk, willy@infradead.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] block: add check that partition length needs to be aligned with block size Message-ID: <2023062753-speech-straw-f2f6@gregkh> References: <20230627110918.7608-1-min15.li@samsung.com> <8ea3bdfb-f2d9-ee5e-f623-02b2b134490d@kernel.org> <20230627045924.GA16913@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230627045924.GA16913@lst.de> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 27, 2023 at 06:59:24AM +0200, Christoph Hellwig wrote: > On Tue, Jun 27, 2023 at 01:39:26PM +0900, Damien Le Moal wrote: > > See Greg's comment: this likely need a "Fixes:" tag. And I think that the tag > > is: fa9156ae597c ("block: refactor blkpg_ioctl"). But please double check. > > No, the lack of checks goes back all the way to when this code was > added long before git was a thing. So I don't think a Fixes tag makes > all that much sense here. Ok, then how about a normal "cc: stable@kernel.org" added to the s-o-b area so it gets picked up for all stable trees as this is an issue that has always been there? thanks, greg k-h