Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Jun 2023 08:25:58 +0100
From:   Conor Dooley <conor.dooley@microchip.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC:     Xianwei Zhao <xianwei.zhao@amlogic.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-amlogic@lists.infradead.org>, <devicetree@vger.kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: add support for T7 based Amlogic AN400
Message-ID: <20230627-pledge-recapture-7b17cc1c3c20@wendy>
References: <20230626095223.721011-1-xianwei.zhao@amlogic.com>
 <20230626095223.721011-3-xianwei.zhao@amlogic.com>
 <9b49e979-4a24-f628-88c4-fd53f53d46e4@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="cIrvvHlrPAOZayil"
Content-Disposition: inline
In-Reply-To: <9b49e979-4a24-f628-88c4-fd53f53d46e4@linaro.org>
Precedence: bulk

--cIrvvHlrPAOZayil
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 26, 2023 at 05:41:05PM +0200, Krzysztof Kozlowski wrote:
> On 26/06/2023 11:52, Xianwei Zhao wrote:
> > +
> > +		apb4: bus@fe000000 {
> > +			compatible =3D "simple-bus";
> > +			reg =3D <0x0 0xfe000000 0x0 0x480000>;
> > +			#address-cells =3D <2>;
> > +			#size-cells =3D <2>;
> > +			ranges =3D <0x0 0x0 0x0 0xfe000000 0x0 0x480000>;
> > +
> > +			uart_a: serial@78000 {
> > +				compatible =3D "amlogic,meson-s4-uart",
> > +					     "amlogic,meson-ao-uart";
> > +				reg =3D <0x0 0x78000 0x0 0x18>;
> > +				interrupts =3D <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
> > +				status =3D "disabled";
>=20
> Please, don't put status in the middle of properties...

The serial entry is also missing the soc specific compatible (and
removal of the always-on uart) that was discussed in Lucas Tanure's
series.

--cIrvvHlrPAOZayil
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZJqPBgAKCRB4tDGHoIJi
0lUYAQC15qMz0HEe5JtsuiOxiuOPkE7/jHHCIlO8J/hc+XCrCwD/exX4JGWZbAjU
AiyF6DU5r0BztLX/SlsSjJ4IIW54cgs=
=FvQO
-----END PGP SIGNATURE-----

--cIrvvHlrPAOZayil--