Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <709fbed2-a7cf-d2fa-da4e-5d417b7130d4@linaro.org>
Date:   Tue, 27 Jun 2023 09:43:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
From:   Neil Armstrong <neil.armstrong@linaro.org>
Reply-To: neil.armstrong@linaro.org
Subject: Re: [PATCH 0/2] Baisc devicetree support for Amlogic T7
Content-Language: en-US
To:     Xianwei Zhao <xianwei.zhao@amlogic.com>,
        Conor Dooley <conor.dooley@microchip.com>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Lucas Tanure <tanure@linux.com>
References: <20230626095223.721011-1-xianwei.zhao@amlogic.com>
 <20230626-viewless-marrow-17838c2172f6@wendy>
 <676db602-54d8-d6b0-274f-365e65a2102c@amlogic.com>
Organization: Linaro Developer Services
In-Reply-To: <676db602-54d8-d6b0-274f-365e65a2102c@amlogic.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 27/06/2023 08:13, Xianwei Zhao wrote:
> Hi Conor,
>      Thanks for you reply.
> On 2023/6/26 18:02, Conor Dooley wrote:
> 
> 
>  > [ EXTERNAL EMAIL ]
>  >
>  > Hey,
>  >
>  > On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
>  >> T7 is an advanced application processor designed for smart display.
>  >>
>  >> Add the new T7 SoC/board device tree bindings.
>  >>
>  >> Add basic support for the T7 based Amlogic AN400 board, which describes
>  >> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
>  >> booting up into the serial console.
>  >
>  > Lucas has already sent patches for the T7 SoC & is at v5:
>  > https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-tanure@linux.com/
>  >
>  > There's been a bit of discussion there, and there serial stuff in
>  > particular is different in his series (it doesn't use always-on for
>  > examples).
>  > Could you please go and take a look at his series?
>  >
>  > Cheers,
>  > Conor.
>  >
> AN400 is the reference board designed by Amlogic, which is different from Khadas VIM4.

Please coordinate with Lucas so a single bindings & dtsi patches are submitted,
in any case only a single one will be reviewed and merged.
You can rebase your AN400 dts on top of his VIM4 initial patchset.

Thanks,
Neil

> And T7 serial is the same as S4, so I follow S4 serial.
> 
>  >>
>  >> Xianwei Zhao (2):
>  >>    dt-bindings: arm: amlogic: add T7 based AN400 bindings
>  >>    arm64: dts: add support for T7 based Amlogic AN400
>  >>
>  >>   .../devicetree/bindings/arm/amlogic.yaml      |   6 +
>  >>   arch/arm64/boot/dts/amlogic/Makefile          |   1 +
>  >>   .../dts/amlogic/amlogic-t7-a311d2-an400.dts   |  30 ++++
>  >>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   | 156 ++++++++++++++++++
>  >>   4 files changed, 193 insertions(+)
>  >> create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
>  >> create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>  >>
>  >>
>  >> base-commit: 057889cb4244096ea5abcbe76ffd4d311c3078fe
>  >> --
>  >> 2.37.1
>  >>
>  >>
>  >> _______________________________________________
>  >> linux-amlogic mailing list
>  >> linux-amlogic@lists.infradead.org
>  >> http://lists.infradead.org/mailman/listinfo/linux-amlogic