Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c3c7fb8a-7c0c-5966-88cd-e004db69de83@starfivetech.com>
Date:   Tue, 27 Jun 2023 15:46:08 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v4 0/4] StarFive's Pulse Width Modulation driver support
To:     <devicetree@vger.kernel.org>, <linux-pwm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-riscv@lists.infradead.org>
CC:     Thierry Reding <thierry.reding@gmail.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Emil Renner Berthing <kernel@esmil.dk>,
        Hal Feng <hal.feng@starfivetech.com>
References: <20230601085154.36938-1-william.qiu@starfivetech.com>
Content-Language: en-US
From:   William Qiu <william.qiu@starfivetech.com>
In-Reply-To: <20230601085154.36938-1-william.qiu@starfivetech.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2023/6/1 16:51, William Qiu wrote:
> Hi,
> 
> This patchset adds initial rudimentary support for the StarFive
> Pulse Width Modulation controller driver. And this driver will
> be used in StarFive's VisionFive 2 board.The first patch add
> Documentations for the device and Patch 2 adds device probe for
> the module.
> 
> Changes v2->v3:
> - Rebased to v6.4rc3.
> - Sorted the header files in alphabetic order.
> - Changed iowrite32() to writel().
> - Added a way to turn off.
> - Moified polarity inversion implementation.
> - Added 7100 support.
> - Added dts patches.
> - Used the various helpers in linux/math.h.
> - Corrected formatting problems.
> - Renamed dtbinding  to 'starfive,jh7100-pwm.yaml'.
> - Dropped the redundant code.
> 
> Changes v2->v3:
> - Fixed some formatting issues.
> 
> Changes v1->v2:
> - Renamed the dt-binding 'pwm-starfive.yaml' to 'starfive,jh7110-pwm.yaml'.
> - Dropped the compatible's Items.
> - Dropped the unuse defines.
> - Modified the code to follow the Linux coding style.
> - Changed return value to dev_err_probe.
> - Dropped the unnecessary local variable.
> 
> The patch series is based on v6.4rc3.
> 
> William Qiu (4):
>   dt-bindings: pwm: Add StarFive PWM module
>   pwm: starfive: Add PWM driver support
>   riscv: dts: starfive: jh7110: Add PWM node and pins configuration
>   riscv: dts: starfive: jh7100: Add PWM node and pins configuration
> 
>  .../bindings/pwm/starfive,jh7100-pwm.yaml     |  55 +++++
>  MAINTAINERS                                   |   7 +
>  .../boot/dts/starfive/jh7100-common.dtsi      |  24 +++
>  arch/riscv/boot/dts/starfive/jh7100.dtsi      |   9 +
>  .../jh7110-starfive-visionfive-2.dtsi         |  22 ++
>  arch/riscv/boot/dts/starfive/jh7110.dtsi      |   9 +
>  drivers/pwm/Kconfig                           |   9 +
>  drivers/pwm/Makefile                          |   1 +
>  drivers/pwm/pwm-starfive-ptc.c                | 192 ++++++++++++++++++
>  9 files changed, 328 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/starfive,jh7100-pwm.yaml
>  create mode 100644 drivers/pwm/pwm-starfive-ptc.c
> 
> --
> 2.34.1
> 
Hi everyone,

Could you please help me review this patch series to see if there is
anything that needs to be modified?
Thanks for taking time to review this patch series.

Best Regards,
William