Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@oss.nxp.com>
To:     andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, richardcochran@gmail.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        sebastian.tobuschat@nxp.com,
        "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@oss.nxp.com>
Subject: [PATCH net-next v3 10/12] net: phy: nxp-c45-tja11xx: run cable test with the PHY in test mode
Date:   Tue, 27 Jun 2023 10:18:51 +0300
Message-Id: <20230627071853.106215-11-radu-nicolae.pirea@oss.nxp.com>
In-Reply-To: <20230627071853.106215-1-radu-nicolae.pirea@oss.nxp.com>
References: <20230627071853.106215-1-radu-nicolae.pirea@oss.nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AM9PR04MB8954:EE_|AM9PR04MB8778:EE_
X-MS-Office365-Filtering-Correlation-Id: 7268b0b6-bc1d-456b-3b1b-08db76deecc4
X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: RaTOZs9BFOu4buqIvjQ0Nq15608tt4XiJdQePC2937/Osg7k2ozVpwsrIDW0HqXCF87dt0F5LBE8m6qRw37OC0T014rXj6iEHGy9h+hipGTdo1PwbyK7pz+g3/Jk2X0UaKA1tkUtZeDl1n1sAcvMJ7/6XT9LS1FCt5TOePSps4cBk0XYCcsAvjuyJosyNQicHA7CVNmVwBvfsOh31QMScL54ptr6vggDBMNok8vLQoSDKVzJvn5ZGRvpCVyx4I4r6a3+WTIjgrD6F1Xfvt6dhVdl1wk//byTpJ95uVvN9dCVaet6gEG8Fc5OXb9NJ9DmyfZ+GiTxnzDpaDP7PJl8VovmIx3lskU+wa8On4AVuH0LLzJU7iJ+vUttHoLeeiksVnPJYURxCx7TnyIxk8JkxPjPggbWBcVON1M94TJQEiEfKN5f/ObYBqju9LIiOru9BOWyPxMpvXLytF7ucpVA1Cg8eD63p2OwlzJfnZmCAkvrB/G7AcQS7IcQQZIjSX8tygu7IhEwAB7kYOH5Mxv5jpmQRE7iapE+SRpxScUdkRmTGZ4bI3inTtWYCfsuPzEnSULqTnjAHevdaGo+CnR8K2FNzsxBHgNrM8ys4rWjlP4rfBlHdTYcNCwRC16nI3E2
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8954.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(136003)(39860400002)(396003)(366004)(376002)(451199021)(66556008)(66476007)(6506007)(6666004)(478600001)(2616005)(52116002)(26005)(186003)(1076003)(2906002)(6486002)(5660300002)(7416002)(316002)(66946007)(38100700002)(8676002)(86362001)(8936002)(41300700001)(4326008)(38350700002)(6512007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?U9jfoof6UVaEGWl1D63/1Jv/ET5QgpXKVL+9v/uCWbI6YngsVdw/WdNz71iZ?=
 =?us-ascii?Q?shkfIKva6xByrfBhnScqOZZ6k/4BYvFVaUKoQuCUOCNMmfzg5QDw+t+OmBX7?=
 =?us-ascii?Q?uUampQvnbwY/KdYpZPGXCn3FFS3px9stbrCWwWes37o4NmGatPgUAVZ+Elwg?=
 =?us-ascii?Q?ZCkBVOqbFZ9Jy+7tpVz2GpsABFQ+0xa5j9NVheuJoVpiNUucO9cOeTxD+HR3?=
 =?us-ascii?Q?fSsiVRhVExNE0mz/uBB0T7I1E+n3gw/I4O9z/Q0GDNPXKWMR2N1P4pFTnDdv?=
 =?us-ascii?Q?XkkMGeT5YiLGLiW79ii7aGLt5i15Mp4wUeIRc8XZioJ/wBpbxcs3yoBwNVH1?=
 =?us-ascii?Q?BQ6Rb68/Zz5PnLUJl99PiB5Q8JLo4gtESXtXvU28ytRoe02XyBP/8Q+Ek3bV?=
 =?us-ascii?Q?5VINADklzyIz4Y7P1LEWqdOYaKxtiC/O/W8TQYjVekHv9CRUFLmyKdv2fhLW?=
 =?us-ascii?Q?op0XbX0ljsajyG/PGpfsAjyyxxdZZ8BBhkeAer5nI4PtG1lFLvYPZLx7rOc/?=
 =?us-ascii?Q?lwVD0Dqn0vCYUjupn5kBOwrTO4rS5yZaRZpr4n+yC1ObYKSsRmo717dNvx1S?=
 =?us-ascii?Q?yGkb84rvCF70YARKFoCpv0u0ZRpgieDWlU+qrDCyrrfclYzWybKWvW4nPm1F?=
 =?us-ascii?Q?Eh7zYdp08/uCxXBfHBTf77PMEWTNnjXw4xg36bIUvqH6K8Gj3CaNE6i34pbN?=
 =?us-ascii?Q?FOr1M60m3LGt9bycf3j3Mp2/luy6FVejHVeIFni6D2aYuWTEAvlT9WXPjqYl?=
 =?us-ascii?Q?upmM6uYfnAgpK03DoftMuDnBYKfOpicM0OPsZdibKFV38hBJ/nbyWjciRRoa?=
 =?us-ascii?Q?5NMHvQDrh9sEw4yxaMDeGVA/Z9fkKLqySrq4umq4BOo14WrQdCZf0pr0Wn1O?=
 =?us-ascii?Q?2yWFHaPXueIaiCIt9ZUqL0OHvxtgdDxuNZe3JwHDnVwHgI9B8mgkdrl+uD8/?=
 =?us-ascii?Q?RQJTsSQA5wPchCbQbTk/Ucl4PFJtYW7Leit/wZrAdCVhQ4pU4mSVDCg0WPZg?=
 =?us-ascii?Q?j9ONYarXOaFelhruNW6eTyHGCiruq9EgoWPYgzdkxiJROReOhFBvLs4ODa86?=
 =?us-ascii?Q?xfGQ5KWQirudv3hGQO++JIvRZxJ5Dyacz3kft0vH1jG+PTGcwHYy/EddK67y?=
 =?us-ascii?Q?8ucfsAph5ZxKXLlJJ7eeInPlQrsDkyz+fsBkfIpwAm+ix8wClm27T0dCYXQZ?=
 =?us-ascii?Q?q2Z/kVMerD+CMxF4fJZXdCxmW3i6VqS3Vfu/6zBE7QaSq0jWyN/3pOOwcyeB?=
 =?us-ascii?Q?ver0y6WBGERjCkbMSXNKkjVEoH3g3tU7ood2o4kgi3eJfP8ff4HgP8RKJ8kh?=
 =?us-ascii?Q?Ggb35wBnGiM1HcPWjZDXVOXvutgkk8ukh8viR9Bv2ch9V3h+kMbkvJleMyTo?=
 =?us-ascii?Q?QzkMUaHZ3PTKfuFlqR9Ph8//Ri43wt9qASONRVMqw84jnsRJCmucK8WVTuzb?=
 =?us-ascii?Q?caRkeN+nbNuqX2Z8o4TGPPMOzsLBa0S9UnsFXSbOQebwaKomjdVkjbNkd5y0?=
 =?us-ascii?Q?bFGxAn2gRwkAgUxlgVebUa1WM7yH3NtZaN0ekx1Ijs3jTdmrL3+RvhvurBhH?=
 =?us-ascii?Q?stwwpU6Q43epTWO5sVhHFRCymapz6wImMd0JP1FgIiVto96jKq9qJEO63l2V?=
 =?us-ascii?Q?+Q=3D=3D?=
X-OriginatorOrg: oss.nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7268b0b6-bc1d-456b-3b1b-08db76deecc4
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8954.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 07:20:03.1554
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gHlZHM+56nA3N6IJ6HZbHtp8UKbc2GlvEFqYlaO94tu+3SzpZS2YIPWubYn+2xSVpHLQqGUMvyZxOUzR7P2Fb1nIMMZnPOEQKHVE8PVdGF4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8778
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

For TJA1120, the enable bit for cable test is not writable if the PHY is
not in test mode.

Signed-off-by: Radu Pirea (NXP OSS) <radu-nicolae.pirea@oss.nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
---
 drivers/net/phy/nxp-c45-tja11xx.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/phy/nxp-c45-tja11xx.c b/drivers/net/phy/nxp-c45-tja11xx.c
index a826c845ee7d..8097ac8d6962 100644
--- a/drivers/net/phy/nxp-c45-tja11xx.c
+++ b/drivers/net/phy/nxp-c45-tja11xx.c
@@ -145,6 +145,7 @@
 
 #define VEND1_PORT_FUNC_ENABLES		0x8048
 #define PTP_ENABLE			BIT(3)
+#define PHY_TEST_ENABLE			BIT(0)
 
 #define VEND1_PORT_PTP_CONTROL		0x9000
 #define PORT_PTP_CONTROL_BYPASS		BIT(11)
@@ -1258,6 +1259,8 @@ static int nxp_c45_cable_test_start(struct phy_device *phydev)
 {
 	const struct nxp_c45_regmap *regmap = nxp_c45_get_regmap(phydev);
 
+	phy_set_bits_mmd(phydev, MDIO_MMD_VEND1,
+			 VEND1_PORT_FUNC_ENABLES, PHY_TEST_ENABLE);
 	return phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, regmap->cable_test,
 				CABLE_TEST_ENABLE | CABLE_TEST_START);
 }
@@ -1299,6 +1302,8 @@ static int nxp_c45_cable_test_get_status(struct phy_device *phydev,
 
 	phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, regmap->cable_test,
 			   CABLE_TEST_ENABLE);
+	phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
+			   VEND1_PORT_FUNC_ENABLES, PHY_TEST_ENABLE);
 
 	return nxp_c45_start_op(phydev);
 }
-- 
2.34.1