Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <286732aa-a4b4-a426-d59e-3c37520479a5@linaro.org>
Date:   Tue, 27 Jun 2023 09:58:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
From:   neil.armstrong@linaro.org
Reply-To: neil.armstrong@linaro.org
Subject: Re: [PATCH] dt-bindings: interrupt-controller: New binding for
 Meson-C3 SoCs
Content-Language: en-US
To:     Huqiang Qin <huqiang.qin@amlogic.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        tglx@linutronix.de, maz@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        khilman@baylibre.com, jbrunet@baylibre.com,
        martin.blumenstingl@googlemail.com
Cc:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org
References: <20230620070849.2059451-1-huqiang.qin@amlogic.com>
 <2e762290-46f1-0f0c-48b1-b399812f9ac1@linaro.org>
Organization: Linaro Developer Services
In-Reply-To: <2e762290-46f1-0f0c-48b1-b399812f9ac1@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 20/06/2023 09:34, Krzysztof Kozlowski wrote:
> On 20/06/2023 09:08, Huqiang Qin wrote:
>> Update dt-binding document for GPIO interrupt controller of Meson-C3 SoCs
>>
>> Signed-off-by: Huqiang Qin <huqiang.qin@amlogic.com>
>> ---
>>   .../bindings/interrupt-controller/amlogic,meson-gpio-intc.txt    | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
>> index bde63f8f090e..fdea0488a98c 100644
>> --- a/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
>> +++ b/Documentation/devicetree/bindings/interrupt-controller/amlogic,meson-gpio-intc.txt
>> @@ -19,6 +19,7 @@ Required properties:
>>       "amlogic,meson-sm1-gpio-intc" for SM1 SoCs (S905D3, S905X3, S905Y3)
>>       "amlogic,meson-a1-gpio-intc" for A1 SoCs (A113L)
>>       "amlogic,meson-s4-gpio-intc" for S4 SoCs (S802X2, S905Y4, S805X2G, S905W2)
>> +    "amlogic,meson-c3-gpio-intc" for C3 SoCs (C308L, C302X)
> 
> Where is the user?
> 
> If there is going to be resend/new version:
> A nit, subject: drop second/last, redundant "New binding for". The
> "dt-bindings" prefix is already stating that these are bindings.
> "Add Meson C3 SoC interrupt controller"

And the bindings was updated to yaml and merged for v6.5, please rebase on:
https://lore.kernel.org/all/e06e9f26-cf55-5596-c799-d698e9d7b409@gmail.com/

Neil

> 
> Best regards,
> Krzysztof
>