Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Jun 2023 10:13:39 +0200
From:   Pankaj Raghav <p.raghav@samsung.com>
To:     Damien Le Moal <dlemoal@kernel.org>
CC:     Min Li <min15.li@samsung.com>, <axboe@kernel.dk>,
        <willy@infradead.org>, <hch@lst.de>, <gregkh@linuxfoundation.org>,
        <linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] block: add check that partition length needs to be
 aligned with block size
Message-ID: <20230627081339.fv76swi3srqdfpra@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <8ea3bdfb-f2d9-ee5e-f623-02b2b134490d@kernel.org>
CMS-TYPE: 201P
References: <CGME20230627031105epcas5p3010432ebd447ad865c3ddd986b3ffee0@epcas5p3.samsung.com>
        <20230627110918.7608-1-min15.li@samsung.com>
        <8ea3bdfb-f2d9-ee5e-f623-02b2b134490d@kernel.org>
Precedence: bulk

On Tue, Jun 27, 2023 at 01:39:26PM +0900, Damien Le Moal wrote:
> > diff --git a/block/ioctl.c b/block/ioctl.c
> > index 3be11941fb2d..c40b382dd58f 100644
> > --- a/block/ioctl.c
> > +++ b/block/ioctl.c
> > @@ -33,14 +33,18 @@ static int blkpg_do_ioctl(struct block_device *bdev,
> >  	if (op == BLKPG_DEL_PARTITION)
> >  		return bdev_del_partition(disk, p.pno);
> >  
> > +	/* check if partition is aligned to blocksize */
> > +	if (p.start & (bdev_logical_block_size(bdev) - 1))
> > +		return -EINVAL;
> > +	/* check if length is aligned to blocksize */
> > +	if (p.length & (bdev_logical_block_size(bdev) - 1))
> > +		return -EINVAL;
> 
> 	long long blksz_mask = bdev_logical_block_size(bdev) - 1;
> 
> 	/* Check that the partition is aligned to the block size */
> 	if ((p.start & blksz_mask) || (p.length & blksz_mask))
> 		return -EINVAL;

A Minor nit on top of your comment:

 	unsigned int blksz = bdev_logical_block_size(bdev);
 
 	/* Check that the partition is aligned to the block size */
 	if (!IS_ALIGNED(p.start, blksz) || !IS_ALIGNED(p.length, blksz))
 		return -EINVAL;

> 
> would be cleaner and avoid the rather redundant comments.
>