Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Jun 2023 16:08:07 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Tim Chen <tim.c.chen@linux.intel.com>
CC:     Aaron Lu <aaron.lu@intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Ingo Molnar <mingo@redhat.com>,
        Juri Lelli <juri.lelli@redhat.com>,
        Deng Pan <pan.deng@intel.com>, <tim.c.chen@intel.com>,
        <linux-kernel@vger.kernel.org>, <tianyou.li@intel.com>,
        <yu.ma@intel.com>, <lipeng.zhu@intel.com>
Subject: Re: [PATCH v2] sched/task_group: Re-layout structure to reduce false
 sharing
Message-ID: <ZJqY5xnCv7BNkWuj@chenyu5-mobl2.ccr.corp.intel.com>
References: <20230621081425.420607-1-pan.deng@intel.com>
 <20230626054756.GA435374@ziqianlu-dell>
 <ZJlDsbyNmcKtweg4@chenyu5-mobl2.ccr.corp.intel.com>
 <0a611696cbc63a3a9b99a7966b8fe4f7e20a014b.camel@linux.intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <0a611696cbc63a3a9b99a7966b8fe4f7e20a014b.camel@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MhJ+iQYn5Oq3ceO6hjJ72Cw0aYm5bpQQVbPAk6QM+C7JdApMuJ0lwo135DkH?=
 =?us-ascii?Q?ozdJ6SCpXi/0JNx5c6zvn9VlfHJ4JGKLvP+NcJFDpoNM7mCL0FJO8WeIvfPw?=
 =?us-ascii?Q?q9buOYIIs/kvHlZleWs6pKYkes+D4REgi0pru2gkJSO1eKF+ydkYCquF1rCb?=
 =?us-ascii?Q?A1zxZq21A/iK9Mr9Qxdwns+gTFtNiBtzV/yeFq6W80qYTTMLwU7PSOKiAIHs?=
 =?us-ascii?Q?p1CW+FmuooOWLnrSRAtb1pNoel7f/dUgl9utD2cEcRNhq7Unb+Q4c/uuuiR7?=
 =?us-ascii?Q?9QuMvr6oM22wlvUf05/HB86zogFno0g1Jw75McSP57DJoj02tUnlCx946UCr?=
 =?us-ascii?Q?kyz5WLjIw4WsipJFhMrCEcWn2e3PqZkX0X4N566uOdXw/ArMavOvIt0+J6Ln?=
 =?us-ascii?Q?fS3X3sj8cqqrrPcYxdypg6AzfcwWVPnZP9lEMpo3QGcQmXvqi/ht1JrpJb7M?=
 =?us-ascii?Q?eqCrMlvhkd9ByYmY8y6YsFFfC+Att/qA/KlAWmWsaGXZfOmCTS+FAl2A9ApL?=
 =?us-ascii?Q?1hAaUsZ7ct0Z9h2tTkCbMU2VPdLZvw/chPwE13jF+ePwXQOfEMN5k3lzIlU4?=
 =?us-ascii?Q?xsE8DT8cstJ1bpZjYBslJ6EhTejkMb+alvOdzs7Dp5a2ACrz595uV/ci5Zy/?=
 =?us-ascii?Q?3/c0vXYNXS2s1mduJuNoz1+n3uKiwNj9m6qkFO8C1Dhi6TySurw+xPnwRobs?=
 =?us-ascii?Q?bq+g6yHSQT2ls2C0h2o3QpsJDypzSzFn37z2dPi0eQHaXC3f9c+Q/SY1+Adq?=
 =?us-ascii?Q?f6h3x1vqp5+euqObD0+lZYBA9M1M64JWxMb66mJxh4W45o7Rd0NTM5GHxqI8?=
 =?us-ascii?Q?MLtjy1kW32pcp5bTzH2GmArSAr8Szd2UBBmmgWRddB2RkQo15jsP/Kbh9x9k?=
 =?us-ascii?Q?audZEQdf/w4JQnC1jwdfYtQAqKOeI5LDjiC2jLZ8BNXTe7L4Faby3tAKLdcy?=
 =?us-ascii?Q?5M+ubOXq/lJ2NsSEOeZMJ5y5MEa+xFv3Kw9OoCwc5MrtepyDN4thNKIV/pNW?=
 =?us-ascii?Q?+/aHkwvybWa/guyoPukNJYqcE+W3wojiemrVw/6n83AAEgVR+d3uEfRtecah?=
 =?us-ascii?Q?icGxODDB4rKxyJxTeywH0lmrFu3k4REk2inVsFqo4bBUF/CshWMqY8xycj61?=
 =?us-ascii?Q?Q7yMckneWNfosxTYR66dDH7SZQrEdLMT/T0bVVr2P7jIHMofutW59aF13iKw?=
 =?us-ascii?Q?xm+NyfUPwV9+uGOhfs4JAIWoKsnOSgXC6zFMXuDErtBINQ/CeQZVzXlg2+o2?=
 =?us-ascii?Q?E9KeTJbuO+wXR9pgDMXrSu1Jx82HD8+1jIak3mteL9Kz9VbgClTPIhSJXLJb?=
 =?us-ascii?Q?AKLiFy0gFOJS14NjDquS60hr+IzK2m38lNcwEdIqjVP3lqq65NW7uDM/WlTg?=
 =?us-ascii?Q?NmXmZQFs7GiO1F4HhWxPatOF15VMShgzeMOjgLycWmG2QWSPW7oVBcLDRRFL?=
 =?us-ascii?Q?Q+JdmbzQ4fY1gv4OL+FaxdmnQGqGzh8m8wXmGZ0ehxhGv1c4vQxTgVyFWl51?=
 =?us-ascii?Q?LX+Doh9KEQHGBrmn1aXUylF8gQeWnCnsAJbm/szlQY2xPEh7i1pzcQkGSWjc?=
 =?us-ascii?Q?sTOgwjQQeoAVsIZ1eUmHU2BPDJWR2x2zl6AWQmoI?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 90c7a31b-8641-49e8-fbc7-08db76e5abf8
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 08:08:20.8886
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LaqV/xhcVlr5N0IMBUiQr4u5uD+EENK/X3s/KqkIodP5NTQj9OM5f02IrEnxNuZ0Z1Jcpc59sNBpVPh0aXCN0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6615
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2023-06-26 at 10:09:10 -0700, Tim Chen wrote:
> On Mon, 2023-06-26 at 15:52 +0800, Chen Yu wrote:
> > 
> >  
> > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> > index ec7b3e0a2b20..067f1310bad2 100644
> > --- a/kernel/sched/sched.h
> > +++ b/kernel/sched/sched.h
> > @@ -1958,8 +1958,10 @@ static inline void set_task_rq(struct task_struct *p, unsigned int cpu)
> >  #endif
> >  
> >  #ifdef CONFIG_RT_GROUP_SCHED
> > -	p->rt.rt_rq  = tg->rt_rq[cpu];
> > -	p->rt.parent = tg->rt_se[cpu];
> > +	if (p->sched_class = &rt_sched_class) {
> > +		p->rt.rt_rq  = tg->rt_rq[cpu];
> > +		p->rt.parent = tg->rt_se[cpu];
> > +	}
> 
> If we avoid the assignment for non-rt task, do you see it further improves
> c2c bounce?
>
I did not see noticeable extra throughput improvement from netperf, with
above change + Aaron's fix + Pan's cacheline alignment adjustment.

thanks,
Chenyu