Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp17372494rwd; Tue, 27 Jun 2023 01:59:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4zSBDHrQnE2WEWKqDgVZTRmV1AELeC5Um0tmjVnmMt+oGbokufj9eFu876FP1nsO63abiw X-Received: by 2002:aa7:d758:0:b0:51b:e9d2:f17d with SMTP id a24-20020aa7d758000000b0051be9d2f17dmr9897289eds.27.1687856379738; Tue, 27 Jun 2023 01:59:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687856379; cv=none; d=google.com; s=arc-20160816; b=vhmTfl0Mkn+nB4He+5lR4dCeo9fmUiF/dnRYZoEpsD5QdMRxmaX59SxUDxjxyQlln+ S/xWgrxhH+AGQiQIqV9Sc1+oWIL1fV7B5k3jiaU3ZU+45mNxECgx++RCfNocMK0FaLA6 +8nqfFJs4GalWBUbtuu8SVtJ5hmf88EPvP9MmHeeFsAZUfiXOKWLnjMXCJwpqDrrSMiz cNg4oAkGCtLtuO0tWmeP85VC59dnAIvTGePPvXt4/bWJIVw9LvQzsWXONJIk4T7EhdRK aL2JbaioIBuNy2Tm7GlnqEZiJ2uhEV9MfvGNBAqXV4iyptpSAZ3L+aiAB3sCb2tCilAc BVdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:references:to:from:subject:cc :message-id:date:content-transfer-encoding:mime-version :dkim-signature; bh=fqX5DHgOV5JQh3n7wQTrKqWa0S9nC80jd5IBZP65NGs=; fh=IUapnXzqJiVsv34qSlJeWUNyRFuvhFIpbHWL1jR5WUw=; b=RtaVXAzx5vxBb5M/mEBB/wWubpoeAhjX0uD/Y0wX0vvD4+XSVMV6oLATLnGZkJs0VG cr16KAwgv/qdR0ZggSyEsthpP2M6Jf/uiVGnZPzHQOHkrfiicFIPalwT+QzuyecRmBEN UCdsxvd3tsPwOwbBiTvM/WayurHJy3axYY46F304iEtLybHUzSzPfEJHJBjs+YM+GR5f U9e+afGI7R5EeVeIKZqn0KmtyUAghe25/QEraayRc2zyjbfcoSJkTeDx1hA3WvXjNqUx Ol6U1IfDUERu02XTLOB98F4+V4ZInUvMo2WPLGtoc+jipOyDu6RPJo/KpZK1Q1dlIPYd s/VQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=a4GBqxpv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v16-20020aa7d650000000b0051dacd53285si524367edr.241.2023.06.27.01.59.14; Tue, 27 Jun 2023 01:59:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@fairphone.com header.s=fair header.b=a4GBqxpv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fairphone.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230161AbjF0IbG (ORCPT + 99 others); Tue, 27 Jun 2023 04:31:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231775AbjF0Iak (ORCPT ); Tue, 27 Jun 2023 04:30:40 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A71E2D5E for ; Tue, 27 Jun 2023 01:29:39 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-98e1ccc6673so387684666b.3 for ; Tue, 27 Jun 2023 01:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1687854571; x=1690446571; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fqX5DHgOV5JQh3n7wQTrKqWa0S9nC80jd5IBZP65NGs=; b=a4GBqxpv7jmHHEKUWeBkMva7W8g70p2YDS9GOd07Uc026C9bLeWu0YTtk0uNpHY9AM n6EJOWy+3oafyfX58MRJtYU7Gv5CCMH4n68fNbXwD/RiLNPDUl3FKnvsGlYYCPTPS0Fk A145SpaxENj2UwkTrlvH6FuXf4tcGJPUgqZbRsTiOOJZiBaI47prE0BaPIasVX5WoChS b9b1Np5DrL0nHV8qCVMpOqMG2tomiTFGwZxcWAqKGfi5CFBeUMHJwESu0Elojtbat8FE sAPaqG61Rfs5IE+jnGIGf2LCn5RSfJlx+c5QiFIb+DBTFgimDYgKPo9XR6cg/dAGs+an oJIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687854571; x=1690446571; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fqX5DHgOV5JQh3n7wQTrKqWa0S9nC80jd5IBZP65NGs=; b=XOPY1dnmV/JYUTkCvXkWQKd8HKYjMaTXQ5WIVSaOi8Qnzg1ppVQv1+IskDeciNHwPQ YDKAvXRXAwBOLjtqSeUZEmNLLFGxitNmQgo50j+StJ8EvZzsOXnec8FN8SkepDe9lyLe Rw3N01Wa6OOxiNpenyIXYU3ZL4OBSVhzbHPB6MPx5cTU2VX7aCXIDyVljUqVBZKFp/0u K36XD9md2eX7rKsJTX0QKZU9mhzExDwO6t/DVeF58Y+haIts/GaJccJC+XTWkBYTLimw vZRZUWKxtRQtWZB1DBNlpjsOIvI/aAClXoQ3JQkyj6nQ3HsEZpyUuvYdB5s+9Wc8nwAG AH5g== X-Gm-Message-State: AC+VfDxPh5/exZBipEDj2lwWWFHCmoUR90HFNjCtpf++9fvkLiCInl8d h5rUDovhHo2ty+Qce52pWnmcDA== X-Received: by 2002:a17:906:974f:b0:98c:df38:517b with SMTP id o15-20020a170906974f00b0098cdf38517bmr15489785ejy.33.1687854571341; Tue, 27 Jun 2023 01:29:31 -0700 (PDT) Received: from localhost (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id ot6-20020a170906ccc600b0098df7d0e096sm3955863ejb.54.2023.06.27.01.29.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jun 2023 01:29:31 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 27 Jun 2023 10:29:30 +0200 Message-Id: Cc: , , , , <~postmarketos/upstreaming@lists.sr.ht>, , "Eric Biggers" Subject: Re: [PATCH v4 3/3] dt-bindings: ufs: qcom: Fix sm8450 bindings From: "Luca Weiss" To: "Krzysztof Kozlowski" , "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Alim Akhtar" , "Avri Altman" , "Bart Van Assche" , "Rob Herring" , "Krzysztof Kozlowski" , "Iskren Chernev" , "Manivannan Sadhasivam" , "Conor Dooley" X-Mailer: aerc 0.15.1 References: <20221209-dt-binding-ufs-v4-0-14ced60f3d1b@fairphone.com> <20221209-dt-binding-ufs-v4-3-14ced60f3d1b@fairphone.com> <1f94de94-c5bd-738d-5fbe-907558333cb2@linaro.org> In-Reply-To: <1f94de94-c5bd-738d-5fbe-907558333cb2@linaro.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon Jun 26, 2023 at 10:27 AM CEST, Krzysztof Kozlowski wrote: > On 26/06/2023 10:15, Luca Weiss wrote: > > SM8450 actually supports ICE (Inline Crypto Engine) so adjust the > > bindings and the example to match. > >=20 > > Reviewed-by: Krzysztof Kozlowski > > Reviewed-by: Eric Biggers > > Reviewed-by: Iskren Chernev > > Signed-off-by: Luca Weiss > > SM8450 should be rather converted to qcom,ice. In v5 sm8450 is now using ICE, both in dtsi and binding example. But I guess you could also argue reg-names should be purged from dtsi and binding completely and to convert all existing dtsi to use the standalone ice node, right? But I'd also like for this series to finally land at some point, we can do this later, okay? Regards Luca > > Best regards, > Krzysztof