Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230627091007.190958-1-tanure@linux.com> <20230627091007.190958-4-tanure@linux.com>
 <3570635f-99ab-7127-0441-53852688a59c@linaro.org>
In-Reply-To: <3570635f-99ab-7127-0441-53852688a59c@linaro.org>
Reply-To: tanure@linux.com
From:   Lucas Tanure <tanure@linux.com>
Date:   Tue, 27 Jun 2023 10:16:23 +0100
Message-ID: <CAJX_Q+0fHUQTzgCUb5mU2BPFdwTnxNsq8+YCNadvdsq2_aeMaA@mail.gmail.com>
Subject: Re: [PATCH v6 3/4] tty: serial: meson: Add a earlycon for the T7 SoC
To:     neil.armstrong@linaro.org
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Xianwei Zhao <xianwei.zhao@amlogic.com>,
        Nick <nick@khadas.com>, Artem <art@khadas.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-amlogic@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, Jun 27, 2023 at 10:12 AM Neil Armstrong
<neil.armstrong@linaro.org> wrote:
>
> Hi Lucas,
>
> On 27/06/2023 11:10, Lucas Tanure wrote:
> > The new Amlogic T7 SoC does not have a always-on uart,
> > so add OF_EARLYCON_DECLARE for it.
> >
> > Signed-off-by: Lucas Tanure <tanure@linux.com>
> > ---
> >   drivers/tty/serial/meson_uart.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> > index 2501db5a7aaf..c24e105a98c5 100644
> > --- a/drivers/tty/serial/meson_uart.c
> > +++ b/drivers/tty/serial/meson_uart.c
> > @@ -649,6 +649,8 @@ meson_serial_early_console_setup(struct earlycon_device *device, const char *opt
> >
> >   OF_EARLYCON_DECLARE(meson, "amlogic,meson-ao-uart",
> >                   meson_serial_early_console_setup);
> > +OF_EARLYCON_DECLARE(meson, "amlogic,t7-uart",
> > +                 meson_serial_early_console_setup);
> >
> >   #define MESON_SERIAL_CONSOLE        (&meson_serial_console)
> >   #else
>
> I've reviewed last version of this patch, please keep tags for minor changes,
> or explicitely explain why you didn't keep the tag.
>
> Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
Sure, I didn't keep it because the change from "amlogic,meson-t7-uart"
to "amlogic,t7-uart" seem a relevant one.

>
> Thanks,
> Neil