Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-499-gf27bbf33e2-fm-20230619.001-gf27bbf33
Mime-Version: 1.0
Message-Id: <d0bca239-2711-4268-a36c-7c3434982ab1@app.fastmail.com>
In-Reply-To: <6120750daede4eb40fb4d44ed68ba58e5716e038.camel@mediatek.com>
References: <20230609085214.31071-1-yi-de.wu@mediatek.com>
 <20230609085214.31071-6-yi-de.wu@mediatek.com>
 <1a15767c-0518-3763-e8cb-e271df82f87c@collabora.com>
 <6120750daede4eb40fb4d44ed68ba58e5716e038.camel@mediatek.com>
Date:   Tue, 27 Jun 2023 11:27:34 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     =?UTF-8?Q?Yi-De_Wu_=28=E5=90=B3=E4=B8=80=E5=BE=B7=29?= 
        <Yi-De.Wu@mediatek.com>,
        "AngeloGioacchino Del Regno" 
        <angelogioacchino.delregno@collabora.com>,
        "Jonathan Corbet" <corbet@lwn.net>,
        "Catalin Marinas" <catalin.marinas@arm.com>,
        =?UTF-8?Q?Yingshiuan_Pan_=28=E6=BD=98=E7=A9=8E=E8=BB=92=29?= 
        <Yingshiuan.Pan@mediatek.com>,
        "Matthias Brugger" <matthias.bgg@gmail.com>,
        =?UTF-8?Q?Ze-yu_Wang_=28=E7=8E=8B=E6=BE=A4=E5=AE=87=29?= 
        <Ze-yu.Wang@mediatek.com>, "Will Deacon" <will@kernel.org>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "Rob Herring" <robh+dt@kernel.org>,
        =?UTF-8?Q?MY_Chuang_=28=E8=8E=8A=E6=98=8E=E8=BA=8D=29?= 
        <MY.Chuang@mediatek.com>, "Trilok Soni" <quic_tsoni@quicinc.com>,
        "Conor.Dooley" <conor.dooley@microchip.com>,
        =?UTF-8?Q?PeiLun_Suei_=28=E9=9A=8B=E5=9F=B9=E5=80=AB=29?= 
        <PeiLun.Suei@mediatek.com>,
        =?UTF-8?Q?Liju-clr_Chen_=28=E9=99=B3=E9=BA=97=E5=A6=82=29?= 
        <Liju-clr.Chen@mediatek.com>,
        =?UTF-8?Q?Jades_Shih_=28=E6=96=BD=E5=90=91=E7=8E=A8=29?= 
        <jades.shih@mediatek.com>, "Conor Dooley" <conor+dt@kernel.org>,
        "dbrazdil@google.com" <dbrazdil@google.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        =?UTF-8?Q?Shawn_Hsiao_=28=E8=95=AD=E5=BF=97=E7=A5=A5=29?= 
        <shawn.hsiao@mediatek.com>,
        Linux-Arch <linux-arch@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        =?UTF-8?Q?Ivan_Tseng_=28=E6=9B=BE=E5=BF=97=E8=BB=92=29?= 
        <ivan.tseng@mediatek.com>,
        =?UTF-8?Q?Chi-shen_Yeh_=28=E8=91=89=E5=A5=87=E8=BB=92=29?= 
        <Chi-shen.Yeh@mediatek.com>
Subject: Re: [PATCH v4 5/9] virt: geniezone: Add irqfd support
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jun 27, 2023, at 09:54, Yi-De Wu (=E5=90=B3=E4=B8=80=E5=BE=B7) w=
rote:

>> ..snip..=20
>> > diff --git a/drivers/virt/geniezone/gzvm_main.c b/drivers/virt/geni=
ezone/gzvm_main.c > index 230970cb0953..e62c046d76b3 100644 > --- a/driv=
ers/virt/geniezone/gzvm_main.c > +++ b/drivers/virt/geniezone/gzvm_main.=
c > @@ -113,11 +113,12 @@ static int gzvm_drv_probe(void) >   return ret=
; >   gzvm_debug_dev =3D &gzvm_dev; >   > -return 0; > +return gzvm_drv_=
irqfd_init();=20
>> ret =3D gzvm_drv_irqfd_init(); if (ret) return ret;=20

Something went wrong with the quoting up here, please make sure to
use plaintext email instead of html.

>> return 0;=20
>
> We're wondering the pros and cons for this coding style.
> Could you kindly give us some hint for possibly we could miss it somew=
here.
>
> Some other suggestion had been made by AOSP reviewer on the very line=20
> mentioned. As a consequence, we'd like to dig in the rationale behind=20
> such debate.
> https://android-review.googlesource.com/c/kernel/common/+/2574178/comm=
ent/f23bbd52_e3b14396/

I think most developers prefer the shorter form here, and I've
seen cleanup patches actually changing the longer version to that.

     Arnd