Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Jun 2023 12:02:46 +0200
Message-ID: <87ilb9fcjd.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     dengxiang <dengxiang@nfschina.com>
Cc:     tiwai@suse.com, yangyingliang@huawei.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SKU: Set to turn off EAPD control for Internal SPK.
In-Reply-To: <20230627055836.23798-1-dengxiang@nfschina.com>
References: <20230627055836.23798-1-dengxiang@nfschina.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Tue, 27 Jun 2023 07:58:36 +0200,
dengxiang wrote:
> 
> Due to unknown reason that could not support DSP function on Raptor Lake
> platform using v2.5 sof-bin firmware and snd_hda_intel would disable codec
> wakeup twice during snd_hda_intel initialization, Internal SPK is forbidden
> to put sound outside with snd_hda_intel driver on Unis B760 sku machine.
> Now find out that PIN47 EAPD status is always low for ALC897 chip on
> Unis B760 sku.
> Solution: set to turn off EAPD control again in avoid to mute internal SPK.
> 
> Signed-off-by: dengxiang <dengxiang@nfschina.com>
> ---
>  sound/pci/hda/patch_realtek.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 36c4adfb11e7..bb0ee265eb7f 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -534,6 +534,16 @@ static void set_eapd(struct hda_codec *codec, hda_nid_t nid, int on)
>  {
>  	if (get_wcaps_type(get_wcaps(codec, nid)) != AC_WID_PIN)
>  		return;
> +
> +	switch (codec->core.vendor_id) {
> +	case 0x10ec0897:
> +	case 0x80867a50:
> +		on = 0;
> +		break;
> +	default:
> +		break;
> +	}

Sorry, this is definitely no-go.  It matches generically to all
devices that have this codec chip, so you'll break all those devices.


Takashi