Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a339954e-a061-3cd6-78bf-47286a9374eb@redhat.com>
Date:   Tue, 27 Jun 2023 11:47:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] mm/hugetlb: remove hugetlb_set_page_subpool()
Content-Language: en-US
To:     Sidhartha Kumar <sidhartha.kumar@oracle.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc:     akpm@linux-foundation.org, tsahu@linux.ibm.com,
        muchun.song@linux.dev, mike.kravetz@oracle.com
References: <20230623054635.279495-1-sidhartha.kumar@oracle.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230623054635.279495-1-sidhartha.kumar@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 23.06.23 07:46, Sidhartha Kumar wrote:
> All users have been converted to hugetlb_set_folio_subpool() so we can
> safely remove this function.
> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
>   include/linux/hugetlb.h | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index beb7c63d28716..d14676b6d144f 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -761,11 +761,6 @@ static inline void hugetlb_set_folio_subpool(struct folio *folio,
>   	folio->_hugetlb_subpool = subpool;
>   }
>   
> -static inline void hugetlb_set_page_subpool(struct page *hpage,
> -					struct hugepage_subpool *subpool)
> -{
> -	hugetlb_set_folio_subpool(page_folio(hpage), subpool);
> -}
>   
>   static inline struct hstate *hstate_file(struct file *f)
>   {

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Cheers,

David / dhildenb