Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp17499336rwd; Tue, 27 Jun 2023 04:03:19 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5pMVze+1hM/BsvjKkfe6QvgwSQQgm5wHZz3lb3Bavv2WQP5iUSuETYb9nzN9E6JxPvNqON X-Received: by 2002:a17:907:e8b:b0:988:9b29:564f with SMTP id ho11-20020a1709070e8b00b009889b29564fmr25297852ejc.40.1687863798833; Tue, 27 Jun 2023 04:03:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687863798; cv=none; d=google.com; s=arc-20160816; b=QlPJbrjqZLMJx/uLvUVs0TZfq5DdJ3y6qfM8XhCHXQkUFv9acNDqn4Xz7cEIesMD84 gIsqVtEwyMSsBp/k8LkxBt8pOpddR1cPqAHGYnxHq/OjdqDQo3VgGmigLNdEHK9klJLK fEHbuz+YzWAItFeJjZSMMXoMIVLXRGety/4cQDlX3zx8JswICoB6p47LdWZT4RFWkehU DovEGnx8A9yuM/ssY173YapIIfwSQLLZUOYMOal4g7RHXqAzOYmB3juefFbdORH/ci5L lTEGcwaraAWMkKiXXLZBZhiHMPT3JTiL5Gz7XDNOvqB6pXWsY58Xk112Q3rRnjz3CJPW w2ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=v+yk5oH024nJpNsomEfJuaQeRpDXm7gRN158UozW9z0=; fh=7Gtnz8v1F5sYETBIbbz/PDDYft7KV7IALhHRpGqop58=; b=Z1IqUKDKBc3ldl8+BtN63YnHbJrSSstdPtzEmJssYkW7LviYDw8UHJRq9PNpyDH7xC qLr+tVsGJXikfgvvHxNjD9A3ZYwwzpbIfAsvpfbE4GZpVMSX5yxGvcI8giMjquUreOg7 UKQkmQX0BVxWWyGZA7EOC3/NFF/9Qa0NTaqMVQ+XP8wI6LRQJ9wOR/w3uQ2RuMExtA99 ef0/6Mm+AOipHA3GXkO05OpHoG2qb/Vfxfw0nnf9SXjkf+HjXaym6u8hCgXtiHKrIyrl +5mJZ+hHsBv0llxiSZk6X5ko95rlLkn2pHD48FiIpLUS6jzfvab63pSz6ItIP0QYBoN1 pwNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=V2NwjqsU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lw20-20020a170906bcd400b0098e4aef0789si2904174ejb.613.2023.06.27.04.02.50; Tue, 27 Jun 2023 04:03:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=V2NwjqsU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232041AbjF0K0b (ORCPT + 99 others); Tue, 27 Jun 2023 06:26:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231208AbjF0K0C (ORCPT ); Tue, 27 Jun 2023 06:26:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40CD33AAA; Tue, 27 Jun 2023 03:24:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6F6D661117; Tue, 27 Jun 2023 10:24:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D5F7C433C9; Tue, 27 Jun 2023 10:24:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687861466; bh=F1Hg7UsWABbNZA5AQvDBMQsjEQe6h9OaplyEUWz37bw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V2NwjqsUMcDX/nRTxfVAJKchvBq0J8/jCjoiPE/BVWSq5g708DSLg16ic9OHGuGIA yuU5bxvGd6YG+SSKFuayAVa/x5wvWepMKMdGGFdgfHwAvR+pb341M0KuWKavjeak5J sma7fq1Z3LAEcoV/YQiR7MTXGlucUZab2xSmpk5M= Date: Tue, 27 Jun 2023 12:24:24 +0200 From: Greg Kroah-Hartman To: Petr Tesarik Cc: Stefano Stabellini , Thomas Bogendoerfer , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , "Rafael J. Wysocki" , Juergen Gross , Oleksandr Tyshchenko , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Andy Shevchenko , Hans de Goede , Jason Gunthorpe , Kees Cook , Saravana Kannan , "moderated list:XEN HYPERVISOR ARM" , "moderated list:ARM PORT" , open list , "open list:MIPS" , "open list:XEN SWIOTLB SUBSYSTEM" , Roberto Sassu , Kefeng Wang , petr@tesarici.cz Subject: Re: [PATCH v3 1/7] swiotlb: make io_tlb_default_mem local to swiotlb.c Message-ID: <2023062745-routing-palace-d0b4@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 27, 2023 at 11:54:23AM +0200, Petr Tesarik wrote: > +/** > + * is_swiotlb_active() - check if the software IO TLB is initialized > + * @dev: Device to check, or %NULL for the default IO TLB. > + */ > bool is_swiotlb_active(struct device *dev) > { > - struct io_tlb_mem *mem = dev->dma_io_tlb_mem; > + struct io_tlb_mem *mem = dev > + ? dev->dma_io_tlb_mem > + : &io_tlb_default_mem; That's impossible to read and maintain over time, sorry. Please use real "if () else" lines, so that it can be maintained over time. thanks, greg k-h