Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Jun 2023 12:30:03 +0200
From:   Frederic Weisbecker <frederic@kernel.org>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Anna-Maria Behnsen <anna-maria@linutronix.de>,
        John Stultz <jstultz@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Eric Biederman <ebiederm@xmission.com>,
        Oleg Nesterov <oleg@redhat.com>
Subject: Re: [patch 11/45] posix-cpu-timers: Remove incorrect comment in
 posix_cpu_timer_set()
Message-ID: <ZJq6K4XGGVWTGLE2@lothringen>
References: <20230606132949.068951363@linutronix.de>
 <20230606142031.648340279@linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230606142031.648340279@linutronix.de>
Precedence: bulk

On Tue, Jun 06, 2023 at 04:37:36PM +0200, Thomas Gleixner wrote:
> A leftover from historical code which describes fiction.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Reviewed-by: Frederic Weisbecker <frederic@kernel.org>


> ---
>  kernel/time/posix-cpu-timers.c |    7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> --- a/kernel/time/posix-cpu-timers.c
> +++ b/kernel/time/posix-cpu-timers.c
> @@ -704,13 +704,8 @@ static int posix_cpu_timer_set(struct k_
>  		}
>  	}
>  
> +	/* Retry if the timer expiry is running concurrently */
>  	if (unlikely(ret)) {
> -		/*
> -		 * We are colliding with the timer actually firing.
> -		 * Punt after filling in the timer's old value, and
> -		 * disable this firing since we are already reporting
> -		 * it as an overrun (thanks to bump_cpu_timer above).
> -		 */
>  		unlock_task_sighand(p, &flags);
>  		goto out;
>  	}
>