Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Jun 2023 12:58:44 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Xu Yilun <yilun.xu@intel.com>
Cc:     Jim Wylder <jwylder@google.com>,
        Russ Weight <russell.h.weight@intel.com>,
        gregkh@linuxfoundation.org, rafael@kernel.org,
        linux-kernel@vger.kernel.org, matthew.gerlach@linux.intel.com
Subject: Re: [PATCH 1/1] regmap: spi-avmm: Fix regmap_bus max_raw_write
Message-ID: <4fac60f2-ae53-4735-a847-6ebd3e824c61@sirena.org.uk>
References: <20230620202824.380313-1-russell.h.weight@intel.com>
 <ZJfB9zXhizbqmIrm@yilunxu-OptiPlex-7050>
 <c5c95368-eac3-4250-b50a-50f0a526b753@sirena.org.uk>
 <CAEP57O-EsrW0KgSDDnDDEYrvL-SEtO-Ji6oShNzvP3y0o9AqCw@mail.gmail.com>
 <ZJpZJhostb4G1UMt@yilunxu-OptiPlex-7050>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mVOP92SZIrht49D6"
Content-Disposition: inline
In-Reply-To: <ZJpZJhostb4G1UMt@yilunxu-OptiPlex-7050>
Precedence: bulk


--mVOP92SZIrht49D6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 27, 2023 at 11:36:06AM +0800, Xu Yilun wrote:

> I'm a bit prefer to exclude the reg addr, as it is in stable tree now
> and doesn't see strong reason to change it. And suggest regmap-i2c does
> the same as spi do, that is to reserve space for reg addr/padding by
> reducing the max_raw_read/write value, see:

It seems better to keep things like this in the core since every time a
bus has to open code something that's something that the bus can get
wrong, as we've seen here.  This would mean some churn now but going
forwards it'd be less error prone.

--mVOP92SZIrht49D6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSazvMACgkQJNaLcl1U
h9D/Vwf+Jeeen0HBG97mDIfJfSL9gm7Ujsp3364y3g3OplWBpf3Nh2zqeHWO7vFb
2jmohhgNatNtnF3pnaAXJ3eNdsHEKcne86zTSixSUYfoYaJDmS/CLWzI4RfMJ7uS
bSyecAagbkGUGuNQoVf7ATfLLx1m/J1VUu8xwSXr1zU+Gtya7/CAwVMc8Zz/pSF5
zWmj9DX9p0KyHeZ5PSNfWTmYM+k5ETxPgH8konrnRiT3KAhrCG64Zupfwwcx2y4s
RNwuF/KqeuW17jMxu8a2e8WN9vN1OYWUkq7GKYJ1qmjiKVcpDZue4+uP3HE2fyT4
9hgqDFkOMxzXKRl7YajIzZltvmtK7w==
=/rAG
-----END PGP SIGNATURE-----

--mVOP92SZIrht49D6--