Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp17592145rwd; Tue, 27 Jun 2023 05:19:17 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4bNcdBxQ0nJDqnBXFK0nZr4c7sTTmN2HPWPFDqec+AZkCbenaE7rLaj5SQ95mbfkWky5j8 X-Received: by 2002:a17:903:41c7:b0:1b7:ef04:da55 with SMTP id u7-20020a17090341c700b001b7ef04da55mr9744462ple.11.1687868356944; Tue, 27 Jun 2023 05:19:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687868356; cv=none; d=google.com; s=arc-20160816; b=H9CiHf2UoGvimvOraha+8jMHoieT7/Bf4mUPhIHHta+mFdn2k6A76IfdQlzH/7qQVf 84LaRImR97dVyflZVgCCnkJ9r+fjPBcAC21FV3+EcdhoAp1kAbhg0v0QRB2O8l6LW9li RFROB3oM54sz913aTCoTPI9jbpfUBGB+pp1gTAzYzbSJWmvaW3q0mbTSHqd+tN87J3QD fy1Z9DhXcytpvGi88mYjIxjSDtx0FNWTKUvuFaSTIP7JmrvEO6++u+tnmw9zgDQnT0ms ZMr4WuQMGRpP7C4qqeowYZ6ypMZBJaH6dRluYoUn66dwooAKSHWIOAF6067VB1GT4BFi ALwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fxMdUhPKZYQMfTCQoz5OS6RNm2prVytzVBt41LLNMxw=; fh=rbzmoA0bikWEBYlDL/lhkNYsobMOqoq0KkcJh9LNcYs=; b=Kx/D7tA1sF8do9A2iXMghwOw/1lek5ac4IS+Eu3L2WPX6qdK75EBVxOhnyKn4m5N5s QNKEeNiVb40vV8MFNMW0XncoMHLVjkq2CCowMItkl3+dRAEg7S0hNfMyEB2cvKkWo277 IyHC3gThbuNfWeCe2/IO0aGAlJVf4Tt68k7xEgDUBC/f1KW6yzOxcjEMS8Uz/BPuvUde a+N3nwS3mLUF6JksCYkNpXDaLXmRvJiXkoKJCiDA9usfds983kJLEo30MZz2tA5kn95R IjSZKw80vaLczb89UG7cNC07bV1ZXfyHm28uZRsAft4nVK/3e6sYMxb1TEFCrse+qDKT ERrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CSc+55Ox; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d1-20020a170902854100b001b3c66afaaesi6709886plo.185.2023.06.27.05.19.03; Tue, 27 Jun 2023 05:19:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=CSc+55Ox; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231443AbjF0Lgd (ORCPT + 99 others); Tue, 27 Jun 2023 07:36:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231410AbjF0Lgb (ORCPT ); Tue, 27 Jun 2023 07:36:31 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1608326B8; Tue, 27 Jun 2023 04:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687865791; x=1719401791; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=b60RLvgCgE69eplE2j+D0M1hJ0JYNceI2V64TdDSM24=; b=CSc+55OxcVET9qKusGJOdCQOvSjOXZv7/D0JoflxRXx9f8p4jZ0swpnq lxwhMpR3JvsLSdFQVCNSX0kBIpv/H42WQTJt0fX5tuQeODLrNu5OmHUxd TMPHeOmjtFTUVtjVLLBg4j6n7e2R0SC8q3tRVpioNscA3Vji8Ow9QZUgj 35G9NCJDY8ibqZLyOVj/P15TzDgMFJIOVVCFlIO954n8N/E0Z1KgFmTGv WVwqBGGLGvYO4HieOCt4c/KC7h4d4i7UrZagmJ/zYOn1UZkJHKTLMuW2n mXbDm/AvqP+z2TjsF6Pmx7V33WNWWowBYc5BnlpuJ/gTmNrwTzDu8ogVM Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10753"; a="361586295" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="361586295" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 04:36:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10753"; a="806445038" X-IronPort-AV: E=Sophos;i="6.01,162,1684825200"; d="scan'208";a="806445038" Received: from rbhaumik-mobl2.ger.corp.intel.com (HELO box.shutemov.name) ([10.251.217.121]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 04:36:23 -0700 Received: by box.shutemov.name (Postfix, from userid 1000) id D57B0103738; Tue, 27 Jun 2023 14:36:20 +0300 (+03) Date: Tue, 27 Jun 2023 14:36:20 +0300 From: "kirill.shutemov@linux.intel.com" To: "Huang, Kai" Cc: "kvm@vger.kernel.org" , "Raj, Ashok" , "Hansen, Dave" , "david@redhat.com" , "bagasdotme@gmail.com" , "Luck, Tony" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "linux-kernel@vger.kernel.org" , "Christopherson,, Sean" , "mingo@redhat.com" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "tglx@linutronix.de" , "Yamahata, Isaku" , "Chatre, Reinette" , "nik.borisov@suse.com" , "hpa@zytor.com" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "bp@alien8.de" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "x86@kernel.org" , "Williams, Dan J" Subject: Re: [PATCH v12 05/22] x86/virt/tdx: Add SEAMCALL infrastructure Message-ID: <20230627113620.pnxqp7cel66zuldi@box.shutemov.name> References: <20230627094856.6udzuhzhygc4nzit@box.shutemov.name> <102e45dd81589625ed064a742508597e0d118375.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <102e45dd81589625ed064a742508597e0d118375.camel@intel.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 27, 2023 at 10:28:20AM +0000, Huang, Kai wrote: > > Or is that wrapper only used for never-fail SEAMCALLs? If so, please > > document it. > > > > How about adding below? > > Use __seamcall() directly in cases that printing error message isn't > desired, e.g., when SEAMCALL can legally fail with BUSY and the caller > wants to retry. > Looks good to me. -- Kiryl Shutsemau / Kirill A. Shutemov