Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sheng Yong <shengyong@oppo.com>
To:     jaegeuk@kernel.org, chao@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, Sheng Yong <shengyong@oppo.com>
Subject: [PATCH RFC] f2fs: only set release for file that has compressed data
Date:   Tue, 27 Jun 2023 20:21:53 +0800
Message-Id: <20230627122153.1557656-1-shengyong@oppo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vb+thm+6V7MtjslUv3qRt8aUCbVPia0/WsPdSJnW6YeJdxKPm3I31PXQ4Q7j?=
 =?us-ascii?Q?6alSSSulo40wwY4A3bmnbtLRt5a4lJE+98MsVuxRRvmsEnNT4ixxnM4cOWfp?=
 =?us-ascii?Q?VfnHXRN2FO05yifKdPl6ex+eS34wVQkT/X0/hMRPtQ3H+Tn60dWN6DUqnl32?=
 =?us-ascii?Q?GQehw3FcOPL5zavmsTs2nOkxcwLge2kMwLZGxVhxCG0twYc31JVVzIvDOVaL?=
 =?us-ascii?Q?k23kfB3ZJmRXsD7b18fg5gNlAoLRbuyxS470NKqZ1gqLhUI9XzeRttexGBRE?=
 =?us-ascii?Q?NWcyofH1n+vrVdxQgh3rWLvYLZPc/7xMNveTnZhGlzVxl5dvrZJJFb1gVrU+?=
 =?us-ascii?Q?O48tvBFze4At75usEeELLzbgfYUbg4AEEtbCs9W5HjZ/eeaxN1FSHEyyfK9t?=
 =?us-ascii?Q?3oeeKH3o6zRdmKvVnp+Jxm8dlKKdPKUTx5OmHvkrct/qXrnUSmX/0nfAqXQj?=
 =?us-ascii?Q?fgqgj5vCO9ACQMHYYmWQAXIqcitYy2yrO+hxjFiHZZgeA4PwUAaxnwPXF8tl?=
 =?us-ascii?Q?FlSq4ZLXzzfjhD9fd5tVj7qjWw/D5MwGhR2RGCPjNAORooEscg8uXrnzP2fh?=
 =?us-ascii?Q?Kxeddf2puz3R89VfY5ku91S7HtlIgL3iuldsZMMD2cmZFKvuW9p9HuQDcGtZ?=
 =?us-ascii?Q?Tq5MvjdDs766+TALZ8NKaKINBfZ0MS6UY8PHqwXcfOBF01/HgU33I51bqice?=
 =?us-ascii?Q?6vekKJdmrOcBePiJ5gUo4b/jcrDTKhYiNOmBypzHhtrey1Q5EgoV/ZThRyiZ?=
 =?us-ascii?Q?vTtgyR6gWcONh0Ed5dUZ5ocN4txl0AEMqPjGd3yG2O1nbUEvsVCchfwY7OBF?=
 =?us-ascii?Q?0dV7uBnWrP+UppentSvubLGGxfIAXniQA8LjlzELsdwzVSVPtPuingv4MnmZ?=
 =?us-ascii?Q?Sm0RT9akx9h96xOyohZXn9iPr5mkH1OOY5IzotCPFGUUpa2QA7S+oopGfNjO?=
 =?us-ascii?Q?bnh087lrjfNWnUnYdtBIZAPQovv1UasPmMyXfMNKFsCBiOzFIygD7SPKw+fk?=
 =?us-ascii?Q?+ePPU36I0/ucQEF32FKfIzid3c5HLsU687ZAzOyWd5b9+PTFT2YewNsqFZ18?=
 =?us-ascii?Q?6dbCcf/sQcVfaHa7XWFaHW51EVYhNvHn+vmAEL1zRPQECNRV9RfguWtzsX3j?=
 =?us-ascii?Q?NlRNJJcVnPsAWDwbjB/ZVT/63pljRE1yShDCMC5kQHin8MlPb3qUpDBjvTPn?=
 =?us-ascii?Q?JO0/DWHvNtwM5oc2U6PQaWAU1NgqpY/B4zyvDNmZ4+YhdHbFVduSqIWkgYx9?=
 =?us-ascii?Q?clCqkaidvMnPHiG91x7/LOIq/W62YyiFiWYAArdSyYJV0mKMyFyl7Xbpqvut?=
 =?us-ascii?Q?2KnTaDuF/0jR+dvLxsNYyA/dUr/hx9qvUbcPAv0hFYKUB3nOhcVQK+RhqOvR?=
 =?us-ascii?Q?zQSVhRcjh/xXI8iGrqE4VIp5WuJwapm39PGn2IPzG+nX1UCkLHbKpX3nLfhI?=
 =?us-ascii?Q?S88jSWwiBHQKNQZRCEo9og4KPUiuCSXBgYJt8umrBd1JVCTZeDWF/xxmVkQi?=
 =?us-ascii?Q?0kvpoDUmJqgkfHZ/2NMlQad9YEBxzYdXR+w9Z0gWV/RM+xIVno9UKtPHQ/xT?=
 =?us-ascii?Q?pdPSJVc2PxYnHe2h82qoktr6Jb4j/k+gE3wV7FFu?=
X-OriginatorOrg: oppo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1ad00763-6d3d-4fe7-bace-08db77092a39
X-MS-Exchange-CrossTenant-AuthSource: SI2PR02MB5148.apcprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 12:22:25.1357
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gfc7DhzkzDk24AOHR4mAAsinEVnXqiNHAuBKChIY0x4E/0bE13HBzMzbq6RrViLlQSOMzUVnQulolw5RCz01aw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSBPR02MB4469
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

If a file is not comprssed yet or does not have compressed data,
for example, its data has a very low compression ratio, do not
set FI_COMPRESS_RELEASED flag.

Signed-off-by: Sheng Yong <shengyong@oppo.com>
---
 fs/f2fs/file.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index b1a4de3b53e01..0f54c1ff02f71 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3510,13 +3510,15 @@ static int f2fs_release_compress_blocks(struct file *filp, unsigned long arg)
 	if (ret)
 		goto out;
 
+	if (!atomic_read(&F2FS_I(inode)->i_compr_blocks)) {
+		ret = -EPERM;
+		goto out;
+	}
+
 	set_inode_flag(inode, FI_COMPRESS_RELEASED);
 	inode->i_ctime = current_time(inode);
 	f2fs_mark_inode_dirty_sync(inode, true);
 
-	if (!atomic_read(&F2FS_I(inode)->i_compr_blocks))
-		goto out;
-
 	f2fs_down_write(&F2FS_I(inode)->i_gc_rwsem[WRITE]);
 	filemap_invalidate_lock(inode->i_mapping);
 
-- 
2.40.1