Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230620202824.380313-1-russell.h.weight@intel.com>
 <ZJfB9zXhizbqmIrm@yilunxu-OptiPlex-7050> <c5c95368-eac3-4250-b50a-50f0a526b753@sirena.org.uk>
 <CAEP57O-EsrW0KgSDDnDDEYrvL-SEtO-Ji6oShNzvP3y0o9AqCw@mail.gmail.com>
 <ZJpZJhostb4G1UMt@yilunxu-OptiPlex-7050> <4fac60f2-ae53-4735-a847-6ebd3e824c61@sirena.org.uk>
In-Reply-To: <4fac60f2-ae53-4735-a847-6ebd3e824c61@sirena.org.uk>
From:   Jim Wylder <jwylder@google.com>
Date:   Tue, 27 Jun 2023 07:48:24 -0500
Message-ID: <CAEP57O8M8Tzq1rFuw6eoEsrqvJ2TXDzpKK_dcGbU1-2UfAOy9A@mail.gmail.com>
Subject: Re: [PATCH 1/1] regmap: spi-avmm: Fix regmap_bus max_raw_write
To:     Mark Brown <broonie@kernel.org>
Cc:     Xu Yilun <yilun.xu@intel.com>,
        Russ Weight <russell.h.weight@intel.com>,
        gregkh@linuxfoundation.org, rafael@kernel.org,
        linux-kernel@vger.kernel.org, matthew.gerlach@linux.intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jun 27, 2023 at 6:58=E2=80=AFAM Mark Brown <broonie@kernel.org> wro=
te:
>
> On Tue, Jun 27, 2023 at 11:36:06AM +0800, Xu Yilun wrote:
>
> > I'm a bit prefer to exclude the reg addr, as it is in stable tree now
> > and doesn't see strong reason to change it. And suggest regmap-i2c does
> > the same as spi do, that is to reserve space for reg addr/padding by
> > reducing the max_raw_read/write value, see:
>
> It seems better to keep things like this in the core since every time a
> bus has to open code something that's something that the bus can get
> wrong, as we've seen here.  This would mean some churn now but going
> forwards it'd be less error prone.

Agreed.