Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765021AbXJTQLk (ORCPT ); Sat, 20 Oct 2007 12:11:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756099AbXJTQLc (ORCPT ); Sat, 20 Oct 2007 12:11:32 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:38045 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756001AbXJTQLb (ORCPT ); Sat, 20 Oct 2007 12:11:31 -0400 Date: Sat, 20 Oct 2007 17:11:19 +0100 From: Christoph Hellwig To: Arnd Bergmann Cc: Al Viro , Philip Langdale , Jiri Kosina , LKML Subject: Re: [PATCH] compat_ioctl: introduce generic_compat_ioctl helper Message-ID: <20071020161119.GA22065@infradead.org> Mail-Followup-To: Christoph Hellwig , Arnd Bergmann , Al Viro , Philip Langdale , Jiri Kosina , LKML References: <47100864.2090208@overt.org> <20071013000221.GC8181@ftp.linux.org.uk> <200710201750.58521.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710201750.58521.arnd@arndb.de> User-Agent: Mutt/1.4.2.3i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 18 On Sat, Oct 20, 2007 at 05:50:57PM +0200, Arnd Bergmann wrote: > Many drivers use only compatible ioctl numbers. In order to > avoid having to write a special compat_ioctl handler for each > of them or listing every ioctl number in fs/compat_ioctl.c, > let's introduce a generic handler that simply calls the > driver specific f_op->unlocked_ioctl() or f_op->ioctl() handler. At least for the unlocked_ioctl case this is not nessecary because the driver an simply set both the unlocked_ioctl and compat_ioctl handlers to the same function. For the drivers not using unlocked_ioctl yet a function like this makes sense in theory, but I'd prefer to just switch them to ->unlocked_ioctl. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/