Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-4dd71d69-5514-4da0-8c18-a5676a311df2-1687875006833@3c-app-gmx-bs07>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Frank Wunderlich <linux@fw-web.de>,
        linux-mediatek@lists.infradead.org,
        Chaotian Jing <chaotian.jing@mediatek.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Wenbin Mei <wenbin.mei@mediatek.com>,
        Sam Shih <sam.shih@mediatek.com>, linux-mmc@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Aw: Re:  Re: [PATCH v1 1/2] dt-bindings: mmc: mtk-sd: update
 assigned-clocks/clock-parents for mt7986
Content-Type: text/plain; charset=UTF-8
Date:   Tue, 27 Jun 2023 16:10:06 +0200
Importance: normal
Sensitivity: Normal
In-Reply-To: <b6ef76a8-95fc-aa76-d811-ed25ccb8ad8e@linaro.org>
References: <20230625191151.7808-1-linux@fw-web.de>
 <20230625191151.7808-2-linux@fw-web.de>
 <91411797-18b4-f515-d6c0-ca0f8ff39696@linaro.org>
 <trinity-28cad1dc-f8e0-4f65-874f-a2392c2e878e-1687867773444@3c-app-gmx-bs07>
 <b6ef76a8-95fc-aa76-d811-ed25ccb8ad8e@linaro.org>
UI-OutboundReport: notjunk:1;M01:P0:oc/IDCkwfto=;uyMwuWF0joreAn8VyMb6rA3OLle
 KLew97pISH5oXOt+zzFzGQB5tkaorJjmZdciLWsWq/KDEcfWENbej+2y3rRuRl/yxZsDFIxuF
 dbJCOnDbdnYvkzlrS1+ghwMuOPFJQlNHnAJaiHfi6GtmNDp0ITPUMq491nGELu6xrtv+ej/wa
 Ehg+yvN0ZjsVh+ystNLKBCHDPyTfLaoD1QMD1fEvRUY6u35ie9xWO76OxpcnMlFjUSN3uXnAM
 +afIFKzVbtBL4RKMECoj8Az/3SuXUfWI0GxSe/yXVKECkIz6Z1b6lShv9raUFo5dAFCK91iu9
 nDN2HcLeTJgxYJFpKlFaa3n6j5HvjdkvYr9T+tMyBJUGJ/BpocNVugwwL2SwMeYbmbuAFdQiO
 sW+A/oAqKIM37QPtw/XlAkxErK/lH8invVZ0dOM46qA1kDgPvGfcr/Rc++AkWv0/Fsq7UHhHU
 QB+h854E/TCob0i4zIwj1xnBz3wuP21B4eYa87zYaJn+8+Bo225ChxLAL4pMvM7CuiUDN+7a1
 4TjA4GCSE6xOhG1Hv0kuoX4n1xIOcrhGYggOa6bA2jrANJqWZrJ3HiyXw5tAOBPdwSK1l0pU3
 CXDfIb6B+MZn7n19RWUCjUDu7SvA+DcGfAo2iEurqVbJ3Q590ipBpmiOfoVM3454642i4bNZI
 JiRRB8hDHczOdyQ1UVo+Rnweb8gFXVDc1ioeYA5H99Lv0JbVVITDEZdk9JeEVNfT1CdnCt6s2
 IRC4fAvEvveqGqfVGBFwQcP7Mhsqi3PnfYsv5aTfVRBzxzz0Q1EVKxzleTmAhZIEOORIquYPv
 NskoKyUr5oL3iq0x62wQuGYW7d3XmjfH1iasCFZIWjhpE=
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi


> Gesendet: Dienstag, 27. Juni 2023 um 15:37 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
> On 27/06/2023 14:09, Frank Wunderlich wrote:
> >> Gesendet: Dienstag, 27. Juni 2023 um 12:44 Uhr
> >> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
> >> Betreff: Re: [PATCH v1 1/2] dt-bindings: mmc: mtk-sd: update assigned=
-clocks/clock-parents for mt7986
> >>
> >> On 25/06/2023 21:11, Frank Wunderlich wrote:
> >>> From: Frank Wunderlich <frank-w@public-files.de>
> >>>
> >>> MT7986 has 2 clock-parents so update the binding for it.
> >>
> >> You didn't test it, I think. If you do, then you will see errors from
> >> other trees.
> >
> > Hi,
> >
> > i tested it of course...which errors do you see?
>
> The top-level said it can be maximum 1, so raising it in allOf:if:then:
> should not be enough

but the previous error with too long list wasn't there after the change...=
so it seems to work...if it right, i don't know,
but other properties are overriddedn the same way.

> > 11
> > this is basicly how i tested it (in case anything has changed):
> >
> >         logfile=3Ddtbs_arm64.log
> >         exec 3> >(tee $logfile)
> >         ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux-gnu- make DT_CHECKE=
R_FLAGS=3D-m dt_binding_check 2>&3
> >         if [[ $? -ne 0 ]];then echo "arm64 binding check failed!";cat =
$logfile;exit 1;fi
> >         ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux-gnu- make defconfig=
 #dtbs_check need kernel-config
> >         ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux-gnu- make -j8 DT_CH=
ECKER_FLAGS=3D-m dtbs_check 2>&3
> >         if [[ $? -ne 0 ]];then echo "arm64 dtbs_check failed!";cat $lo=
gfile;exit 1;fi
>
> A bit over-complicated... why not running dtbs_check against the schema
> you changed?

it is a script i only start ;) and having a logfile (with all messages - s=
tdin+stdout) makes it easier to find something.
i had always the problem, that second run does not show the errors again w=
ithout changing the yaml or dts.

as you see below i tried the run against the yaml too, but there are many =
many unrelated compatibles which seem to be not
documented or still in txt bindings.

> > and looked into the resulting logfile for keywords like mmc like mtk-s=
d
> >
> > i tried running dtbs_check with passing the yaml-file, but of course a=
ll compatibles not matching this file were reported.
> >
> > ARCH=3Darm64 CROSS_COMPILE=3Daarch64-linux-gnu- make -j6 DT_CHECKER_FL=
AGS=3D-m dtbs_check DT_SCHEMA_FILES=3DDocumentation/devicetree/bindings/mm=
c/mtk-sd.yaml
> >
> > but this spits out many errors "failed to match any schema with compat=
ible" because i defined only the changed one...
> >
> > maybe there is another way to check only one yaml file against all dtb=
s without these unrelated errors.
> >
> > pipeline in dt-bindings-patchwork is clean too
> > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/2023062=
5191151.7808-2-linux@fw-web.de/
>
> Maybe that binding just fails to apply to DTS because of missing or not
> correct compatibles.

the messages are unrelated to current yaml file i passed with the DT_SCHEM=
A_FILES parameter, e.g. the last messages:

	From schema: Documentation/devicetree/bindings/display/mediatek/mediatek,=
dsi.yaml
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb:0:0: /soc/sys=
con@15020000: failed to match any schema with compatible: ['mediatek,mt818=
3-imgsys', 'syscon']
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb:0:0: /soc/sys=
con@16000000: failed to match any schema with compatible: ['mediatek,mt818=
3-vdecsys', 'syscon']
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb:0:0: /soc/sys=
con@17000000: failed to match any schema with compatible: ['mediatek,mt818=
3-vencsys', 'syscon']
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb:0:0: /soc/sys=
con@19000000: failed to match any schema with compatible: ['mediatek,mt818=
3-ipu_conn', 'syscon']
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb:0:0: /soc/sys=
con@19010000: failed to match any schema with compatible: ['mediatek,mt818=
3-ipu_adl', 'syscon']
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb:0:0: /soc/sys=
con@19180000: failed to match any schema with compatible: ['mediatek,mt818=
3-ipu_core0', 'syscon']
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb:0:0: /soc/sys=
con@19280000: failed to match any schema with compatible: ['mediatek,mt818=
3-ipu_core1', 'syscon']
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb:0:0: /soc/sys=
con@1a000000: failed to match any schema with compatible: ['mediatek,mt818=
3-camsys', 'syscon']
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb:0:0: /mt8183-=
sound: failed to match any schema with compatible: ['mediatek,mt8183_mt635=
8_ts3a227_max98357']
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-burnet.dtb: bt-sco: '#so=
und-dai-cells' is a required property

> >> Anyway, I don't understand why defining it in the first place. Just d=
rop
> >> the assigned-clock* from the binding.
> >
> > as it was defined (not looked where it was used) i only used the soc-s=
pecific branch to update the MaxItems...just to not break anything. After =
that the message i got before was fixed
> >
> > arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: mmc@11230000=
: assigned-clocks: [[4, 35], [4, 34]] is too long
> > arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dtb: mmc@11230000=
: assigned-clock-parents: [[5, 6], [4, 18]] is too long
> >
> > but if the right way is to drop the MaxItems from generic (or the prop=
erty itself - where is it taken from then?). The only
> > include i see is Documentation/devicetree/bindings/mmc/mmc-controller.=
yaml and there the assigned-clock* is not defined. And the
>
> The way is to entirely drop assigned-clocks. I don't think there are
> much benefits of having them in the bindings. Maybe if specific rates
> are required, then yes - device cannot work with other rates and you can
> verify it with dtbs_check. But otherwise it is like adding values of
> 'reg' or 'interrupts'. Plus some board might require third item and then
> what?

mhm, disabled all assigned-clock* properties and do not get any messages a=
bout this (don't know why because of "unevaluatedProperties: false", but l=
ooks like it works)

there are only some syscon-nodes in mt8173-*.dtb where these properties us=
ed are reported

btw. need binding also be backported to stable? so do i need to add the ta=
g there?

regards Frank