Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759484AbXJTRWc (ORCPT ); Sat, 20 Oct 2007 13:22:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756230AbXJTRWX (ORCPT ); Sat, 20 Oct 2007 13:22:23 -0400 Received: from mx2.netapp.com ([216.240.18.37]:24903 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754638AbXJTRWW (ORCPT ); Sat, 20 Oct 2007 13:22:22 -0400 X-IronPort-AV: E=Sophos;i="4.21,304,1188802800"; d="scan'208";a="115462095" Subject: Re: [NFS] [GIT] NFS client fixes for 2.6.23++ From: Trond Myklebust To: Linus Torvalds Cc: Erez Zadok , nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org In-Reply-To: References: <200710200219.l9K2JMI8015439@agora.fsl.cs.sunysb.edu> Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: Network Appliance Inc Date: Sat, 20 Oct 2007 13:22:37 -0400 Message-Id: <1192900957.7440.10.camel@heimdal.trondhjem.org> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0 X-OriginalArrivalTime: 20 Oct 2007 17:22:21.0061 (UTC) FILETIME=[C5AF9350:01C8133D] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1806 Lines: 59 On Fri, 2007-10-19 at 19:32 -0700, Linus Torvalds wrote: > > On Fri, 19 Oct 2007, Erez Zadok wrote: > > > > Trond, with Linus's latest tree, you need to #include in > > fs/nfs/unlink.c, else I get: > > > > CC [M] fs/nfs/unlink.o > > fs/nfs/unlink.c: In function 'nfs_dec_sillycount': > > fs/nfs/unlink.c:67: error: 'TASK_UNINTERRUPTIBLE' undeclared (first use in this function) > ... > > Hmm? Which architecture? > > That said, I do think that there is a distinct lack of proper includes in > that file. It seems to depend on getting much of the includes indirectly > from and friends. And with different architectures having > different header files.. > > Linus This ought to fix it. ---------------------------------------------------- From: Trond Myklebust Date: Sat, 20 Oct 2007 13:21:04 -0400 NFS: Fix the include files needed by fs/nfs/unlink.c Signed-off-by: Trond Myklebust --- fs/nfs/unlink.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/fs/nfs/unlink.c b/fs/nfs/unlink.c index 6ecd46c..057e6ce 100644 --- a/fs/nfs/unlink.c +++ b/fs/nfs/unlink.c @@ -5,9 +5,14 @@ * */ +#include +#include #include #include -#include +#include +#include +#include +#include #include #include #include - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/