Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Jun 2023 17:11:15 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org,
        Harini Katakam <harini.katakam@amd.com>
Subject: Re: [PATCH v2 net-next] net: phy: mscc: fix packet loss due to RGMII
 delays
Message-ID: <ZJr8E7iyKnOxlPgG@corigine.com>
References: <20230627134235.3453358-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230627134235.3453358-1-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RJ8EL4/sPYsZHZwzS5PisdUrydDP5xFJEcrECl71ulLq+HYMkVP7EWoS5W4U?=
 =?us-ascii?Q?sgWxg7C7NzT3wKYM8iJ+VECzi6ONpDqNyJmhg2882OfL1MjZoLS64yCbYI4F?=
 =?us-ascii?Q?zpuYAYdjtefK/u2FZTbHlC+n250dCPdDtKytBjlsA0VZpbgDarj/JcAc5F3F?=
 =?us-ascii?Q?os08n0Kx6YYN8dWfHLTGu1jpohwyY4dfTp5KEf++V4dpiIPtIE6r3kh0z4V1?=
 =?us-ascii?Q?HXCq0J5gsoRz4QxDD3NzkBw01baiQlhXX/EU0nZqJ2HTGFIEQ9rUUcqXG8AJ?=
 =?us-ascii?Q?D0irPSHWWVVSsgp7h/5RnjOt4kPjM5T5IfqTJ/bAnqy/U0FIUQa5cJXjhGRT?=
 =?us-ascii?Q?VqaDwmDvMMQpOAsB3PzGJp4FtxdSZT5pLyOPHH7BjfuoG46ZMJcEcxXQlfCD?=
 =?us-ascii?Q?uW4G3s031l6aaFZmWf8C4BfyALaWGOgahspcXAlfLSLJII0eQNBqVWG1anyw?=
 =?us-ascii?Q?ZBfcjgDnX4sqBoGkt2TpwlO+kKT5Hdys4xcWzxa92uENoQKeyfgFTSb6m1IZ?=
 =?us-ascii?Q?KDB8VNT7qFqug2p6D6dFSxuKbCy9MbGiIoMonjAVZzrCpJq3XDcAsGaLlHa+?=
 =?us-ascii?Q?n40YVyFNDeMrzG4+hhUAsxaWzXzgZiovt62JGDHjy4bQjKXTqAEEuqwPgxaM?=
 =?us-ascii?Q?MvX9lJTnwoDy9SezH89DZxNYPUoWnwhnye+cD75RUb4GCaNX7kMbnuJSuNQo?=
 =?us-ascii?Q?MLmZk4m9JD2XznBurxwGvspibLbAnZXgxH/9MLDK7QBpaQWE2dSPSQP0QN6c?=
 =?us-ascii?Q?VZJ8ndn4pHiGlaiFgPrIokz/srgR+aiR/YHCxt8nCKBa783rEG7Qt3ds9Omq?=
 =?us-ascii?Q?j3e7+DsnVof92Xn2jpRZ2wTWWFkiD4IPUpw44QzSPyz8CbzBytaKCxiOhbyh?=
 =?us-ascii?Q?xtJqGDwifNWKVUdEaVPEMD/jcNEnP2owDmvFRK7h2nSFuWyEoUk6rqeRFKaK?=
 =?us-ascii?Q?E16tXWmMC4PbfNq7fKsjS5+rfHaCTiM4t4/ORJCIGKD9WDvR9irHSa4J1xQz?=
 =?us-ascii?Q?Z3y4Qh4OxWkjtszvMQfigs4QcEVz2bxNqMVbLS5kjYSFn1vwJ22KGh6keGtD?=
 =?us-ascii?Q?pK3jLsKaKznV41bBUEP/IHfxlwyzdK3B65xlCtwBsMdGm9xnRZaDLGqlqFBg?=
 =?us-ascii?Q?BDXKdx5CEkyfiH2r9mBYaqSYC/qUOMQQJw2jNTR9S57I+dz+U5QJ14VTe6f9?=
 =?us-ascii?Q?iI3KnoJn3BGu1D9aejpDjq9otDapO/Fg9sVrJhV4WeB/Tn/rim39b/Uq+2rp?=
 =?us-ascii?Q?snJXGav/Fg+1ugPLCWCD9sMCo5ToR9tlO3voPmE7kC5reqAwxNqhX1FYu8W0?=
 =?us-ascii?Q?i+gQLpZi2SHGAPiECcoClxyhEBH/qTg+s4J1x/msASXo+wHjWMFFIJ2iA1cF?=
 =?us-ascii?Q?Ur41PbhuTaetUhLv8fm0AFiygJw+fHLpHKgia2we9POIU+5c1pMex81sPDPW?=
 =?us-ascii?Q?uYqNUvDBLTj+QrWSSgyiZGRMUA9dl0xm5eQ5Df2ZvjKd5t1lCUk8Ocl+Jckn?=
 =?us-ascii?Q?NZeU9/h4RQ6BQsqFor7DWCGTYkIX0DqNx6HdgECb81EJZ27ft4Y/6fq0PnDs?=
 =?us-ascii?Q?p6j7jVmw4rz9xLOqY48LPE3w7LObQ2jCMkuiB8QzlJcgKG+2Ydn2zet60VTv?=
 =?us-ascii?Q?VyaQiYtGEKP/t/KZvAqyd4074T7WP3As4I+0FfcQgzyEbinYG+4wWiLWbe05?=
 =?us-ascii?Q?GnmdVA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 93a2b2a7-4a65-41ce-6020-08db7720c501
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 15:11:23.2526
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d1dEtXEC97a2D/wKsIZa+jES3UU2nJSnA2Yf2YawVBT4/O86h8x78+/JDsY12lnHj+OkCn/0DPBw15YhT3R4nrkV1JJPiC3vTxa5LKHMv8g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3795
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 27, 2023 at 04:42:35PM +0300, Vladimir Oltean wrote:
> Two deadly typos break RX and TX traffic on the VSC8502 PHY using RGMII
> if phy-mode = "rgmii-id" or "rgmii-txid", and no "tx-internal-delay-ps"
> override exists. The negative error code from phy_get_internal_delay()
> does not get overridden with the delay deduced from the phy-mode, and
> later gets committed to hardware. Also, the rx_delay gets overridden by
> what should have been the tx_delay.
> 
> Fixes: dbb050d2bfc8 ("phy: mscc: Add support for RGMII delay configuration")
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Reviewed-by: Harini Katakam <harini.katakam@amd.com>
> ---
> v1->v2: resend to net-next

Patch looks good.

Reviewed-by: Simon Horman <simon.horman@corigine.com>

Though, TBH, I'm unsure what the correct tree is at this point.