Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp17902516rwd; Tue, 27 Jun 2023 08:58:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4pLttYC7TAyPLCpiAX39J/N/06NCmcM8WpRS9NFRvfqDmA768idU+fzT+JlyVujBP4z2bo X-Received: by 2002:a17:90a:930f:b0:262:ebb9:dd59 with SMTP id p15-20020a17090a930f00b00262ebb9dd59mr6097942pjo.20.1687881482952; Tue, 27 Jun 2023 08:58:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687881482; cv=none; d=google.com; s=arc-20160816; b=VriRCpr0n7WNp9x5qaBingjCD2ZvjCrqXrGHDf+rmTGsPD95UEv2CagNztwOZ2vleA wU7F9SCL+T/a9EM3if2tsCQH8MVEX2CVLXq35p6GdKhRITLQj82OFTnZSA3YPugUPm9W tF18okZKlLKGKAtVRQKnlViXIr+B4dnAo581sdH70dihoDq3OTgMSNtyO5i/ztdoPSy6 BDur3J+88cjJ42mTjAntXq+mcgLWVr4KEGKbzNyggSkmu8n261f71cRe7tven6YLYM60 kDLK8h3KRDSXuQQWmfB4/0babADmAXG9ek3WO3p/X/akkQtqSPuehXcEcrRGinPYLGA6 pqIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=I/AYou/hmRX2B6lJ5zZeKGVvfZlSURc6QLPNYldu4r0=; fh=yKFStV8yk6V4QqopoY7PBZY8XRbFnMs8JawEHaZkDsQ=; b=T/Qyj20xuNH1Ge3VOgcnM0E0I1/x0D130LpQtNdiV9OXykHk5sf7OCoKjaBqr3rjxT fLIl4vLznwADBKHEMyc+US9/yDM1PIMq6275U269wbymVHU64NmtbkIQDdV0vOWDxTEz dMQKUPfIYonKQvmj8kd7Y9ButiTc8h1CjXkDa0ZIiDtlckXZNxwKhvbEbsEa3zcUVOxQ YmqBwcAYySM0c7JjLIyHnkF4SO7R9hGwflFMhqEo6PCKhvA+SFIhv8oGKnAPmsRCnPaE RLsgwhV1+5CGLmkOtWvdXtvc09SfH5eoK19YexSq2N1sLAlc0ek+rl6oSvyjErxxGCzR 5a8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=THP1uOpq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pg18-20020a17090b1e1200b0025c1ff9cd67si8258543pjb.184.2023.06.27.08.57.49; Tue, 27 Jun 2023 08:58:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=THP1uOpq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230465AbjF0Pq6 (ORCPT + 99 others); Tue, 27 Jun 2023 11:46:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229629AbjF0Pq5 (ORCPT ); Tue, 27 Jun 2023 11:46:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13514FC for ; Tue, 27 Jun 2023 08:46:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 698E0611D1 for ; Tue, 27 Jun 2023 15:46:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F171C433C8; Tue, 27 Jun 2023 15:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687880812; bh=citRCY1nXVM5YZjWqN+A8/dMciHAof7pxHR25ffEWQQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=THP1uOpqKpG4iNLYRsx15JbN7wHnC/BFSxc51Tx28ToHIYQD+Ad49doHsw9tUHnwk TdWUv+bKLJqn9cs7xRX+/Yx+yB5NPVsjwJNwcIXUwc1ir55zTeP8JNN7kOuVcrqfWy lrZ89+2lIEc7lXcCrgNzobFDd8UFRm9SS5icb/M1Rnv0kgbz4tTq56PiaoFgW+S88+ wCmNmxDBCTYCQwWWRYo+Pg9B8MtPCTMEeBUMgM3BDOoqCIjeI+ZPGadV7fmgQtYE0Z Ke+JYr/pQ9Jj3VbHYWkAmaHS1tx5mJXMo/kA6QkG0wLvSD0dDk7tMR41jbq16m2g5p wk197WmcbQQdg== Date: Tue, 27 Jun 2023 08:46:51 -0700 From: Jakub Kicinski To: Vladimir Oltean Cc: Vladimir Oltean , netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Paolo Abeni , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Xiaoliang Yang , Richard Cochran , Antoine Tenart , linux-kernel@vger.kernel.org Subject: Re: [PATCH net 3/3] net: dsa: felix: don't drop PTP frames with tag_8021q when RX timestamping is disabled Message-ID: <20230627084651.055a228c@kernel.org> In-Reply-To: <20230627151222.bn3vboqjutkqzxjs@skbuf> References: <20230626154003.3153076-1-vladimir.oltean@nxp.com> <20230626154003.3153076-4-vladimir.oltean@nxp.com> <20230627151222.bn3vboqjutkqzxjs@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Jun 2023 18:12:22 +0300 Vladimir Oltean wrote: > This is still not as good as I had wanted it, because simply checking > for HWTSTAMP_FILTER_NONE does not distinguish between L2 and L4 > timestamping filters, and a port configured just with L2 traps will > still drop L4 PTP packets. Out of curiosity - quick survey on why your reply does not contain: pw-bot: changes-requested a) your email address is different and the bot doesn't understand aliases b) commands are hard to remember c) don't care about patchwork d) laziness e) other